Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Generalize DataSourcePicker/datasourceid usage #1816

Closed
derek-ho opened this issue Mar 5, 2024 · 4 comments
Closed

[FEATURE] Generalize DataSourcePicker/datasourceid usage #1816

derek-ho opened this issue Mar 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

derek-ho commented Mar 5, 2024

Is your feature request related to a problem?

@derek-ho derek-ho added enhancement New feature or request untriaged labels Mar 5, 2024
@derek-ho
Copy link
Collaborator Author

derek-ho commented Mar 7, 2024

Comprehensive Cypress tests will be blocked on: #1815 - we need some indication of success or failure that we can rely on when running cypress tests, since it will be difficult/impossible to verify that the backend has received/executed the call correctly in github runners cypress testing.

@cwperks
Copy link
Member

cwperks commented Mar 18, 2024

[Triage] @derek-ho Can you please add acceptance criteria on this issue? Removing the untriaged label.

@cwperks cwperks removed the triaged label Mar 18, 2024
@derek-ho derek-ho changed the title [FEATURE] DataSourcePicker Usage [FEATURE] Generalize DataSourcePicker/datasourceid usage Mar 18, 2024
@derek-ho
Copy link
Collaborator Author

Acceptance criteria:

  • Decide on the approach out of two current options to maintain dataSourceId context within our plugin: local/session storage and useState/useContext that gets passed down into the tabs.
  • Implement that decision in the context of the requests for two tabs

@derek-ho
Copy link
Collaborator Author

Merged into feature branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

3 participants