Register Datasource Picker in the top nav menu for Get Started Tab #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-ho
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/supporting-multiple-datasources #1818 +/- ##
===========================================================================
+ Coverage 67.52% 67.65% +0.13%
===========================================================================
Files 94 95 +1
Lines 2414 2427 +13
Branches 327 330 +3
===========================================================================
+ Hits 1630 1642 +12
- Misses 706 707 +1
Partials 78 78 ☔ View full report in Codecov by Sentry. |
3 tasks
DarshitChanpura
force-pushed
the
top-nav-menu
branch
4 times, most recently
from
08668bc
to
6a27220
Compare
derek-ho
changed the base branch from
main
to
feature/supporting-multiple-datasources
DarshitChanpura
force-pushed
the
top-nav-menu
branch
7 times, most recently
from
2a0ba26
to
95158fa
Compare
DarshitChanpura
force-pushed
the
feature/supporting-multiple-datasources
branch
from
929dd88
to
942b2f7
Compare
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
top-nav-menu
branch
from
37de405
to
e33907e
Compare
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
changed the title
derek-ho
requested review from
cliu123,
cwperks and
DarshitChanpura
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
commented
Mar 14, 2024
There was a problem hiding this comment.
looks close to me from the first pass. left some comments. Thanks @derek-ho for taking this on!
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
reviewed
Mar 18, 2024
cwperks
reviewed
Mar 18, 2024
.github/workflows/cypress-test-multidatasources-disabled-e2e.yml
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Mar 18, 2024
cwperks
reviewed
Mar 18, 2024
cwperks
reviewed
Mar 18, 2024
cwperks
reviewed
Mar 18, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
approved these changes
Mar 19, 2024
cwperks
reviewed
Mar 19, 2024
| @@ -745,21 +747,20 @@ export function defineRoutes(router: IRouter) { | |||
| router.delete( | |||
| { | |||
| path: `${API_PREFIX}/configuration/cache`, | |||
| validate: false, | |||
| validate: { | |||
| body: schema.object({ | |||
There was a problem hiding this comment.
Should dataSourceId(s) always be passed in as query params?
There was a problem hiding this comment.
Yea, since we control all the places this is called (only in the get started tab) I think it's fine to require it. This isn't using query params though it's only an internal implementation. However I think this is a two way door decision and once more routes are modified we can easily refactor it to a cleaner way if we find one
There was a problem hiding this comment.
If that makes sense can you merge? Thanks!
DarshitChanpura
approved these changes
Mar 20, 2024
DarshitChanpura
merged commit 4ba9fcf
into
opensearch-project:feature/supporting-multiple-datasources
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Registers the new DataSource picker component from core in the top nav menu for the "Get Started" Tab.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
New feature
Why these changes are required?
What is the old behavior before changes and new behavior after changes?
Old behavior is no selector, new behavior is shown in this video:
Screen.Recording.2024-03-20.at.10.53.21.AM.mov
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Fix: #1796, Fix: #1816 Fix: #1795
Testing
Manual testing, unit tests added, e2e cypress test added
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.