Adds Cluster Selector to the Security Plugin if multi-datasources enabled

[derek-ho]

Description

Adds dataSourceManagement as a required bundle. This is necessary to import the shared cluster selector component that should be used to support multi datasources in the security dashboards plugin. It adds this component to the top nav if multi datasources feature is enabled, and does not do so if it is disabled. It also adds unit and cypress tests verifying this behavior.

Category

Enhancement

Why these changes are required?

This is needed to import and use the shared component coming from OSD core.

What is the old behavior before changes and new behavior after changes?

Very crude UI/UX but this PR simply registers the component to the left of the avatar if datasources are enabled. TODO: right now it is registered globally, we need to figure out how to register it only for the security plugin screens. However, OSD core may expose this in the future, so thus not spending too much time tinkering with it.

Issues Resolved

Closes: #1795

Testing

Plugin should build and existing tests should pass

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.31%. Comparing base (9516bea) to head (cbaf763).

Files	Patch %	Lines
public/apps/account/cluster-selector.tsx	42.85%	4 Missing ⚠️
public/plugin.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                             Coverage Diff                             @@
##           feature/supporting-multiple-datasources    #1810      +/-   ##
===========================================================================
- Coverage                                    67.41%   67.31%   -0.10%     
===========================================================================
  Files                                           94       95       +1     
  Lines                                         2409     2417       +8     
  Branches                                       321      322       +1     
===========================================================================
+ Hits                                          1624     1627       +3     
- Misses                                         707      712       +5     
  Partials                                        78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[derek-ho]

The default is that its disabled, so it might be cleaner to just add a simple assertion to an existing cypress test that asserts the cluster selector is not present. Decided to break this out for clarity/I can remove this file and move it into another file as part of cleanup.

[derek-ho]

TODO: building the plugin fails when adding dataSourceManagement as a "required bundle", even though it is suggested to do so by the core team. I opened an issue in core here: opensearch-project/OpenSearch-Dashboards#6018 to get more clarity, but removed it for now from this PR. Will follow up after core responds to the issue.

[derek-ho]

Reverted it back since without it it a different error is thrown. Will be ok to merge this with build/install workflow failing but everything else passing, until core puts in a fix or suggests a workaround.

[derek-ho]

Added it as an optional plugin as per suggestion from @BionIT

[derek-ho]

Optional is not working. Leaving it as requiredBundle, even though this is failing yarn build/install workflow for now.

[derek-ho]

Ignoring code cov for now, since changes are in flight to use different components and registration methods. We can do a final codecov check when merging the feature branch into main.

[cwperks]

Should we call this datasource selector to be consistent with the naming for multiple data sources?

[derek-ho]

I can get onboard with that - however, in the next PR I will be removing this entirely so I think it's ok to keep it as is. The next PR will pick up the data source selector that will get built into the TopNavMenu, however that is not in main yet. The PR will get raised once the changes are in main.

[derek-ho]

Marking as draft first - when I get back next week if things are in OSD core by that point will replace this one in favor of the more complete PR

[derek-ho]

Closing this since OSD merged changes into main that I will consume in #1818