Add loose flag to OSD bootstrap #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
=======================================
Coverage 67.27% 67.27%
=======================================
Files 94 94
Lines 2408 2408
Branches 320 320
=======================================
Hits 1620 1620
Misses 711 711
Partials 77 77 ☔ View full report in Codecov by Sentry. |
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
peternied
approved these changes
Feb 19, 2024
DarshitChanpura
approved these changes
Feb 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 10646ab)
cwperks
pushed a commit
that referenced
this pull request
Feb 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from: opensearch-project/OpenSearch-Dashboards#5675, this PR adds the flag to have loose single-version dependencies. Ideally this should not be enforced for devDependencies, but should unblock the build.
Category
CI fix.
Why these changes are required?
OSD core added a dependency to cypress 9.5.4 (mismatching with the version in this repo) here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5725/files#r1494915750, leading to error at bootstrap.
What is the old behavior before changes and new behavior after changes?
Old behavior is that the bootstrap process would fail. OSD core added a dependency to cypress 9.5.4 in this PR: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5725/files#r1494915750. Since we need cypress 13 in order to run our test suites (including cross-origin support), bootstrapping the plugin with OSD fails since there is a version mismatch. With this new flag, this inconsistency is ignored and the CI is green.
Issues Resolved
Related to: #1786. However that issue is coming from autocuts. We need opensearch-build repo to take in this change to close the autocut.
Testing
Testing done via Github Actions
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.