Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add loose flag to OSD bootstrap #1789

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 10646ab from #1787

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 10646ab)
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1d93a5) 66.94% compared to head (e29fcf0) 66.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1789   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files          93       93           
  Lines        2357     2357           
  Branches      313      313           
=======================================
  Hits         1578     1578           
  Misses        703      703           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Feb 19, 2024

Btw do we need to also backport this in 2.12? It seems like the Dashboards core does have this change on 2.12 branch? @derek-ho

@derek-ho
Copy link
Collaborator

Btw do we need to also backport this in 2.12? It seems like the Dashboards core does have this change on 2.12 branch? @derek-ho

The commit that introduces cypress dependency is only in 2.x and not in 2.12, or possibly not yet since backport fails, so this is not necessary for 2.12.

@cwperks cwperks merged commit c31e8f3 into 2.x Feb 20, 2024
26 checks passed
@github-actions github-actions bot deleted the backport/backport-1787-to-2.x branch February 20, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants