Removes unused get/post/put cache endpoint (#4761)

Signed-off-by: Derek Ho <dxho@amazon.com>
opensearch-project · Oct 1, 2024 · 0a9addb · 0a9addb
1 parent 3ad09c8
commit 0a9addb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/...tegrationTest/java/org/opensearch/security/api/DefaultApiAvailabilityIntegrationTest.java b/...tegrationTest/java/org/opensearch/security/api/DefaultApiAvailabilityIntegrationTest.java
@@ -95,16 +95,11 @@ private void verifyAuthInfoApi(final TestRestClient client) throws Exception {
 
     @Test
     public void flushCache() throws Exception {
-        withUser(NEW_USER, client -> {
-            forbidden(() -> client.get(apiPath("cache")));
-            forbidden(() -> client.postJson(apiPath("cache"), EMPTY_BODY));
-            forbidden(() -> client.putJson(apiPath("cache"), EMPTY_BODY));
-            forbidden(() -> client.delete(apiPath("cache")));
-        });
+        withUser(NEW_USER, client -> { forbidden(() -> client.delete(apiPath("cache"))); });
         withUser(ADMIN_USER_NAME, localCluster.getAdminCertificate(), client -> {
-            notImplemented(() -> client.get(apiPath("cache")));
-            notImplemented(() -> client.postJson(apiPath("cache"), EMPTY_BODY));
-            notImplemented(() -> client.putJson(apiPath("cache"), EMPTY_BODY));
+            methodNotAllowed(() -> client.get(apiPath("cache")));
+            methodNotAllowed(() -> client.postJson(apiPath("cache"), EMPTY_BODY));
+            methodNotAllowed(() -> client.putJson(apiPath("cache"), EMPTY_BODY));
             final var response = ok(() -> client.delete(apiPath("cache")));
             assertThat(response.getBody(), response.getTextFromJsonBody("/message"), is("Cache flushed successfully."));
         });

diff --git a/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java b/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java
@@ -36,14 +36,7 @@ public class FlushCacheApiAction extends AbstractApiAction {
 
     private final static Logger LOGGER = LogManager.getLogger(FlushCacheApiAction.class);
 
-    private static final List<Route> routes = addRoutesPrefix(
-        ImmutableList.of(
-            new Route(Method.DELETE, "/cache"),
-            new Route(Method.GET, "/cache"),
-            new Route(Method.PUT, "/cache"),
-            new Route(Method.POST, "/cache")
-        )
-    );
+    private static final List<Route> routes = addRoutesPrefix(ImmutableList.of(new Route(Method.DELETE, "/cache")));
 
     @Inject
     public FlushCacheApiAction(