-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unused get/post/put cache endpoint #4761
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
@DarshitChanpura how do we mark this as deprecated in the 2.x line? Just add a Java annotation @ Deprecated? |
@derek-ho We can use the DeprecationLogger and add a warning to the API response if someone calls the endpoint with one of the deprecated verbs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
==========================================
- Coverage 65.64% 65.60% -0.04%
==========================================
Files 321 321
Lines 22539 22538 -1
Branches 3611 3611
==========================================
- Hits 14795 14786 -9
- Misses 5932 5939 +7
- Partials 1812 1813 +1
|
@derek-ho could you please fix |
Signed-off-by: Derek Ho <dxho@amazon.com>
6498e53
@derek-ho Can you also raise a PR against the API specification repo to reflect this change? |
Merging this into main. @derek-ho please open a backport with the deprecation messages discussed above. |
Description
Removes Get, Post, Put cache API routes, since only delete is used. This should not be backported to 2.x, and we should add a deprecation notice there as well (although these were never used anyway so the behavior should be consistent)
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.