Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport opendistro-1.1 #1044

Merged
merged 3 commits into from
Feb 22, 2021
Merged

backport opendistro-1.1 #1044

merged 3 commits into from
Feb 22, 2021

Conversation

sujithvm
Copy link
Contributor

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?
    Optimization

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    Unit testing

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
    NA

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)
    Yes. Commits included in commit messages

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

* Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts

* Use hash set instead of tree set as we are not taking any advantage of ordering

* Convert collection to list

(cherry picked from commit db56dc2)
@sujithvm sujithvm requested a review from a team as a code owner February 22, 2021 20:15
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #1044 (6276724) into opendistro-1.1 (b785a46) will increase coverage by 0.01%.
The diff coverage is 70.73%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             opendistro-1.1    #1044      +/-   ##
====================================================
+ Coverage             63.33%   63.34%   +0.01%     
- Complexity             3003     3004       +1     
====================================================
  Files                   235      235              
  Lines                 16510    16499      -11     
  Branches               2963     2958       -5     
====================================================
- Hits                  10457    10452       -5     
- Misses                 4535     4538       +3     
+ Partials               1518     1509       -9     
Impacted Files Coverage Δ Complexity Δ
...earch/security/privileges/PrivilegesEvaluator.java 65.16% <37.50%> (-0.86%) 73.00 <0.00> (+2.00) ⬇️
...earch/security/resolver/IndexResolverReplacer.java 61.01% <63.33%> (+2.46%) 79.00 <0.00> (ø)
...ticsearch/security/securityconf/ConfigModelV6.java 27.90% <63.63%> (+0.11%) 5.00 <0.00> (ø)
...ticsearch/security/securityconf/ConfigModelV7.java 63.36% <100.00%> (ø) 22.00 <0.00> (ø)
...security/auditlog/AuditLogSslExceptionHandler.java 33.33% <0.00%> (-9.53%) 3.00% <0.00%> (-1.00%)
...transport/OpenDistroSecuritySSLNettyTransport.java 41.84% <0.00%> (-4.26%) 4.00% <0.00%> (-1.00%)
...ticsearch/security/auditlog/impl/AuditLogImpl.java 84.61% <0.00%> (-1.10%) 41.00% <0.00%> (-1.00%)
...ecurity/configuration/ConfigurationRepository.java 68.30% <0.00%> (-0.55%) 21.00% <0.00%> (-1.00%)
...search/security/tools/OpenDistroSecurityAdmin.java 46.91% <0.00%> (-0.14%) 74.00% <0.00%> (ø%)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 58.01% <0.00%> (+0.76%) 24.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b785a46...6276724. Read the comment docs.

@hardik-k-shah hardik-k-shah merged commit 4bccd79 into opensearch-project:opendistro-1.1 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants