Optimize by avoid creating wildcard matchers for every request #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constant resources users, backend roles, hosts
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
============================================
+ Coverage 64.45% 64.49% +0.04%
- Complexity 3223 3224 +1
============================================
Files 244 244
Lines 17172 17173 +1
Branches 3047 3047
============================================
+ Hits 11068 11076 +8
+ Misses 4556 4550 -6
+ Partials 1548 1547 -1
Continue to review full report at Codecov.
|
vrozov
reviewed
Dec 18, 2020
src/main/java/com/amazon/opendistroforelasticsearch/security/securityconf/ConfigModelV6.java
Outdated
Show resolved
Hide resolved
vrozov
approved these changes
Dec 18, 2020
palashhedau
approved these changes
Dec 22, 2020
hardik-k-shah
pushed a commit
that referenced
this pull request
Feb 1, 2021
* Optimize creating new collection objects in IndexResolverReplacer (#911) (cherry picked from commit 6632cd5) * Optimize by avoid creating wildcard matchers for every request (#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list (cherry picked from commit db56dc2) * Short circuit privilege evaluation for bulk requests without index resolution (#926) (cherry picked from commit d9459dd) * Try using another port 8088 for running the webhook test (#999) (cherry picked from commit 7db5afe)
hardik-k-shah
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Optimize creating new collection objects in IndexResolverReplacer (#911) (cherry picked from commit 6632cd5) * Optimize by avoid creating wildcard matchers for every request (#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list (cherry picked from commit db56dc2) * Short circuit privilege evaluation for bulk requests without index resolution (#926) (cherry picked from commit d9459dd)
hardik-k-shah
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Optimize creating new collection objects in IndexResolverReplacer (#911) (cherry picked from commit 6632cd5) * Optimize by avoid creating wildcard matchers for every request (#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list (cherry picked from commit db56dc2) * Short circuit privilege evaluation for bulk requests without index resolution (#926) (cherry picked from commit d9459dd)
hardik-k-shah
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Optimize creating new collection objects in IndexResolverReplacer (#911) (cherry picked from commit 6632cd5) * Optimize by avoid creating wildcard matchers for every request (#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list (cherry picked from commit db56dc2) * Short circuit privilege evaluation for bulk requests without index resolution (#926) (cherry picked from commit d9459dd)
hardik-k-shah
pushed a commit
that referenced
this pull request
Feb 26, 2021
* Optimize creating new collection objects in IndexResolverReplacer (#911) (cherry picked from commit 6632cd5) * Optimize by avoid creating wildcard matchers for every request (#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list (cherry picked from commit db56dc2) * Short circuit privilege evaluation for bulk requests without index resolution (#926) (cherry picked from commit d9459dd)
lbreinig
pushed a commit
to lbreinig/security
that referenced
this pull request
Dec 23, 2021
…earch-project#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…earch-project#902) * Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts * Use hash set instead of tree set as we are not taking any advantage of ordering * Convert collection to list
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opendistro-for-elasticsearch/security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.