Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using another port 8088 for running the webhook test #999

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Try using another port 8088 for running the webhook test #999

merged 1 commit into from
Jan 29, 2021

Conversation

sujithvm
Copy link
Contributor

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from master branch? (If yes, please add backport PR # and commits #)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #999 (0059159) into master (768d647) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #999      +/-   ##
============================================
- Coverage     64.51%   64.44%   -0.07%     
+ Complexity     3227     3225       -2     
============================================
  Files           244      244              
  Lines         17174    17174              
  Branches       3043     3043              
============================================
- Hits          11080    11068      -12     
- Misses         4551     4565      +14     
+ Partials       1543     1541       -2
Impacted Files Coverage Δ Complexity Δ
...ecurity/configuration/ConfigurationRepository.java 68.85% <0.00%> (-4.92%) 21.00% <0.00%> (ø%)
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) 64.00% <0.00%> (ø%)
...ecurity/ssl/DefaultOpenDistroSecurityKeyStore.java 68.87% <0.00%> (-0.23%) 70.00% <0.00%> (-1.00%)
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.25% <0.00%> (+0.76%) 23.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768d647...0059159. Read the comment docs.

hardik-k-shah
hardik-k-shah previously approved these changes Jan 28, 2021
View reviewed changes
@sujithvm sujithvm marked this pull request as ready for review January 28, 2021 23:55
@sujithvm sujithvm requested a review from a team as a code owner January 28, 2021 23:55
@sujithvm
Copy link
Contributor Author

Some other test flaked but not complaining of binding to address. Rerunning tests

@sujithvm sujithvm merged commit 7db5afe into opensearch-project:master Jan 29, 2021
@sujithvm sujithvm deleted the fix_test branch January 29, 2021 01:50
hardik-k-shah pushed a commit that referenced this pull request Feb 1, 2021
@sujithvm
Backport Opendistro 1.8 (#994)
1a688d3 
* Optimize creating new collection objects in IndexResolverReplacer (#911)

(cherry picked from commit 6632cd5)

* Optimize by avoid creating wildcard matchers for every request  (#902)

* Optimize by avoiding creating wildcard matchers for every request for constant resources users, backend roles, hosts

* Use hash set instead of tree set as we are not taking any advantage of ordering

* Convert collection to list

(cherry picked from commit db56dc2)

* Short circuit privilege evaluation for bulk requests without index resolution (#926)

(cherry picked from commit d9459dd)

* Try using another port 8088 for running the webhook test (#999)

(cherry picked from commit 7db5afe)
@cliu123 cliu123 added the maintenance Project maintenance label Feb 2, 2021
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
2d28c16 
(cherry picked from commit 7db5afe)
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
a446763 
(cherry picked from commit 7db5afe)
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
5b823fa 
(cherry picked from commit 7db5afe)
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
d1fa184 
(cherry picked from commit 7db5afe)
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
96d6d8b 
(cherry picked from commit 7db5afe)
debjanibnrj referenced this pull request in debjanibnrj/security Feb 4, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
0ea3ce0 
(cherry picked from commit 7db5afe)
hardik-k-shah pushed a commit that referenced this pull request Feb 5, 2021
@debjanibnrj @sujithvm
Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic… (
167bb72 
#1012)

* Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthenticator"

This reverts commit a629421.

* Try using another port 8088 for running the webhook test (#999)

(cherry picked from commit 7db5afe)

Co-authored-by: Sujith Vadakkepat <svadakke@amazon.com>
hardik-k-shah pushed a commit that referenced this pull request Feb 5, 2021
@debjanibnrj @sujithvm
Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic… (
cf777f3 
#1013)

* Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthenticator"

This reverts commit 59d12de.

* Try using another port 8088 for running the webhook test (#999)

(cherry picked from commit 7db5afe)

Co-authored-by: Sujith Vadakkepat <svadakke@amazon.com>
hardik-k-shah pushed a commit that referenced this pull request Feb 5, 2021
@debjanibnrj @sujithvm
Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic… (
b465309 
#1015)

* Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthenticator"

This reverts commit b487ed0.

* Try using another port 8088 for running the webhook test (#999)

(cherry picked from commit 7db5afe)

Co-authored-by: Sujith Vadakkepat <svadakke@amazon.com>
hardik-k-shah pushed a commit that referenced this pull request Feb 5, 2021
@debjanibnrj @sujithvm
Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthentic… (
b785a46 
#1016)

* Revert "Using SAML subject_key and roles_key in the HTTPSamlAuthenticator"

This reverts commit d791a48.

* Try using another port 8088 for running the webhook test (#999)

(cherry picked from commit 7db5afe)

Co-authored-by: Sujith Vadakkepat <svadakke@amazon.com>
debjanibnrj pushed a commit that referenced this pull request Feb 5, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
f26ded3 
(cherry picked from commit 7db5afe)
debjanibnrj pushed a commit that referenced this pull request Feb 5, 2021
@sujithvm @debjanibnrj
Try using another port 8088 for running the webhook test (#999)
f6a1df8 
(cherry picked from commit 7db5afe)
chrousto referenced this pull request in chrousto/security Mar 6, 2021
@sujithvm @chrousto
Try using another port 8088 for running the webhook test (#999)
188ad8f
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 17, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
9b2c1a9 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
2554de1 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
038479e 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
ceb3a81 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
b870e88 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
6708702 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
1240aa5 
(cherry picked from commit 7db5afe)
cliu123 referenced this pull request in cliu123/ODFE-Security Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
da67374 
(cherry picked from commit 7db5afe)
sujithvm added a commit that referenced this pull request Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
2832e06 
(cherry picked from commit 7db5afe)
sujithvm added a commit that referenced this pull request Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
8c5fc69 
(cherry picked from commit 7db5afe)
sujithvm added a commit that referenced this pull request Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
d8613ec 
(cherry picked from commit 7db5afe)
sujithvm added a commit that referenced this pull request Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
e55d814 
(cherry picked from commit 7db5afe)
vrozov pushed a commit that referenced this pull request Mar 18, 2021
@sujithvm @vrozov
Try using another port 8088 for running the webhook test (#999)
271de47 
(cherry picked from commit 7db5afe)
sujithvm added a commit that referenced this pull request Mar 18, 2021
@sujithvm
Try using another port 8088 for running the webhook test (#999)
5cc6f5f 
(cherry picked from commit 7db5afe)
vrozov pushed a commit that referenced this pull request Mar 18, 2021
@sujithvm @vrozov
Try using another port 8088 for running the webhook test (#999)
c2aeb24 
(cherry picked from commit 7db5afe)
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
@sujithvm
Try using another port 8088 for running the webhook test (opensearch-…
bfccd82 
…project#999)
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
@sujithvm
Try using another port 8088 for running the webhook test (opensearch-…
1328a6a 
…project#999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debjanibnrj debjanibnrj debjanibnrj approved these changes

@hardik-k-shah hardik-k-shah hardik-k-shah approved these changes

Assignees
No one assigned
Labels
maintenance Project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sujithvm @hardik-k-shah @debjanibnrj @cliu123