Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opendistro-1.0][backport] Add validation for null elements in JSON array (#1157) #1348

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

afazel
Copy link
Contributor

@afazel afazel commented Jul 27, 2021

(cherry picked from commit 960d420)

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@afazel afazel requested a review from a team July 27, 2021 23:12
@codecov-commenter
Copy link

Codecov Report

Merging #1348 (3d946f1) into opendistro-1.0 (6d3de54) will increase coverage by 0.26%.
The diff coverage is 78.03%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             opendistro-1.0    #1348      +/-   ##
====================================================
+ Coverage             62.33%   62.60%   +0.26%     
- Complexity             2869     2897      +28     
====================================================
  Files                   221      223       +2     
  Lines                 15843    15918      +75     
  Branches               2974     2987      +13     
====================================================
+ Hits                   9876     9965      +89     
+ Misses                 4431     4403      -28     
- Partials               1536     1550      +14     
Impacted Files Coverage Δ
...arch/security/ssl/OpenDistroSecuritySSLPlugin.java 82.46% <0.00%> (ø)
...ort/OpenDistroSecuritySSLTransportInterceptor.java 0.00% <0.00%> (ø)
...lasticsearch/security/support/ConfigConstants.java 85.71% <ø> (ø)
...arch/security/dlic/rest/api/AbstractApiAction.java 76.21% <60.00%> (+1.32%) ⬆️
...rch/security/setting/OpenDistroDynamicSetting.java 60.00% <60.00%> (ø)
...ticsearch/security/configuration/CompatConfig.java 38.23% <66.66%> (+10.64%) ⬆️
...ecurity/configuration/ConfigurationRepository.java 74.23% <79.59%> (+4.90%) ⬆️
.../security/setting/TransportPassiveAuthSetting.java 80.00% <80.00%> (ø)
...transport/OpenDistroSecuritySSLRequestHandler.java 59.45% <83.33%> (-3.78%) ⬇️
...ty/transport/OpenDistroSecurityRequestHandler.java 68.14% <83.33%> (+1.21%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd29392...3d946f1. Read the comment docs.

@vrozov vrozov merged commit a7fa9a4 into opensearch-project:opendistro-1.0 Jul 28, 2021
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
* Update developer guide

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Small update

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Use lower case x

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update 1.x to 1.3

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants