Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for null array DataType #1157

Merged
merged 14 commits into from
Jul 26, 2021
Merged

Conversation

afazel
Copy link
Contributor

@afazel afazel commented May 3, 2021

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Bug fix

  2. Github Issue # or road-map entry, if available:
    disallow using null in users list #1136

  3. Description of changes:
    Add validation for all the API keys that have ARRAY DataType to make sure that there is no null value in the array.

  4. Why these changes are required?
    By adding this validation, we prevent ES being completely unoperational when there are null in the arrays.

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
    It was possible to bring ES completely unoperational by using null in the array DataTypes in several APIs.

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    Unit test added to cover array DataType like users with null in their list.

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@afazel
Copy link
Contributor Author

afazel commented May 6, 2021

The failure in the unit tests was related to the bug in my code, I fixed the bug in my last commit and now all the tests passed.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #1157 (eb25905) into main (dc34c54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1157   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
- Complexity     3195     3203    +8     
=========================================
  Files           247      247           
  Lines         17232    17252   +20     
  Branches       3046     3053    +7     
=========================================
+ Hits          11156    11170   +14     
- Misses         4526     4531    +5     
- Partials       1550     1551    +1     
Impacted Files Coverage Δ
...est/validation/AbstractConfigurationValidator.java 83.89% <100.00%> (+2.49%) ⬆️
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️
...security/configuration/DlsFlsFilterLeafReader.java 60.47% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc34c54...eb25905. Read the comment docs.

@afazel afazel force-pushed the azar-test branch 2 times, most recently from 9e8ed2b to 81a5eea Compare May 10, 2021 19:49
@afazel afazel requested a review from a team June 18, 2021 20:11
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 27, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
vrozov pushed a commit that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
afazel added a commit to afazel/security that referenced this pull request Jul 28, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
vrozov pushed a commit that referenced this pull request Jul 29, 2021
AMoo-Miki pushed a commit to AMoo-Miki/security that referenced this pull request Aug 13, 2021
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants