Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opendistro-1.12][backport] Add validation for null elements in JSON array (#1157) #1360

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

afazel
Copy link
Contributor

@afazel afazel commented Jul 28, 2021

(cherry picked from commit 960d420)

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  4. Why these changes are required?

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@afazel afazel requested a review from a team July 28, 2021 18:35
@codecov-commenter
Copy link

Codecov Report

Merging #1360 (a9bda6f) into opendistro-1.12 (1d2857e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             opendistro-1.12    #1360      +/-   ##
=====================================================
+ Coverage              64.63%   64.65%   +0.01%     
- Complexity              3217     3226       +9     
=====================================================
  Files                    246      246              
  Lines                  17200    17220      +20     
  Branches                3048     3055       +7     
=====================================================
+ Hits                   11118    11134      +16     
- Misses                  4538     4541       +3     
- Partials                1544     1545       +1     
Impacted Files Coverage Δ
...est/validation/AbstractConfigurationValidator.java 83.89% <100.00%> (+2.49%) ⬆️
...security/configuration/DlsFlsFilterLeafReader.java 59.76% <0.00%> (-0.71%) ⬇️
...search/security/tools/OpenDistroSecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.25% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2857e...a9bda6f. Read the comment docs.

@vrozov vrozov merged commit 8fbdbf6 into opensearch-project:opendistro-1.12 Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants