Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce heap size usage during unit tests #1368

Closed
wants to merge 2 commits into from
Closed

Reduce heap size usage during unit tests #1368

wants to merge 2 commits into from

Conversation

vrozov
Copy link
Contributor

@vrozov vrozov commented Aug 2, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:
    Change fork heap size and use unpooled netty byte buffer allocator

  4. Why these changes are required?
    Lower heap usage during CI to free up more memory for direct buffers

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vrozov vrozov added the maintenance Project maintenance label Aug 2, 2021
@vrozov vrozov requested a review from a team August 2, 2021 20:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #1368 (2b535f7) into main (960d420) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1368      +/-   ##
============================================
- Coverage     64.78%   64.77%   -0.01%     
+ Complexity     3204     3203       -1     
============================================
  Files           247      247              
  Lines         17252    17252              
  Branches       3053     3053              
============================================
- Hits          11176    11175       -1     
  Misses         4526     4526              
- Partials       1550     1551       +1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.26% <0.00%> (-0.27%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.25% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960d420...2b535f7. Read the comment docs.

hardik-k-shah
hardik-k-shah previously approved these changes Aug 3, 2021
@davidlago
Copy link

Continuing in #1610

@davidlago davidlago closed this Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants