Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce heap size usage during unit tests #1610

Closed
wants to merge 1 commit into from

Conversation

davidlago
Copy link

@davidlago davidlago commented Feb 13, 2022

Signed-off-by: Dave Lago davelago@amazon.com

Coming from #1368, fixing merge conflicts here to save @vrozov the trouble.

Category:

Maintenance

Description of changes:

Change fork heap size and use unpooled netty byte buffer allocator

Why these changes are required?

Lower heap usage during CI to free up more memory for direct buffers

Check List

  • N/A New functionality includes testing
  • N/A New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dave Lago <davelago@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1610 (45eaf84) into main (7ebb2ca) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1610      +/-   ##
============================================
+ Coverage     64.64%   64.70%   +0.06%     
- Complexity     3218     3219       +1     
============================================
  Files           247      247              
  Lines         17351    17351              
  Branches       3082     3082              
============================================
+ Hits          11216    11227      +11     
+ Misses         4585     4574      -11     
  Partials       1550     1550              
Impacted Files Coverage Δ
.../dlic/auth/http/jwt/keybyoidc/KeySetRetriever.java 79.26% <0.00%> (+2.43%) ⬆️
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 68.30% <0.00%> (+4.92%) ⬆️
...t/keybyoidc/AuthenticatorUnavailableException.java 40.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebb2ca...45eaf84. Read the comment docs.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got that gradle PR incoming, do we want to merge this if we are switching build/test systems shortly?

@davidlago
Copy link
Author

davidlago commented Feb 15, 2022

You are 100% correct... at this point it seems close to merging, so let's close this one then. #1592

@davidlago davidlago closed this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants