-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build system to gradle #1592
Migrate build system to gradle #1592
Conversation
1d78eee
to
b774290
Compare
01e4783
to
d8ce201
Compare
Linking #1505 as this PR also moves to Gradle 7 |
4e94fad
to
b635789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@rs-eliatra please address the merge conflicts and the questions in the PR and we are good to go. Thanks for the help! |
37c7ba6
37c7ba6
to
7314442
Compare
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
…ndencies Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
…ndencies fix Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
…ndError Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
cd3720b
to
891c2a5
Compare
@rs-eliatra I've retriggered the CI, it looks like there is a CVE on one of the dependencies
Suggested fix
|
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
4d7b453
to
9eed836
Compare
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
@rs-eliatra guava 0.29 is still being brought in transiently: |
Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Code Coverage report seems to have not been printed...we should look into it |
Conversion to Gradle Signed-off-by: rs-eliatra <rafal.stobiecki@eliatra.com>
Description
[Describe what this change achieves]
1. Category
Maintenance
2. Github Issue
#1121
3. Description of changes
4. Why these changes are required?
OpenSearch use Gradle to build and package OpenSearch, and also to orchestrate tests and another tasks.
Currently there is a mix inside OpenSearch Security Plugin:
5. What is the old behavior before changes and new behavior after changes?
Testing
./gradlew test
./gradlew clean build testsJar --no-daemon -Dbuild.snapshot=false -x test
The artifacts generated in build:
* opensearch-security-1.3.0.0.jar
* opensearch-security-1.3.0.0.jar
The artifacts generated in build/distributions:
* opensearch-security-1.3.0.0.zip
* opensearch-security-1.3.0.0.zip.sha512
* opensearch-security-1.3.1.0-securityadmin-standalone.tar.gz
* opensearch-security-1.3.1.0-securityadmin-standalone.zip
Installed security plugin generated by Gradle on OpenSearch.
The artifacts generated by gradle were compared with artifacts generated by Maven
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.