Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failed login attempt for saml authenticator #4762

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Sep 30, 2024

Description

Removes audit log entry of failed login for all SAML authentication since it will always re-request authentication

Issues Resolved

Fix: #4608
Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No

Testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@cwperks cwperks added the backport 2.x backport to 2.x branch label Oct 1, 2024
@cwperks
Copy link
Member

cwperks commented Oct 1, 2024

@derek-ho Can you rebase with the latest from main?

@derek-ho
Copy link
Collaborator Author

derek-ho commented Oct 1, 2024

@derek-ho Can you rebase with the latest from main?

Done

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.61%. Comparing base (3ad09c8) to head (49e0da4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 0.00% 1 Missing ⚠️
.../org/opensearch/security/auth/BackendRegistry.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4762   +/-   ##
=======================================
  Coverage   65.60%   65.61%           
=======================================
  Files         321      321           
  Lines       22539    22540    +1     
  Branches     3611     3612    +1     
=======================================
+ Hits        14787    14789    +2     
+ Misses       5939     5938    -1     
  Partials     1813     1813           
Files with missing lines Coverage Δ
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 67.51% <0.00%> (ø)
.../org/opensearch/security/auth/BackendRegistry.java 62.38% <50.00%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

@cwperks cwperks merged commit 39adb47 into opensearch-project:main Oct 3, 2024
40 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 39adb47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwperks cwperks added the v2.18.0 Issues targeting release v2.18.0 label Oct 3, 2024
terryquigleysas pushed a commit to terryquigleysas/security that referenced this pull request Oct 3, 2024
…t#4762)

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.18.0 Issues targeting release v2.18.0
Projects
None yet
5 participants