-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove failed login attempt for saml authenticator #4762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
September 30, 2024 20:54
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
approved these changes
Oct 1, 2024
willyborankin
approved these changes
Oct 1, 2024
@derek-ho Can you rebase with the latest from main? |
RyanL1997
approved these changes
Oct 1, 2024
Done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4762 +/- ##
=======================================
Coverage 65.60% 65.61%
=======================================
Files 321 321
Lines 22539 22540 +1
Branches 3611 3612 +1
=======================================
+ Hits 14787 14789 +2
+ Misses 5939 5938 -1
Partials 1813 1813
|
nibix
reviewed
Oct 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 39adb47) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
terryquigleysas
pushed a commit
to terryquigleysas/security
that referenced
this pull request
Oct 3, 2024
…t#4762) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Terry Quigley <terry.quigley@sas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes audit log entry of failed login for all SAML authentication since it will always re-request authentication
Issues Resolved
Fix: #4608
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.