Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove failed login attempt for saml authenticator #4770

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 39adb47 from #4762.

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit 39adb47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (777fb59) to head (508fa1a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 0.00% 1 Missing ⚠️
.../org/opensearch/security/auth/BackendRegistry.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4770      +/-   ##
==========================================
+ Coverage   65.44%   65.45%   +0.01%     
==========================================
  Files         319      319              
  Lines       22250    22251       +1     
  Branches     3591     3592       +1     
==========================================
+ Hits        14561    14564       +3     
+ Misses       5888     5885       -3     
- Partials     1801     1802       +1     
Files with missing lines Coverage Δ
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 67.51% <0.00%> (ø)
.../org/opensearch/security/auth/BackendRegistry.java 60.81% <50.00%> (-0.20%) ⬇️

... and 5 files with indirect coverage changes

@cwperks cwperks merged commit 3d7d716 into 2.x Oct 3, 2024
90 of 91 checks passed
@cwperks cwperks deleted the backport/backport-4762-to-2.x branch October 3, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant