Boolean function in PPL should be case insensitive (#2758)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
opensearch-project · Jul 18, 2024 · 956ec15 · 956ec15
1 parent 607354c
commit 956ec15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ppl/src/main/java/org/opensearch/sql/ppl/parser/AstExpressionBuilder.java b/ppl/src/main/java/org/opensearch/sql/ppl/parser/AstExpressionBuilder.java
@@ -187,7 +187,7 @@ public UnresolvedExpression visitTakeAggFunctionCall(
   /** Eval function. */
   @Override
   public UnresolvedExpression visitBooleanFunctionCall(BooleanFunctionCallContext ctx) {
-    final String functionName = ctx.conditionFunctionBase().getText();
+    final String functionName = ctx.conditionFunctionBase().getText().toLowerCase();
     return buildFunction(
         FUNCTION_NAME_MAPPING.getOrDefault(functionName, functionName),
         ctx.functionArgs().functionArg());

diff --git a/ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java b/ppl/src/test/java/org/opensearch/sql/ppl/parser/AstExpressionBuilderTest.java
@@ -107,12 +107,15 @@ public void testLogicalLikeExpr() {
   @Test
   public void testBooleanIsNullFunction() {
     assertEqual("source=t isnull(a)", filter(relation("t"), function("is null", field("a"))));
+    assertEqual("source=t ISNULL(a)", filter(relation("t"), function("is null", field("a"))));
   }
 
   @Test
   public void testBooleanIsNotNullFunction() {
     assertEqual(
         "source=t isnotnull(a)", filter(relation("t"), function("is not null", field("a"))));
+    assertEqual(
+        "source=t ISNOTNULL(a)", filter(relation("t"), function("is not null", field("a"))));
   }
 
   /** Todo. search operator should not include functionCall, need to change antlr. */