Boolean function in PPL should be case insensitive #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
vamsi-amazon
approved these changes
Jun 24, 2024
|
Thanks for your reviewing @penghuo @dai-chen @vamsi-amazon , will this PR be merged automatically? And backport PR will be triggered automatically either? Any action should I do next? |
|
@LantaoJin Could you confirm if the build issues are not because of your commit. I will merge all the approved PRs. |
None of current build issues caused by this code changes. |
dai-chen
approved these changes
Jul 15, 2024
|
could u merge latest change from main and re-run test. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 956ec15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Aug 7, 2024
(cherry picked from commit 956ec15) Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
to manasvinibs/sql
that referenced
this pull request
Aug 14, 2024
…t#2758) Signed-off-by: Lantao Jin <ltjin@amazon.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
…t#2758) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isnotnull()works butISNOTNULL()doesn't work in PPL.Issues Resolved
Resolve #2431
Check List
[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] New functionality has user manual doc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.