Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringIndexOutOfBoundsException for LEFT() and RIGHT()[BUG] #266

Closed
ghost opened this issue Nov 5, 2021 · 2 comments · Fixed by #285
Closed

StringIndexOutOfBoundsException for LEFT() and RIGHT()[BUG] #266

ghost opened this issue Nov 5, 2021 · 2 comments · Fixed by #285
Labels
bug Something isn't working SQL tdvt Tableau test framework

Comments

@ghost
Copy link

ghost commented Nov 5, 2021

Describe the bug
StringIndexOutOfBoundsException is thrown when the second of argument of LEFT and RIGHT functions is greater than the length of the first argument.

Or for query issues:

  1. Run the query 'SELECT LEFT("Hello", 6)'
  2. See error 'StringIndexOutOfBoundsException'

Expected behavior
The output should be the whole string when the second argument is greater than or equal to the length of the string.

Screenshots
image
@ghost ghost added Beta bug Something isn't working untriaged labels Nov 5, 2021
@Yury-Fridlyand Yury-Fridlyand mentioned this issue Nov 10, 2021
Open
chloe-zh added a commit to chloe-zh/opensearch-sql that referenced this issue Nov 13, 2021
@chloe-zh
fixed opensearch-project#266
0cf5c8a 
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh mentioned this issue Nov 13, 2021
Merged
6 tasks
@chloe-zh
Copy link
Contributor

Code changes for this fix: #285

@chloe-zh chloe-zh linked a pull request Nov 13, 2021 that will close this issue
Fixed StringIndexOutOfBoundsException issue of left and right text functions #285
Merged
6 tasks
@ghost
Copy link
Author

ghost commented Nov 19, 2021

This issue affects TDVT tests:

  • exprtests/standard\setup.string.left.real.txt
  • exprtests/standard\setup.string.left.txt
  • exprtests/standard\setup.string.right.real.txt
  • exprtests/standard\setup.string.endswith.txt
  • exprtests/standard\setup.string.startswith.txt

@joshuali925 joshuali925 added the tdvt Tableau test framework label Nov 24, 2021
acarbonetto added a commit that referenced this issue May 30, 2023
@matthewryanwells @acarbonetto
Create new anonymizer for new engine (#1665)
62120fd 
* Create new anonymizer for new engine (#266)

* Created anonymizer listener for anonymizing SQL queries through the new engine
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* added missing file header, change public variable to private

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 30, 2023
@matthewryanwells @github-actions
Create new anonymizer for new engine (#1665)
dc61a0b 
* Create new anonymizer for new engine (#266)

* Created anonymizer listener for anonymizing SQL queries through the new engine
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* added missing file header, change public variable to private

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 62120fd)
opensearch-trigger-bot bot pushed a commit that referenced this issue May 30, 2023
@matthewryanwells @github-actions
Create new anonymizer for new engine (#1665)
6bd998d 
* Create new anonymizer for new engine (#266)

* Created anonymizer listener for anonymizing SQL queries through the new engine
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* added missing file header, change public variable to private

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 62120fd)
Yury-Fridlyand pushed a commit that referenced this issue May 30, 2023
@opensearch-trigger-bot @matthewryanwells
Create new anonymizer for new engine (#1665) (#1677)
dca8359 
* Create new anonymizer for new engine (#266)

* Created anonymizer listener for anonymizing SQL queries through the new engine
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* added missing file header, change public variable to private

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 62120fd)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
acarbonetto pushed a commit that referenced this issue May 30, 2023
@opensearch-trigger-bot @matthewryanwells
Create new anonymizer for new engine (#1665) (#1678)
5d0cb13 
* Create new anonymizer for new engine (#266)

* Created anonymizer listener for anonymizing SQL queries through the new engine
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Update for review comments

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* added missing file header, change public variable to private

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 62120fd)

Co-authored-by: Matthew Wells <matthew.wells@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working SQL tdvt Tableau test framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed StringIndexOutOfBoundsException issue of left and right text functions chloe-zh/opensearch-sql
2 participants
@joshuali925 @chloe-zh