Fixed StringIndexOutOfBoundsException issue of left and right text functions #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=========================================
Coverage 99.90% 99.90%
- Complexity 2687 2688 +1
=========================================
Files 256 256
Lines 6524 6529 +5
Branches 420 420
=========================================
+ Hits 6518 6523 +5
Misses 5 5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
joshuali925
approved these changes
Nov 17, 2021
vamsi-amazon
added a commit
that referenced
this pull request
Mar 9, 2022
* Add sql integTest script for opensearch Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Refactor readme (#148) Signed-off-by: Chen Dai <daichen@amazon.com> * Build against OpenSearch 1.0.0 and bump artifact version to 1.0.0.0 (#146) * Bump OpenSearch version from rc1 to 1.0.0 Signed-off-by: Chen Dai <daichen@amazon.com> * Rename JDBC artifact by removing -rc1 Signed-off-by: Chen Dai <daichen@amazon.com> * Remove rc1 qualifier in build workflow Signed-off-by: Chen Dai <daichen@amazon.com> * Remove rc1 from build tools version Signed-off-by: Chen Dai <daichen@amazon.com> * Fix IT failure Signed-off-by: Chen Dai <daichen@amazon.com> * Rollback build tools to rc1 due to known issue Signed-off-by: Chen Dai <daichen@amazon.com> * Bump CLI version Signed-off-by: Chen Dai <daichen@amazon.com> * Bump query workbench version Signed-off-by: Chen Dai <daichen@amazon.com> * Build against 1.0.0 Signed-off-by: Chen Dai <daichen@amazon.com> * Update release notes drafter Signed-off-by: Chen Dai <daichen@amazon.com> * Update nodejs to 10.24.1 Signed-off-by: Chen Dai <daichen@amazon.com> * Change grammar and add UT (#150) Signed-off-by: Chen Dai <daichen@amazon.com> * Add release notes for OpenSearch GA (#151) * Add release notes Signed-off-by: Chen Dai <daichen@amazon.com> * Change release date Signed-off-by: Chen Dai <daichen@amazon.com> * Add bug fixes section Signed-off-by: Chen Dai <daichen@amazon.com> * Add sql dashboards tests for workbench Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * [1] Fixed aws init and shutdown behaviour (#163) * Support implicit type conversion from string to boolean (#166) * Support implicit type conversion for bool and string Signed-off-by: Chen Dai <daichen@amazon.com> * Fix lucene query pushdown issue Signed-off-by: Chen Dai <daichen@amazon.com> * Refactor lucene query methods Signed-off-by: Chen Dai <daichen@amazon.com> * Refactor builtin repo methods Signed-off-by: Chen Dai <daichen@amazon.com> * Add comparison test Signed-off-by: Chen Dai <daichen@amazon.com> * Fix comparison test Signed-off-by: Chen Dai <daichen@amazon.com> * Add doc test for user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Fix doc test Signed-off-by: Chen Dai <daichen@amazon.com> * Fix design doc link Signed-off-by: Chen Dai <daichen@amazon.com> * Fix RST render issue Signed-off-by: Chen Dai <daichen@amazon.com> * Fix cast function pushdown issue Signed-off-by: Chen Dai <daichen@amazon.com> * Improve javadoc for PR Signed-off-by: Chen Dai <daichen@amazon.com> * Upload design doc Signed-off-by: Chen Dai <daichen@amazon.com> * Add more user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Add more user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Fix doctest Signed-off-by: Chen Dai <daichen@amazon.com> * Support distinct count aggregation (#167) * Support construct AggregationResponseParser during Aggregator build stage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <penghuo@gmail.com> * support distinct count aggregation Signed-off-by: chloe-zh <chloezh1102@gmail.com> * fixed tests Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Merge remote-tracking branch 'upstream/develop' into issue/#100 Signed-off-by: chloe-zh <chloezh1102@gmail.com> # Conflicts: # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * updated user doc Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Update: support only count for distinct aggregations Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Update doc; removed distinct start Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Removed unnecessary methods Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Impl stddev and variance function in SQL and PPL (#115) * impl variance frontend and backend * Support construct AggregationResponseParser during Aggregator build stage * add var and varp for PPL Signed-off-by: penghuo <penghuo@gmail.com> * add UT Signed-off-by: penghuo <penghuo@gmail.com> * fix UT Signed-off-by: penghuo <penghuo@gmail.com> * fix doc format Signed-off-by: penghuo <penghuo@gmail.com> * fix doc format Signed-off-by: penghuo <penghuo@gmail.com> * fix the doc Signed-off-by: penghuo <penghuo@gmail.com> * add stddev_samp and stddev_pop Signed-off-by: penghuo <penghuo@gmail.com> * fix UT coverage * address comments Signed-off-by: penghuo <penghuo@gmail.com> * Fix the aggregation filter missing in named aggregators (#123) * Take the condition expression as property to the named aggregator when wrapping the delegated aggregator Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Added test case where filtered agg is not pushed down Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * modified comparison test Signed-off-by: chloe-zh <chloezh1102@gmail.com> * removed a comparison test and added it to aggregationIT Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added ppl IT test cases; added window function test cases Signed-off-by: chloe-zh <chloezh1102@gmail.com> * moved distinct window function test cases to WindowsIT Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added ut Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * addressed comments Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added test cases to meet the coverage requirement Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added test cases for distinct count map and array types Signed-off-by: chloe-zh <chloezh1102@gmail.com> Co-authored-by: Peng Huo <penghuo@gmail.com> * Support implicit type conversion from string to temporal (#171) * Support implicit cast from string to temporal types Signed-off-by: Chen Dai <daichen@amazon.com> * Add comparison test Signed-off-by: Chen Dai <daichen@amazon.com> * Add doctest Signed-off-by: Chen Dai <daichen@amazon.com> * Fix doctest Signed-off-by: Chen Dai <daichen@amazon.com> * Add more user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Add more user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Fix doctest Signed-off-by: Chen Dai <daichen@amazon.com> * Update user manual Signed-off-by: Chen Dai <daichen@amazon.com> * Use externally-defined OpenSearch version when specified. Signed-off-by: dblock <dblock@amazon.com> * Use OpenSearch 1.1 and build snapshot by default. (#181) Signed-off-by: dblock <dblock@amazon.com> * Bump path-parse from 1.0.6 to 1.0.7 in /workbench (#178) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Workbench: auto dump cypress test data, support security (#199) * Workbench: remove curl commands in integtest.sh (#200) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix import path for cypress constant (#201) * Bump version to 1.1 for Opensearch 1.1.0.0 release (#202) * bump workbench versions to 1.1 Signed-off-by: David Cui <davidcui@amazon.com> * bump version to 1.1.0.0 for 1.1 release Signed-off-by: David Cui <davidcui@amazon.com> * add release notes for 1.1 Signed-off-by: David Cui <davidcui@amazon.com> * bump odbc files to 1.1.0.0 Signed-off-by: David Cui <davidcui@amazon.com> * Bump opensearch ref to 1.1 in CI (#205) * Fix PPL request concurrency handling issue (#207) * Downscope request to local method Signed-off-by: Chen Dai <daichen@amazon.com> * Fix checkstyle Signed-off-by: Chen Dai <daichen@amazon.com> * Removed integtest.sh. (#208) Signed-off-by: dblock <dblock@dblock.org> * Support match function as filter in SQL and PPL (#204) * supported match in sql and ppl where Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added legacy syntax in new parser Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added integration test Signed-off-by: chloe-zh <chloezh1102@gmail.com> * updated user manual Signed-off-by: chloe-zh <chloezh1102@gmail.com> * updated user manual Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added ppl integ test, updated ppl manual Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Changed the ODBC mac installer build platform to MacOS 10.15 from latest (#230) Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Renamed plugin helper config file to consistent name with OSD (#228) * Update build to use public Maven repo (#225) * Update build to use public Maven repo Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com> * Update runner to use macos-11 for odbc builds Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com> * Address security vulnerability CVE-2021-3795 (#231) Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Addressed security vulnerability CVE-2021-3807 (#233) * Support ODBC compatibility with ODFE SQL (#238) * compatible with opensearch and all versions in odfe with sql plugin Signed-off-by: chloe-zh <chloezh1102@gmail.com> * address comments Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Support span aggregation in query engine (#220) * Added span in ppl; push down only Signed-off-by: chloe-zh <chloezh1102@gmail.com> * refined span return type Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added unit test cases for span aggregation builder and parser Signed-off-by: chloe-zh <chloezh1102@gmail.com> * implemented in memory execution of span aggregation Signed-off-by: chloe-zh <chloezh1102@gmail.com> * checkstyle Signed-off-by: chloe-zh <chloezh1102@gmail.com> * enabled alias Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added integration test Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added unit test cases for span aggregation builder and parser Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Updated PPL user manual Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Enable DCO Workflow Check (#242) * enable dco check Signed-off-by: chloe-zh <chloezh1102@gmail.com> * updated contribution doc Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Bump version to 1.1.0.1 for patch release (#253) * Bump version to 1.1.0.1 for patch release Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Removed redundant line Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Add new protocol for visualization response format (#251) * added viz protocol, added tests and updated user manual Signed-off-by: chloe-zh <chloezh1102@gmail.com> * changed version back to 1.1 Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Bumps version to 1.2 (#254) * Updates dashbquery-workbench-dashboardsoards version to 1.2. Changes the package jsons, as well as the github action workflows. Signed-off-by: Tengda He <tengh@amazon.com> * bump version to 1.2 changes Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * fix broken link Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Remove unnecessary stubs Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * 1.2 release notes Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * 1.2 release notes Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Update notice files (#269) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add support for datetime type conversion in JDBC Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Optimized type converting in DSL filters (#272) * optimized cast in filter queries Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * added unit tests Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Update license headers for /**/ style files Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix and add more license headers Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add gradlew Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove amazon license in # and /**/ comment style files Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove amazon license in other files Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove for one more file Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add some missing licenses Signed-off-by: Joshua Li <joshuali925@gmail.com> * Updated PPL user manual with relevance function limitations (#283) * update user manual on relevanc function limitations Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Update release notes for 1.2 release (#289) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Added Tableau Connector to OpenSearch SQL (#290) Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed result parsing error for boolean type (#284) Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Fixed StringIndexOutOfBoundsException issue of left and right text functions (#285) Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Add support for codeowners to repo (#286) Signed-off-by: Ryan Bogan <rbogan@amazon.com> * use opensearch-py client (#306) * use opensearch-py client Signed-off-by: Zhongnan Su <szhongna@amazon.com> * reformat code Signed-off-by: Zhongnan Su <szhongna@amazon.com> * fix doctest Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Fix query string handling for workbench (#305) * fix line break handling for ppl Signed-off-by: Joshua Li <joshuali925@gmail.com> * escape quotes in query requests Signed-off-by: Joshua Li <joshuali925@gmail.com> * [sql-cli] wrap error response into exception (#309) Signed-off-by: Zhongnan Su <szhongna@amazon.com> * added new badges, fixed links Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * added codecov for workbench Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated codecov flags Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * renamed workbench flag Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated IT link Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated header name Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated workbench header Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated link checker Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Fixed issue #291 and updated the dialect for Tableau Connector (#296) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> * Type conversion (#318) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> * Updated pbi connector (#320) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Remove changes from irrelevant commits Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Remove changes from irrelevant commits Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated the mez file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> * Add integTestRemote for sql (#327) * Add integTestRemote for sql Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove unused comment Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bump log4j to 2.15 and bump plugin to 1.2.1 (#324) * Fix merge conflicts Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update release notes Signed-off-by: Joshua Li <joshuali925@gmail.com> * Revert version bump for workbench Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update headers (#323) * Update headers Signed-off-by: Lyndon Bauto <lyndonb@bitquilltech.com> * [1] Updating installer Signed-off-by: Lyndon Bauto <lyndonb@bitquilltech.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * Add backwards compatibility tests for SQL (#322) * Add bwc tests setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * update setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use only 1 cluster Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use 2 clusters Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add 1.2 snapshot Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix test setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add sql bwc tests for queries and cluster settings Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add bwc test script and remove latest artifact Signed-off-by: Joshua Li <joshuali925@gmail.com> * Format code Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix indentation Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add bwc tests to CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bump bwc to 1.2.1-SNAPSHOT Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bump log4j to 2.16 and plugin to 1.2.2 (#338) * Bump log4j to 2.16 and plugin to 1.2.2 Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add release notes Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bump bwc to 1.2.2-SNAPSHOT Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use opensearch_version for bwc Signed-off-by: Joshua Li <joshuali925@gmail.com> * added untriaged and nolabel badges Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * backporting log4j to main Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Bump sql main to 1.3.0 (#351) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update docs links for workbench (#352) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Upgrade to log4j 2.17.1. (#354) Signed-off-by: dblock <dblock@amazon.com> * Driver timestamp (#333) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> * Add .whitesource configuration file * Add TDVT test report for the Tableau JDBC connector (#355) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added TDVT test result and a readme file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: guiangumpac <90278068+guiangumpac@users.noreply.github.com> * PowerBI certification changes (#349) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Support date_nanos OpenSearch field type (#360) * Convert date_nanos to timestamp Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use nano seconds precision for timestamp Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update unit tests Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update docs for date_nanos Signed-off-by: Joshua Li <joshuali925@gmail.com> * Bump gson and json-schema (#370) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update release notes 1.2.4 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * added maintenance section Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Remove jcenter in sql and jdbc (#378) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Connector limitation documentation (#366) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added link to bug Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed unused images Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Address msft feedback (#380) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added IFNULL function Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added comment to TimestampType Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed changes from a different branch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix requested by PR review Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed connector changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Change values to bitmasks Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Reverted some previous changes Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed generated test output file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A typo fix in yml Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Path fix for preparation step Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Renamed output artifact Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed extra line Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow step description Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added link to bug Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Modified the connector and workflows to address Power BI certification feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed m filename to AmazonOpenSearchService-ODBC Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made further changes to address PBI feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fixed github workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Modified output filenames of connector workflow Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Fix workflow Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Typo fix in the fix Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> * Changed function prefixes to match connector name Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Changed DSR Handler Friendly name for Amazon OpenSearch Service connector as requested by the PBI feedback Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed -ODBC suffix as per code review comments Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Made workflow more concise and changed a variable name Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> * Removed irrelevant images Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> Co-authored-by: Kyle Porter <kylep@bitquilltech.com> * Update the README file and and a link to the iODBC (#365) - add a link to the iODBC Driver Manager so it is easier to navigate and install the driver manger Signed-off-by: Alina (Xi) Li <alinalbitquilltech.com> * [SQL-CLI] set version number to 1.0.0 (#381) * Set release version number to 1.0.0 Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Rewrite span as composite aggregation. (#386) 1.rewrite span as composite aggregation instead of DateHistogram or Histogram aggregation. 2.fix issue #385. Signed-off-by: penghuo <penghuo@gmail.com> * Rename `opensearch-sql-cli` to `opensearch-sqlcli` to unblock release (#388) * rename the package to opensearch-sqlcli Signed-off-by: Zhongnan Su <szhongna@amazon.com> * update guava package to 31.0.1-jre (#390) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * rename package name of sql-cli from `opensearch-sqlcli` to `opensearchsql` (#392) * rename sql-cli to opensearchsql Signed-off-by: Zhongnan Su <szhongna@amazon.com> * update workflow Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Parse none type field as null instead of throw exception (#406) Signed-off-by: penghuo <penghuo@gmail.com> * Add how to setup aws credentials for ODBC Tableau (#394) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Jackson-databind bump to 2.12.6 (#410) * bumping jackson-databind to 2.12.6 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * bumping jackson-core & dataformat-cbor Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated missed gradle files Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated junit & added resolutions Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Bug Fix, disable html escape when formatting response (#412) Signed-off-by: penghuo <penghuo@gmail.com> * Support multiple indices in PPL and SQL (#408) Signed-off-by: penghuo <penghuo@gmail.com> * Revert to windows 2019 for odbc CI (#413) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Support combination of group field and span in stats command (#417) * Support combination of group field and span in stats command Signed-off-by: penghuo <penghuo@gmail.com> * Support In clause in SQL and PPL (#420) Signed-off-by: penghuo <penghuo@gmail.com> * Add cast function to PPL (#433) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Version bump to 1.3 (#419) Signed-off-by: Eugene Lee <eugenesk@amazon.com> * Span expression should always be first in by list if exist (#437) Signed-off-by: penghuo <penghuo@gmail.com> * Add auto backport functionality for SQL (#445) Add auto backport workflow and documentation. Signed-off-by: David Cui <davidcui@amazon.com> * Update backport and add auto-delete workflows (#446) * update backport workflow and add auto delete Signed-off-by: David Cui <davidcui@amazon.com> * Version Bump: springframework and jackson (#443) Signed-off-by: penghuo <penghuo@gmail.com> * Version Bump: H2 1.x -> 2.x (#444) Signed-off-by: penghuo <penghuo@gmail.com> * Add CI Matrix for JDK 11 and 14 (#451) Add default version as JDK 11 and add CI matrix for JDK 11 and 14 Signed-off-by: David Cui <davidcui@amazon.com> * Add Certificate Validation option (#449) Signed-off-by: Guian Gumpac <guiang@bitquilltech.com> Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury Fridlyand <yuryf@bitquilltech.com> Co-authored-by: Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com> * Treating ExpressionEvaluationException as client Error (#459) Fixed https://github.com/opensearch-project/sql/issues/423. * Add parse command to PPL (#411) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add limitation section in PPL docs (#456) Signed-off-by: penghuo <penghuo@gmail.com> * [Enhancement] optimize sort rewrite logic (#434) Optimize sort rewrite logic by using first and last parameter in Composite aggregation. Signed-off-by: penghuo <penghuo@gmail.com> * Support ISO 8601 Format in Date Format. (#460) Support ISO 8601 (%y-%m-%dT%TZ) in Date Formats. In order to do that we have started supporting plain characters in date format without a % in front. Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Chen Dai <46505291+dai-chen@users.noreply.github.com> Co-authored-by: Lyndon Bauto <58273576+lyndonb-bq@users.noreply.github.com> Co-authored-by: Chloe <chloezh1102@gmail.com> Co-authored-by: Peng Huo <penghuo@gmail.com> Co-authored-by: dblock <dblock@amazon.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua <joshuali925@gmail.com> Co-authored-by: David Cui <53581635+davidcui1225@users.noreply.github.com> Co-authored-by: Abbas Hussain <abbashus@amazon.com> Co-authored-by: Tengda-He <89666799+Tengda-He@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: guiangumpac <90278068+guiangumpac@users.noreply.github.com> Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu> Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> C…
forestmvey
added a commit
that referenced
this pull request
Jul 11, 2023
* Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Forest Vey <forestv@bitquilltech.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Forest Vey <forestv@bitquilltech.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit d044634)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Forest Vey <forestv@bitquilltech.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit d044634)
forestmvey
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Update docs to reflect recent changes. (#285) (#1826) * Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Forest Vey <forestv@bitquilltech.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit d044634) * Remove a test for a feature not backported to 2.x. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Jul 11, 2023
* Update docs to reflect recent changes. (#285) (#1826) * Update docs. * Apply suggestions from code review * Add example of quote escaping. * Update docs/user/general/datatypes.rst * Update docs/user/general/datatypes.rst --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Forest Vey <forestv@bitquilltech.com> Co-authored-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit d044634) * Remove a test for a feature not backported to 2.x. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chloe Zhang chloezh1102@gmail.com
Description
Issues Resolved
#266
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.