-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ztp: CNF-9748: Add ZAP labelling #1659
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vitus133: This pull request references CNF-9748 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
1ea0233
to
c28f8bc
Compare
This commit adds ZTP site-generator capabilities needed for ZAP (ZTP Accelerated Provisioning): - allow multiple manifestsConfigMapRefs in ACI, instead of deprecated manifestsConfigMapRef - add second configmap reference to ACI and label managedCluster when ztp-accelerated-provisioning is added to siteConfig clusterLabels Signed-off-by: Vitaly Grinberg <v.g@redhat.com>
@vitus133: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/lgtm |
@vitus133 : Just a quick note, when this feature will work end-to-end(PR from TALM gets merged), please update the upstream documentation in a separate PR. |
ef4e4d9
into
openshift-kni:master
refs: - openshift-kni#1659 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
This commit adds ZTP site-generator capabilities needed for ZAP (ZTP Accelerated Provisioning):
manifestsConfigMapRefs
in ACI, instead of the deprecatedmanifestsConfigMapRef
managedCluster
whenztp-accelerated-provisioning
labelis added to siteConfig
clusterLabels
and has one of the two predefined values/cc @imiller0 @lack