ztp: Downgrade MCO to an ignition version v3.2.0 #1817
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
zeeke
force-pushed
the
fix-mco-conflict
branch
from
2ede526
to
122bf33
Compare
openshift-merge-robot
added
the
needs-rebase
zeeke
force-pushed
the
fix-mco-conflict
branch
from
122bf33
to
f9e5721
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
|
/lgtm This is a band-aid, though. @sabbir-47 Can you link to the Jira item where we'll be doing a longer-term fix for this, once you've created it? |
|
/override ci/prow/e2e-aws-ci-tests |
|
@lack: Overrode contexts on behalf of lack: ci/prow/e2e-aws-ci-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ZTP must produce MachineConfig resources with ignition version v3.2.0 Since openshift/machine-config-operator#3814, MCO writes v3.4.0 ignition configuration. openshift/machine-config-operator@63d7be1 is the commit just before the culprit one. Also, machine-config-operator@63d7be1ef18b86826b47c61172c7a9dc7c2b6de1 has a transitive dependency to `github.com/Microsoft/hcsshim@v0.8.7` that cause a `go mod tidy` error: ``` github.com/Microsoft/hcsshim@v0.8.7 requires k8s.io/kubernetes@v1.13.0 requires k8s.io/endpointslice@v0.0.0: reading k8s.io/endpointslice/go.mod at revision v0.0.0: unknown revision v0.0.0 ``` which is fixed in v0.8.8 by microsoft/hcsshim#783 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
This reverts commit 3e6566e.
|
I need to rebase as some ignition v3.4.0 references have been introduced in: |
refs: - openshift-kni#1659 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
zeeke
force-pushed
the
fix-mco-conflict
branch
from
f9e5721
to
c248976
Compare
|
For the longer term fix, the story created: https://issues.redhat.com/browse/CNF-11361 |
|
/override ci/prow/e2e-aws-ci-tests |
|
@sabbir-47: sabbir-47 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-ci-tests not related to this PR |
|
@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-aws-ci-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @sabbir-47 , @lack can you give this another look? |
|
@sabbir-47 , @lack please, take another look |
|
/lgtm |
|
/retest |
|
/retest-required |
|
AWS related jobs are temporarily failing due to https://redhat-internal.slack.com/archives/CFUGK0K9R/p1712602383028359 /override ci/prow/e2e-aws-ci-tests |
|
@zeeke: Overrode contexts on behalf of zeeke: ci/prow/e2e-aws-ci-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 9b776a2
into
openshift-kni:master
ZTP must produce MachineConfig resources with ignition version v3.2.0
Since openshift/machine-config-operator#3814, MCO writes v3.4.0 ignition configuration.
openshift/machine-config-operator@63d7be1 is the commit just before the culprit one.
Also, machine-config-operator@63d7be1ef18b86826b47c61172c7a9dc7c2b6de1
has a transitive dependency to
github.com/Microsoft/hcsshim@v0.8.7that causea
go mod tidyerror:which is fixed in v0.8.8 by microsoft/hcsshim#783
cc @jzding, @sabbir-47 , @lack , @imiller0