Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base image: ubi8 to ubi9 #661

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

shajmakh
Copy link
Member

For RHAOS 4.14 we should rebase on ubi9 for binary artifacts

For RHAOS 4.14 we should rebase on ubi9 for binary artifacts

Signed-off-by: shajmakh <shajmakh@redhat.com>
@openshift-ci openshift-ci bot requested review from mrniranjan and yanirq July 21, 2023 12:16
@ffromani
Copy link
Member

I'm not sure the change is properly exercised because we discovered that failures in the internal lanes are silently skipped (#653)
Nevertheless, this change is correct and

fixes #660

@ffromani
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@ffromani ffromani merged commit c7cb7c9 into openshift-kni:main Jul 21, 2023
4 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@shajmakh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-unit 2dec339 link unknown /test ci-unit
ci/prow/ci-index 2dec339 link unknown /test ci-index
ci/prow/ci-install-e2e 2dec339 link unknown /test ci-install-e2e
ci/prow/ci-e2e 2dec339 link unknown /test ci-e2e
ci/prow/images 2dec339 link unknown /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shajmakh shajmakh deleted the 4.14-base-img-update branch December 7, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants