-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: fix RTE lane #653
e2e: fix RTE lane #653
Conversation
/cherry-pick release-4.13 |
@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest it seems infra issue? |
ok, the failure is real, but the log is misleading. Will work on that. |
actual error:
|
/retest |
da4055b
to
cf27ee7
Compare
seems like a real error |
yup, is a real error, previously masked by the silent failure. Working on it. |
/hold requires much more tuning |
/hold surely broken until RTE v0.12.0 is released and consumed |
depends on #663 |
requires: openshift/release#41614 |
d4cf414
to
a4a2091
Compare
921cdc9
to
d257f8b
Compare
Only a well known subset of tests (RTE local) needs the local exporter binary, so let's look for it and consume it only for that subset instead for the whole suite. Signed-off-by: Francesco Romani <fromani@redhat.com>
Focus on the subset of e2e tests u/s deems most stable. We should increase this set gradually - upstream first. Signed-off-by: Francesco Romani <fromani@redhat.com>
ended up rewriting a good part of the lane, and there are a lot of potential followups, but fixed at last and reviewable. |
/hold cancel |
like u/s RTE does, needed to run the RTE tests Signed-off-by: Francesco Romani <fromani@redhat.com>
add a new tool, to be used in CI mostly, to dump the Topology Manager configuration from the configmap populated by the kubeletconfig controller. Could be useful also for troubleshooting. Signed-off-by: Francesco Romani <fromani@redhat.com>
Use the newly added catkubeletconfmap tool to populate the env variables before run the RTE CI lane, so we can perform the full validation on RTE behavior. Signed-off-by: Francesco Romani <fromani@redhat.com>
the e2e runner is one of the oldest parts still left back in time we thought it could make sense to run the e2e against a real cluster, but this option never materialized, and we ended up using the runner only on CI. When running against existing clusters, we run the specific suites with extra parameters and config. The end result is the runner script is unnecessary complex and actually obfuscates the failure. Rewrite and simplify, tailoring for use on CI. Signed-off-by: Francesco Romani <fromani@redhat.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, swatisehgal, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ffromani: #653 failed to apply on top of branch "release-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We previously failed to bail out early if the RTE lane was failing.
The runner script ultimately returns the exit code of the last executed command. Problem is: also the latest
if
blockis a command, and the evaluation of the command was successful, swallowing the RTE lane failure (if any).
The test per se seems to be failed because we incorrectly always check for the exporter binary availability. But the exporter binary is not meant to be here, in this lane: it is tested explicitely in the separate RTE local lane.