e2e: fix RTE lane

[ffromani]

We previously failed to bail out early if the RTE lane was failing.
The runner script ultimately returns the exit code of the last executed command. Problem is: also the latest if block
is a command, and the evaluation of the command was successful, swallowing the RTE lane failure (if any).

The test per se seems to be failed because we incorrectly always check for the exporter binary availability. But the exporter binary is not meant to be here, in this lane: it is tested explicitely in the separate RTE local lane.

[ffromani]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@ffromani: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swatisehgal]

/lgtm

[ffromani]

/retest

it seems infra issue?

[ffromani]

ok, the failure is real, but the log is misleading. Will work on that.

[ffromani]

actual error:

End Captured GinkgoWriter Output�[0m

  �[38;5;9merr=unable to upgrade connection: container not found ("resource-topology-exporter") stderr=
  Unexpected error:
      <*errors.errorString | 0xc0001145a0>: {
          s: "unable to upgrade connection: container not found (\"resource-topology-exporter\")",
      }
      unable to upgrade connection: container not found ("resource-topology-exporter")
  occurred�[0m
  �[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/go/src/github.com/openshift-kni/numaresources-operator/test/e2e/rte/rte_test.go:315

[ffromani]

/retest

[Tal-or]

   W0718 06:42:29.151312   25843 metrics_grabber.go:110] Can't find any pods in namespace kube-system to grab metrics from
    Jul 18 06:42:29.208: INFO: 
    Latency metrics for node ip-10-0-241-243.us-east-2.compute.internal
    Jul 18 06:42:29.208: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
    STEP: Destroying namespace "topology-updater-5473" for this suite. 07/18/23 06:42:29.226
  << End Captured GinkgoWriter Output
  Timed out after 60.004s.
  Expected
      <bool>: false
  to be true
  In [It] at: /go/src/github.com/openshift-kni/numaresources-operator/vendor/github.com/k8stopologyawareschedwg/resource-topology-exporter/test/e2e/topology_updater/topology_updater.go:100

seems like a real error

[ffromani]

   W0718 06:42:29.151312   25843 metrics_grabber.go:110] Can't find any pods in namespace kube-system to grab metrics from
    Jul 18 06:42:29.208: INFO: 
    Latency metrics for node ip-10-0-241-243.us-east-2.compute.internal
    Jul 18 06:42:29.208: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
    STEP: Destroying namespace "topology-updater-5473" for this suite. 07/18/23 06:42:29.226
  << End Captured GinkgoWriter Output
  Timed out after 60.004s.
  Expected
      <bool>: false
  to be true
  In [It] at: /go/src/github.com/openshift-kni/numaresources-operator/vendor/github.com/k8stopologyawareschedwg/resource-topology-exporter/test/e2e/topology_updater/topology_updater.go:100

seems like a real error

yup, is a real error, previously masked by the silent failure. Working on it.

[ffromani]

/hold

requires much more tuning

[ffromani]

/hold

surely broken until RTE v0.12.0 is released and consumed

[ffromani]

depends on #663

[ffromani]

requires: openshift/release#41614

[ffromani]

ended up rewriting a good part of the lane, and there are a lot of potential followups, but fixed at last and reviewable.

[ffromani]

/hold cancel

[Tal-or]

/lgtm
/approve
Thanks for the changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, swatisehgal, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Tal-or,ffromani,swatisehgal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@ffromani: #653 failed to apply on top of branch "release-4.13":

Applying: e2e: rte: check the binary path only in local test
Using index info to reconstruct a base tree...
M	test/e2e/rte/rte_e2e_suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/rte/rte_e2e_suite_test.go
CONFLICT (content): Merge conflict in test/e2e/rte/rte_e2e_suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e: rte: check the binary path only in local test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.