Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump to k8s 1.26, RTE 0.12.0 #663

Merged
merged 3 commits into from
Jul 25, 2023
Merged

deps: bump to k8s 1.26, RTE 0.12.0 #663

merged 3 commits into from
Jul 25, 2023

Conversation

ffromani
Copy link
Member

Simple but quite massive deps bump, with minimal necessary codebase changes to adapt to new APIs.

@ffromani ffromani mentioned this pull request Jul 24, 2023
Merged
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@ffromani
bump deps: k8s, controller-runtime, RTE
ea32cc1 
Trivial but quite massive deps bump. Only vendor changes.

bump RTE to v0.12.0
bump kube to 1.26.4
bump controller-runtime to 0.14.6
pin ginkgo/gomega to the versions used by k8s 1.26.z

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
rte: e2e: update to k8s 1.26.4, RTE 0.12.0
22142e1 
Update the codebase to API changes in kube 1.26.4 (and related)
and in RTE v0.12.0.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
objectupdate: sched: test: fix debug output
9ee398d 
Actually emit the compared YAMLs on error.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@Tal-or
Copy link
Collaborator

Tal-or commented Jul 24, 2023

/lgtm
/approve
We need to take into account that we cannot bump to 1.27 because we depend on runtime-controller which didn't
bump to 1.27 yet: operator-framework/operator-sdk#6381

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Member Author

/lgtm /approve We need to take into account that we cannot bump to 1.27 because we depend on runtime-controller which didn't bump to 1.27 yet: operator-framework/operator-sdk#6381

GREAT point, thanks for raising. I think we can stick on 1.26.z for the time being and we do NOT need to jump on 1.27 shortly.

@ffromani
Copy link
Member Author

/retest

1 similar comment
@ffromani
Copy link
Member Author

/retest

@ffromani ffromani mentioned this pull request Jul 24, 2023
Closed
@ffromani
Copy link
Member Author

/test ci-e2e

1 similar comment
@ffromani
Copy link
Member Author

/test ci-e2e

@Tal-or
Copy link
Collaborator

Tal-or commented Jul 24, 2023

Not sure whether it's an infra issue or real one:

ClusterServiceVersion numaresources-operator.v4.14.999-snapshot was created but never became ready
Dumping ClusterServiceVersion numaresources-operator.v4.14.999-snapshot as /logs/artifacts/csv-numaresources-operator.v4.14.999-snapshot.yaml
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status phase: Failed
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status message: install failed: deployment numaresources-controller-manager not ready before timeout: deployment "numaresources-controller-manager" exceeded its progress deadline
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status reason: InstallCheckFailed
Dumping all installPlans in namespace numaresources-operator as /logs/artifacts/installPlans.yaml

@ffromani
Copy link
Member Author

Not sure whether it's an infra issue or real one:

ClusterServiceVersion numaresources-operator.v4.14.999-snapshot was created but never became ready
Dumping ClusterServiceVersion numaresources-operator.v4.14.999-snapshot as /logs/artifacts/csv-numaresources-operator.v4.14.999-snapshot.yaml
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status phase: Failed
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status message: install failed: deployment numaresources-controller-manager not ready before timeout: deployment "numaresources-controller-manager" exceeded its progress deadline
  ClusterServiceVersion numaresources-operator.v4.14.999-snapshot status reason: InstallCheckFailed
Dumping all installPlans in namespace numaresources-operator as /logs/artifacts/installPlans.yaml

let's crosscheck with #667

@ffromani
Copy link
Member Author

/test ci-e2e

@ffromani
Copy link
Member Author

ffromani commented Jul 25, 2023 •
edited
Loading

turns out the root cause is openshift/release#41614 (arguably it WAS infra issue... but the infra issue was on us!)

@ffromani
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a18bb57 into main Jul 25, 2023
10 checks passed
@ffromani ffromani deleted the deps-k8s-1.26.4 branch July 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlojosnegros jlojosnegros Awaiting requested review from jlojosnegros

@shajmakh shajmakh Awaiting requested review from shajmakh

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

@Tal-or Tal-or Awaiting requested review from Tal-or

Assignees

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ffromani @Tal-or @openshift-merge-robot