Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kni: rebase numaresources operator on top of ubi9 #41614

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

ffromani
Copy link
Contributor

align with the main repo switch to ubi9

Update from ubi8 to ubi9, following what we did in the main repo.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
move on 4.14. We didn't do previouly because the platform wasn't ready.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ffromani: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-index openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-install-e2e openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-ci-unit openshift-kni/numaresources-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-numaresources-operator-main-images openshift-kni/numaresources-operator presubmit Ci-operator config changed
periodic-ci-openshift-kni-numaresources-operator-main-ci-must-gather-e2e N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ffromani
Copy link
Contributor Author

/pj-rehearse

@ffromani
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 25, 2023
@ffromani
Copy link
Contributor Author

/cc @Tal-or @shajmakh

@openshift-ci openshift-ci bot requested review from shajmakh and Tal-or July 25, 2023 05:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shajmakh
Copy link
Contributor

Thanks for the PR.
/lgtm
/hold for Talor's review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@jlojosnegros
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jlojosnegros, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Contributor Author

/hold cancel

I think we have enough ACKs

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit f8dbfe1 into openshift:master Jul 25, 2023
24 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@ffromani: Updated the following 4 configmaps:

  • ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-numaresources-operator-main.yaml using file ci-operator/config/openshift-kni/numaresources-operator/openshift-kni-numaresources-operator-main.yaml
  • job-config-main-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-numaresources-operator-main-periodics.yaml using file ci-operator/jobs/openshift-kni/numaresources-operator/openshift-kni-numaresources-operator-main-periodics.yaml
  • job-config-main-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-numaresources-operator-main-postsubmits.yaml using file ci-operator/jobs/openshift-kni/numaresources-operator/openshift-kni-numaresources-operator-main-postsubmits.yaml
  • job-config-main-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kni-numaresources-operator-main-presubmits.yaml using file ci-operator/jobs/openshift-kni/numaresources-operator/openshift-kni-numaresources-operator-main-presubmits.yaml

In response to this:

align with the main repo switch to ubi9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani ffromani deleted the nrop-rebase-ubi9 branch July 25, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants