Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: split test-unit #667

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Makefile: split test-unit #667

merged 1 commit into from
Jul 25, 2023

Conversation

ffromani
Copy link
Member

add more focused targets:
test-controllers: controllers-only integration tests test-unit-pkgs: pkgs unit tests proper

keep the test-unit target with the old semantics for backward compatibility.

add more focused targets:
test-controllers: controllers-only integration tests
test-unit-pkgs: pkgs unit tests proper

keep the `test-unit` target with the old semantics
for backward compatibility.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@openshift-ci openshift-ci bot requested review from MarSik and yanirq July 24, 2023 14:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
This was referenced Jul 24, 2023
Copy link
Collaborator

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ffromani,swatisehgal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Member Author

/test ci-e2e

@ffromani
Copy link
Member Author

requires: openshift/release#41614

@ffromani ffromani added the cherry-pick-candidate Possible cherry-pick in the future label Jul 25, 2023
@ffromani
Copy link
Member Author

/retest

@ffromani ffromani merged commit 7082201 into main Jul 25, 2023
8 of 10 checks passed
@ffromani ffromani deleted the controllers-unit-tests branch July 25, 2023 11:38
@ffromani
Copy link
Member Author

/cherry-pick release-4.13

@ffromani ffromani added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 25, 2023
@openshift-cherrypick-robot

@ffromani: new pull request created: #671

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherry-pick-candidate Possible cherry-pick in the future lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants