Skip to content

Commit

Permalink
update workshop to v0.7.0
Browse files Browse the repository at this point in the history
  • Loading branch information
danielhelfand committed Oct 21, 2019
1 parent a3ba660 commit 50b4761
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .workshop/resources/101-subscription.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ spec:
name: openshift-pipelines-operator
source: installed-openshift-pipelines
sourceNamespace: openshift-operators
startingCSV: openshift-pipelines-operator.v0.5.2
startingCSV: openshift-pipelines-operator.v0.7.0
2 changes: 1 addition & 1 deletion code/tektontasks/openshift-client-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ spec:
image: quay.io/openshiftlabs/openshift-cli-tekton-workshop:2.0
command: ["/usr/local/bin/oc"]
args:
- "${inputs.params.ARGS}"
- "$(inputs.params.ARGS)"
6 changes: 3 additions & 3 deletions code/tektontasks/s2i-nodejs-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
- name: generate
image: quay.io/openshift-pipeline/s2i
workingdir: /workspace/source
command: ['s2i', 'build', '${inputs.params.PATH_CONTEXT}', 'registry.access.redhat.com/rhscl/nodejs-${inputs.params.VERSION}-rhel7', '--as-dockerfile', '/gen-source/Dockerfile.gen']
command: ['s2i', 'build', '$(inputs.params.PATH_CONTEXT)', 'registry.access.redhat.com/rhscl/nodejs-$(inputs.params.VERSION)-rhel7', '--as-dockerfile', '/gen-source/Dockerfile.gen']
volumeMounts:
- name: gen-source
mountPath: /gen-source
Expand All @@ -39,7 +39,7 @@ spec:
- name: build
image: quay.io/buildah/stable
workingdir: /gen-source
command: ['buildah', 'bud', '--tls-verify=${inputs.params.TLSVERIFY}', '--layers', '-f', '/gen-source/Dockerfile.gen', '-t', '${outputs.resources.image.url}', '.']
command: ['buildah', 'bud', '--tls-verify=$(inputs.params.TLSVERIFY)', '--layers', '-f', '/gen-source/Dockerfile.gen', '-t', '$(outputs.resources.image.url)', '.']
volumeMounts:
- name: varlibcontainers
mountPath: /var/lib/containers
Expand All @@ -56,7 +56,7 @@ spec:
privileged: true
- name: push
image: quay.io/buildah/stable
command: ['buildah', 'push', '--tls-verify=${inputs.params.TLSVERIFY}', '${outputs.resources.image.url}', 'docker://${outputs.resources.image.url}']
command: ['buildah', 'push', '--tls-verify=$(inputs.params.TLSVERIFY)', '$(outputs.resources.image.url)', 'docker://$(outputs.resources.image.url)']
volumeMounts:
- name: varlibcontainers
mountPath: /var/lib/containers
Expand Down
8 changes: 4 additions & 4 deletions workshop/content/exercises/task-definitions.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ run during this task. Each step is denoted by its `name`. `s2i-nodejs` has three
- name: generate
image: quay.io/openshift-pipeline/s2i
workingdir: /workspace/source
command: ['s2i', 'build', '${inputs.params.PATH_CONTEXT}', 'registry.access.redhat.com/rhscl/nodejs-${inputs.params.VERSION}-rhel7', '--as-dockerfile', '/gen-source/Dockerfile.gen']
command: ['s2i', 'build', '$(inputs.params.PATH_CONTEXT)', 'registry.access.redhat.com/rhscl/nodejs-$(inputs.params.VERSION)-rhel7', '--as-dockerfile', '/gen-source/Dockerfile.gen']
volumeMounts:
- name: gen-source
mountPath: /gen-source
Expand All @@ -77,7 +77,7 @@ run during this task. Each step is denoted by its `name`. `s2i-nodejs` has three
- name: build
image: quay.io/buildah/stable
workingdir: /gen-source
command: ['buildah', 'bud', '--tls-verify=${inputs.params.TLSVERIFY}', '--layers', '-f', '/gen-source/Dockerfile.gen', '-t', '${outputs.resources.image.url}', '.']
command: ['buildah', 'bud', '--tls-verify=$(inputs.params.TLSVERIFY)', '--layers', '-f', '/gen-source/Dockerfile.gen', '-t', '$(outputs.resources.image.url)', '.']
volumeMounts:
- name: varlibcontainers
mountPath: /var/lib/containers
Expand All @@ -100,7 +100,7 @@ run during this task. Each step is denoted by its `name`. `s2i-nodejs` has three
----
- name: push
image: quay.io/buildah/stable
command: ['buildah', 'push', '--tls-verify=${inputs.params.TLSVERIFY}', '${outputs.resources.image.url}', 'docker://${outputs.resources.image.url}']
command: ['buildah', 'push', '--tls-verify=${inputs.params.TLSVERIFY}', '$(outputs.resources.image.url)', 'docker://$(outputs.resources.image.url)']
volumeMounts:
- name: varlibcontainers
mountPath: /var/lib/containers
Expand Down Expand Up @@ -163,7 +163,7 @@ spec:
image: quay.io/openshiftlabs/openshift-cli-tekton-workshop:2.0
command: ["/usr/local/bin/oc"]
args:
- "${inputs.params.ARGS}"
- "$(inputs.params.ARGS)"
----

`openshift-client` doesn't have any inputs or outputs associated with it.
Expand Down

0 comments on commit 50b4761

Please sign in to comment.