NE-1530: IngressController LB Subnet Selection in AWS #1841

gcs278 · 2024-04-01T00:10:54Z

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers using load balancers in AWS. Introduce
under the IngressControllerLBSubnetsAWS FeatureGate. Works for both CLB and NLBs.

Enhancement: openshift/enhancements#1595
Epic: https://issues.redhat.com/browse/NE-705

openshift-ci-robot · 2024-04-01T00:10:57Z

@gcs278: This pull request references NE-705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.13" instead.

In response to this:

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers in AWS. Introduce under the
AWSLoadBalancerSubnetSelection FeatureGate. Works for both CLB and NLBs.

Enhancement: openshift/enhancements#1595
RFE: https://issues.redhat.com/browse/RFE-1717.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-04-01T00:10:59Z

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot · 2024-04-01T00:11:43Z

@gcs278: This pull request references NE-1530 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers in AWS. Introduce under the
AWSLoadBalancerSubnetSelection FeatureGate. Works for both CLB and NLBs.

Enhancement: openshift/enhancements#1595
RFE: https://issues.redhat.com/browse/RFE-1717.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-01T00:12:07Z

@gcs278: This pull request references NE-1530 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers in AWS. Introduce under the
AWSLoadBalancerSubnetSelection FeatureGate. Works for both CLB and NLBs.

Enhancement: openshift/enhancements#1595
Epic: https://issues.redhat.com/browse/NE-705

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-03T21:50:27Z

@gcs278: This pull request references NE-1530 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers using load balancers in AWS. Introduce
under the IngressControllerLBSubnetsAWS FeatureGate. Works for both CLB and NLBs.

Enhancement: openshift/enhancements#1595
Epic: https://issues.redhat.com/browse/NE-705

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gcs278 · 2024-04-03T21:53:28Z

/hold
EP is still under review and it's likely we will add a ingresses.config.openshift.io.spec.loadBalancer.platform.aws.subnets field as well.

operator/v1/types_ingress.go

Miciah · 2024-06-27T20:27:19Z

I'm not sure whether this PR is waiting for my /lgtm or is only blocked on #1917, but just in case—
/lgtm

JoelSpeed · 2024-07-01T13:04:39Z

/test verify-crd-schema

gcs278 · 2024-07-01T14:14:28Z

There is interest in refactoring Subnets from the higher-level AWSLoadBalancerParameters to more specific AWSClassicLoadBalancerParameters to AWSNetworkLoadBalancerParameters for better handling of future additions of new types of LBs.
/hold

gcs278 · 2024-07-01T18:40:35Z

@JoelSpeed @Miciah @candita updated API per @JoelSpeed suggestion in slack. The subnets field has been moved from AWSLoadBalancerParameters to under AWSClassicLoadBalancerParameters and AWSNetworkLoadBalancerParameters.

Sorry about mixing the rebase in the recent force push (I usually try to avoid that), but the changes are in the type_ingress.go diff and the Integration Tests diff

JoelSpeed

If we fix the list comment I've made in both places that list shows up, then I'm happy with the API fields as they are.

Are we only doing subnets in the spec now? I thought they were previously in spec and status?

JoelSpeed · 2024-07-04T09:19:59Z

operator/v1/types_ingress.go

+// AWSSubnets contains a list of references to AWS subnets by
+// ID or name.
+// +kubebuilder:validation:XValidation:rule=`has(self.ids) && has(self.names) ? size(self.ids + self.names) <= 10 : true`,message="the total number of subnets cannot exceed 10"
+// +kubebuilder:validation:XValidation:rule=`has(self.ids) || has(self.names)`,message="must specify at least 1 subnet name or id"


There is a min properties validation that means you must have at least one item in the struct for it to be valid, not sure if that's better than this (since you have a custom error message), but thought I'd let you know in case you wanted to try it

Nice. I appreciate the pointer. The error message with // +kubebuilder:validation:MinProperties=1 is:

spec.endpointPublishingStrategy.loadBalancer.providerParameters.aws.classicLoadBalancer.subnets in body should have at least 1 properties

I suppose my custom error message may be considered slightly more specific than that, so I'll keep the CEL.

operator/v1/types_ingress.go

gcs278

Thanks @JoelSpeed

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers using load balancers in AWS. Introduce under the `IngressControllerLBSubnetsAWS` FeatureGate.

JoelSpeed · 2024-07-09T08:16:15Z

/lgtm

Feel free to cancel the hold if the network folks are happy now

JoelSpeed · 2024-07-09T15:14:38Z

/override ci/prow/verify-crd-schema

openshift-ci · 2024-07-09T15:19:28Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

candita · 2024-07-09T20:13:36Z

/lgtm
/unhold

openshift-ci · 2024-07-09T20:14:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, gcs278, JoelSpeed, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-07-10T00:02:38Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-07-10T04:12:59Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407100341.p0.g465787e.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 1, 2024

openshift-ci bot requested review from deads2k and JoelSpeed April 1, 2024 00:11

gcs278 force-pushed the NE705-subnets branch from 10900de to 0fa9b22 Compare April 1, 2024 00:11

gcs278 changed the title ~~NE-705: Add API for AWS LB Subnet Selection~~ NE-1530: Add API for AWS LB Subnet Selection Apr 1, 2024

gcs278 force-pushed the NE705-subnets branch from 0fa9b22 to f4b084d Compare April 3, 2024 02:54

gcs278 changed the title ~~NE-1530: Add API for AWS LB Subnet Selection~~ [WIP] NE-1530: Add API for AWS LB Subnet Selection Apr 3, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024

gcs278 force-pushed the NE705-subnets branch from f4b084d to 2e7c6f8 Compare April 3, 2024 21:21

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024

gcs278 force-pushed the NE705-subnets branch from 2e7c6f8 to d661c33 Compare April 3, 2024 21:24

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024

gcs278 force-pushed the NE705-subnets branch from d661c33 to 49e4cab Compare April 3, 2024 21:48

gcs278 changed the title ~~[WIP] NE-1530: Add API for AWS LB Subnet Selection~~ NE-1530: IngressController LB Subnet Selection in AWS Apr 3, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024

gcs278 force-pushed the NE705-subnets branch from 49e4cab to 061b1e3 Compare April 4, 2024 14:31

gcs278 changed the title ~~NE-1530: IngressController LB Subnet Selection in AWS~~ [WIP] NE-1530: IngressController LB Subnet Selection in AWS Apr 6, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2024

gcs278 force-pushed the NE705-subnets branch from 061b1e3 to 127fb08 Compare April 7, 2024 17:29

gcs278 changed the title ~~[WIP] NE-1530: IngressController LB Subnet Selection in AWS~~ NE-1530: IngressController LB Subnet Selection in AWS Apr 7, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024

Miciah reviewed Jun 27, 2024

View reviewed changes

operator/v1/types_ingress.go Outdated Show resolved Hide resolved

openshift-ci bot assigned Miciah Jun 27, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024

gcs278 force-pushed the NE705-subnets branch from b3a97aa to 7d33979 Compare July 1, 2024 18:27

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024

gcs278 mentioned this pull request Jul 3, 2024

CORS-3440: IngressController subnet selection at installation openshift/enhancements#1634

Open

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024

gcs278 force-pushed the NE705-subnets branch from 7d33979 to 3abde72 Compare July 3, 2024 15:56

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024

JoelSpeed reviewed Jul 4, 2024

View reviewed changes

gcs278 force-pushed the NE705-subnets branch from 3abde72 to 7da8c0f Compare July 8, 2024 18:25

gcs278 commented Jul 8, 2024

View reviewed changes

NE-1530: IngressController LB Subnet Selection in AWS

2cc2fb7

Allows users to specify subnets (i.e. Availability Zones) for IngressControllers using load balancers in AWS. Introduce under the `IngressControllerLBSubnetsAWS` FeatureGate.

gcs278 force-pushed the NE705-subnets branch from 7da8c0f to 2cc2fb7 Compare July 8, 2024 18:42

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2024

openshift-merge-bot bot merged commit 465787e into openshift:master Jul 10, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NE-1530: IngressController LB Subnet Selection in AWS #1841

NE-1530: IngressController LB Subnet Selection in AWS #1841

gcs278 commented Apr 1, 2024 •

edited

Loading

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 3, 2024 •

edited by openshift-ci bot

Loading

gcs278 commented Apr 3, 2024

Miciah commented Jun 27, 2024

JoelSpeed commented Jul 1, 2024

gcs278 commented Jul 1, 2024

gcs278 commented Jul 1, 2024 •

edited

Loading

JoelSpeed left a comment

JoelSpeed Jul 4, 2024

gcs278 Jul 8, 2024

gcs278 left a comment

JoelSpeed commented Jul 9, 2024

JoelSpeed commented Jul 9, 2024

openshift-ci bot commented Jul 9, 2024

candita commented Jul 9, 2024

openshift-ci bot commented Jul 9, 2024

openshift-ci bot commented Jul 10, 2024

openshift-bot commented Jul 10, 2024

NE-1530: IngressController LB Subnet Selection in AWS #1841

NE-1530: IngressController LB Subnet Selection in AWS #1841

Conversation

gcs278 commented Apr 1, 2024 • edited Loading

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Apr 3, 2024 • edited by openshift-ci bot Loading

gcs278 commented Apr 3, 2024

Miciah commented Jun 27, 2024

JoelSpeed commented Jul 1, 2024

gcs278 commented Jul 1, 2024

gcs278 commented Jul 1, 2024 • edited Loading

JoelSpeed left a comment

Choose a reason for hiding this comment

JoelSpeed Jul 4, 2024

Choose a reason for hiding this comment

gcs278 Jul 8, 2024

Choose a reason for hiding this comment

gcs278 left a comment

Choose a reason for hiding this comment

JoelSpeed commented Jul 9, 2024

JoelSpeed commented Jul 9, 2024

openshift-ci bot commented Jul 9, 2024

candita commented Jul 9, 2024

openshift-ci bot commented Jul 9, 2024

openshift-ci bot commented Jul 10, 2024

openshift-bot commented Jul 10, 2024

gcs278 commented Apr 1, 2024 •

edited

Loading

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 3, 2024 •

edited by openshift-ci bot

Loading

gcs278 commented Jul 1, 2024 •

edited

Loading