-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-34906: Fix IngressController missing listTypes #1917
Conversation
Hello @gcs278! Some important instructions when contributing to openshift/api: |
@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6d9a70a
to
e11496e
Compare
Since Only |
@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add missing listType to all IngressController CRD fields which resolves the error "must set x-kubernetes-list-type" in the verify-crd-schema job.
Just putting a hold in case we want NE team members to review too. |
/approve Miciah to LGTM and unhold assuming he is happy |
/label qe-approved |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, JoelSpeed, Miciah, miheer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Installation and unrelated failures |
/retest |
1 similar comment
/retest |
TechPreviews jobs are failing, looks like it's being investigated slack thread e2e-upgrade-minor is permafailing with: |
I believe the revert openshift/cluster-version-operator#1063 is supposed to fix the tech preview jobs: |
/test e2e-upgrade-minor |
Reviewing the changes in this PR, the only payload affecting change adds an explicit atomic tag to a field, where this is the default behaviour when unspecified, I'm happy that we can skip the upgrade minor for now since we know it's broken. /override ci/prow/e2e-upgrade-minor |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade-minor In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@gcs278: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@gcs278: Jira Issue OCPBUGS-34906: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-34906 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407011041.p0.gd3b3bb1.assembly.stream.el9 for distgit ose-cluster-config-api. |
Add missing
listType
to all IngressController CRD fields which resolves the errorsmust set x-kubernetes-list-type
in theverify-crd-schema
job.The
verify-crd-schema
job won't run IngressController CRD checks on this PR because we aren't creating/moving/renaming any IngressController CRD files. However, when adding a TechPreview feature, such as in #1841, it will bifurcate the CRDs into feature sets andverify-crd-schema
will fail. Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1841/pull-ci-openshift-api-master-verify-crd-schema/1798501310060826624Though there are 3 options,
atomic
,set
, andmap
, the API team has expressed desire NOT to useset
. So, thelistType
options are limited toatomic
andmap
.Atomic
listType=atomic
is the default when it is not configured. Therefore, settinglistType=atomic
has essentially no risk of breaking compatibly.Map
listMapKey
) must be unique in the list