OCPBUGS-34906: Fix IngressController missing listTypes

[gcs278]

Add missing listType to all IngressController CRD fields which resolves the errors must set x-kubernetes-list-type in the verify-crd-schema job.

The verify-crd-schema job won't run IngressController CRD checks on this PR because we aren't creating/moving/renaming any IngressController CRD files. However, when adding a TechPreview feature, such as in #1841, it will bifurcate the CRDs into feature sets and verify-crd-schema will fail. Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1841/pull-ci-openshift-api-master-verify-crd-schema/1798501310060826624

Though there are 3 options, atomic, set, and map, the API team has expressed desire NOT to use set. So, the listType options are limited to atomic and map.

Atomic

• The listType=atomic is the default when it is not configured. Therefore, setting listType=atomic has essentially no risk of breaking compatibly.
• The entire list will be replaced upon SSA merge.
• At any point in time, a single manager owns the list.

Map

• Must be a nested type (struct)
• The key values (see listMapKey) must be unique in the list
• Can be managed by multiple managers at any given time.

[openshift-ci]

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

WIP

Add missing // +listType to fields in types_ingress.go and fields referenced by objects in types_ingress.go which resolves the errors must set x-kubernetes-list-type in the verify-crd-schema job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

Since verify-crd-schema won't run until there is a new file, I pushed up a hack commit (the commit from #1841) to force verify-crd-schema to run for IngressController. The results are here: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1917/pull-ci-openshift-api-master-verify-crd-schema/1798835607204532224

Only may not be a map errors left, which are in vendor code and not easily fixable. Unfortunately, this fix alone won't trigger verify-crd-schema to run for the IngressController API.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-34906, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add missing listType to all IngressController CRD fields which resolves the errors must set x-kubernetes-list-type in the verify-crd-schema job.

Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1841/pull-ci-openshift-api-master-verify-crd-schema/1798501310060826624

Though there are 3 options, atomic, set, and map, the API team has expressed desire NOT to use set. So, the listType options are limited to atomic and map.

Atomic

• The listType=atomic is the default when it is not configured. Therefore, setting listType=atomic has essentially no risk of breaking compatibly.
• The entire list will be replaced upon SSA merge.
• At any point in time, a single manager owns the list.

Map

• Must be a nested type (struct)
• The key values (see listMapKey) must be unique in the list
• Can be managed by multiple managers at any given time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

Just putting a hold in case we want NE team members to review too.
/hold

[JoelSpeed]

/approve
/assign @Miciah

Miciah to LGTM and unhold assuming he is happy

[lihongan]

/label qe-approved

[miheer]

/lgtm
/hold for @Miciah to review

[Miciah]

/lgtm
/hold cancel
Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, JoelSpeed, Miciah, miheer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0689f00 and 2 for PR HEAD e3df50e in total

[gcs278]

Installation and unrelated failures
/retest

[gcs278]

/retest

[JoelSpeed]

/retest

[gcs278]

TechPreviews jobs are failing, looks like it's being investigated slack thread

e2e-upgrade-minor is permafailing with:
: [bz-etcd][invariant] alert/etcdMembersDown should not be at or above info. I searched around, and couldn't find anyone talking about this, so I asked in forum-ocp-testplatform: slack thread

[gcs278]

I believe the revert openshift/cluster-version-operator#1063 is supposed to fix the tech preview jobs:
/retest

[lihongan]

/test e2e-upgrade-minor

[JoelSpeed]

Reviewing the changes in this PR, the only payload affecting change adds an explicit atomic tag to a field, where this is the default behaviour when unspecified, I'm happy that we can skip the upgrade minor for now since we know it's broken.

/override ci/prow/e2e-upgrade-minor

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade-minor

In response to this:

Reviewing the changes in this PR, the only payload affecting change adds an explicit atomic tag to a field, where this is the default behaviour when unspecified, I'm happy that we can skip the upgrade minor for now since we know it's broken.

/override ci/prow/e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@gcs278: Jira Issue OCPBUGS-34906: All pull requests linked via external trackers have merged:

• openshift/api#1917

Jira Issue OCPBUGS-34906 has been moved to the MODIFIED state.

In response to this:

Add missing listType to all IngressController CRD fields which resolves the errors must set x-kubernetes-list-type in the verify-crd-schema job.

The verify-crd-schema job won't run IngressController CRD checks on this PR because we aren't creating/moving/renaming any IngressController CRD files. However, when adding a TechPreview feature, such as in #1841, it will bifurcate the CRDs into feature sets and verify-crd-schema will fail. Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1841/pull-ci-openshift-api-master-verify-crd-schema/1798501310060826624

Though there are 3 options, atomic, set, and map, the API team has expressed desire NOT to use set. So, the listType options are limited to atomic and map.

Atomic

• The listType=atomic is the default when it is not configured. Therefore, setting listType=atomic has essentially no risk of breaking compatibly.
• The entire list will be replaced upon SSA merge.
• At any point in time, a single manager owns the list.

Map

• Must be a nested type (struct)
• The key values (see listMapKey) must be unique in the list
• Can be managed by multiple managers at any given time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407011041.p0.gd3b3bb1.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.