-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17353: Debug pod left in ImagePullBackOff after install in disconnected environment #6333
MGMT-17353: Debug pod left in ImagePullBackOff after install in disconnected environment #6333
Conversation
…nnected environment Fot day2 hosts the functionality is removed since we don't want to enable it for kube-api Revert "MGMT-15902: Trigger reboots for node event when day2 node moves to done (openshift#5648)" This reverts commit 652202c.
@ori-amizur: This pull request references MGMT-17353 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ori-amizur: This pull request references MGMT-17353 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
==========================================
+ Coverage 68.27% 68.70% +0.42%
==========================================
Files 241 244 +3
Lines 35873 38634 +2761
==========================================
+ Hits 24493 26543 +2050
- Misses 9215 9730 +515
- Partials 2165 2361 +196
|
/retest |
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405310413.p0.g5bbf696.assembly.stream.el9 for distgit ose-agent-installer-api-server. |
/cherry-pick release-ocm-2.10 |
@CrystalChun: new pull request created: #6539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
For day2 hosts the functionality is removed since we don't want to enable it for kube-api
Revert "MGMT-15902: Trigger reboots for node event when day2 node moves to done (#5648)"
This reverts commit 652202c.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @tsorya