Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.10] MGMT-18330: Debug pod left in ImagePullBackOff after install in disconnected environment #6539

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #6333

/assign CrystalChun

…nnected environment

Fot day2 hosts the functionality is removed since we don't want to
enable it for kube-api

Revert "MGMT-15902: Trigger reboots for node event when day2 node moves to done (openshift#5648)"

This reverts commit 652202c.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17353

In response to this:

This is an automated cherry-pick of #6333

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2024
@CrystalChun
Copy link
Contributor

CrystalChun commented Jul 5, 2024

/retitle [release-ocm-2.10] MGMT-18330: Debug pod left in ImagePullBackOff after install in disconnected environment

@openshift-ci openshift-ci bot changed the title [release-ocm-2.10] MGMT-17353: Debug pod left in ImagePullBackOff after install in disconnected environment [release-ocm-2.10] MGMT-18330: Debug pod left in ImagePullBackOff after install in disconnected environment Jul 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

@openshift-cherrypick-robot: This pull request references MGMT-18330 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #6333

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CrystalChun
Copy link
Contributor

/uncc @danmanor @romfreiman
/cc @gamli75

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (e12c533) to head (9b650e8).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.10    #6539      +/-   ##
====================================================
- Coverage             68.32%   68.31%   -0.02%     
====================================================
  Files                   237      236       -1     
  Lines                 35163    35088      -75     
====================================================
- Hits                  24024    23969      -55     
+ Misses                 9062     9048      -14     
+ Partials               2077     2071       -6     
Files Coverage Δ
...nternal/controller/controllers/agent_controller.go 74.77% <ø> (+0.23%) ⬆️

@openshift-ci openshift-ci bot requested review from gamli75 and removed request for romfreiman and danmanor July 5, 2024 17:41
Copy link

openshift-ci bot commented Jul 5, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ca619df into openshift:release-ocm-2.10 Jul 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants