Create boilerplate v5.0.1 to support Go 1.22 #363
Conversation
openshift-ci
bot
added
the
approved
Signed-off-by: Michael Shen <mshen@redhat.com>
Signed-off-by: Michael Shen <mshen@redhat.com>
|
/hold For this commit to be tagged with v5.0.1 if it looks ok before merging |
openshift-ci
bot
added
the
do-not-merge/hold
|
@mjlshen PR title should be |
mjlshen
changed the title
Makes sense, and we can delete the old ones too and keep renaming the current one? Or should we just add a comment in the shell script that holds the version instead? The latter seems easier to me, but I think both are better than current state |
|
@mjlshen I think a comment makes most sense. |
This avoids having to maintain older scripts which were not being used in practice and lets us better leverage git. Signed-off-by: Michael Shen <mshen@redhat.com>
|
/assign @dustman9000 When you get a chance could you tag the HEAD of this PR ( |
|
/unhold The commit is now tagged with |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, mjlshen, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mjlshen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Breaking change: In the past we would have done a major version (e.g. v6.0.0), but the past few bumps have been painless and the Go promise of backwards support has been paying dividends. Has the side benefit of allowing the changes in
config/build_image-v5.0.0.shto be sanely reviewed instead of copy+pasting it and modifying versions at the same time.Otherwise, updates the base image to support Go 1.22 for when people need it.
OSD-24219