Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating boilerplate for RPO #179

Merged

Conversation

ravitri
Copy link
Member

@ravitri ravitri commented Jul 9, 2024

What type of PR is this?

(boilerplate update)

Updating boilerplate for RPO operator and registry

@openshift-ci openshift-ci bot requested review from a7vicky and Tafhim July 9, 2024 02:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@bmeng
Copy link
Contributor

bmeng commented Jul 9, 2024

/retest

@mjlshen
Copy link

mjlshen commented Jul 9, 2024

Caused by openshift/boilerplate#363, but I think openshift/boilerplate#370 has a good chance of resolving the boilerplate image build issue that caused this

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@464f7f6). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #179   +/-   ##
=========================================
  Coverage          ?   46.54%           
=========================================
  Files             ?        9           
  Lines             ?      752           
  Branches          ?        0           
=========================================
  Hits              ?      350           
  Misses            ?      392           
  Partials          ?       10           

@mjlshen
Copy link

mjlshen commented Jul 10, 2024

make container-generate will fix validate, I'm not sure if make container-lint will fix the linting failure or just show the same failure for you to manually fix. You can teach me 😅

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@ravitri: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@a7vicky
Copy link
Member

a7vicky commented Jul 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7vicky, ravitri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e08b35f into openshift:master Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants