Merge https://github.com/kubernetes/cloud-provider-gcp:master (1de8477) into master #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
Update gcpcredential.go Remove update from pkg file as it is obsolete
Create kustomization in deploy package
Adds OWNERS to auth-provider-gcp
Parallel test closures execute in a goroutine, possibly after the next loop iteration has already began. As a result, the loop var they capture changes before the test execute, leading to all of them executing just the last test in the map. This fixes that by making the closure capture local variables rather than the loop variables See similar main kubernetes repo PR kubernetes/kubernetes#111846
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/invalid-owners-file
Fix broken `TestCACacheVerify` test
L4 ILB - skip nodes from the non default network if multi subnet is t…
Add NetworkAttachment to GKENetworkParamSet CRD
Change-Id: Ibf325679a341392e914ff1d9200aac0bb572a4d9
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
2e976a7
to
c16603a
Compare
use the GKE networking CRDs from GoogleCloudPlatform platform repo
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
c16603a
to
2b9d384
Compare
Signed-off-by: Vinayak Goyal <vinaygo@google.com>
Ran go get -u github.com/GoogleCloudPlatform/gke-networking-api
Ran tools/update_vendor.sh
Update gke-networking-api to latest version
Remove all GKE specific code from gcp-controller-manager.
Update GNP validations for network attachments
Update golang compute api package version
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
f634480
to
a6c897b
Compare
Different node pools can have NICs on the same VPC but different subnet. This should be allowd
Allow multiple device networks to have the same VPC
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
a6c897b
to
77b8f55
Compare
Handle CIDR allocation for network attachments
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
77b8f55
to
3d55aca
Compare
- 5 years ago tpuapi.New(client) required a client, however now, it uses just a context, so argument that is passed is no longer needed
Commands executed: - go get -u cloud.google.com/go/compute - go mod tidy - go mod vendor - ./tools/update_vendor.sh
Remove unused client argument
Update golang gcp compute APIs
…ed by Ingress-GCE (cherry picked from commit 97e991b)
Based on docs for internal loadbalancer here [1], backend services [2] and instances in instance-groups [3], following restrictions apply: - Internal LB can load balance to VMs in same region, but different subnets - Instance groups for the backend service must contain instance of the same subnet - An instance can only belong to one load balanced instance group - It is probably useful use-case to have nodes for the cluster belong to more than one subnet. And the current setup fails to create an internal load balancer with nodes in multiple subnets. This change finds pre-existing instance-groups that ONLY contain instances that belong to the cluster, uses them for the backend service. And only ensures instance-groups for remaining ones. [1] https://cloud.google.com/load-balancing/docs/internal [2] https://cloud.google.com/load-balancing/docs/backend-service#restrictions_and_guidance [3] https://cloud.google.com/compute/docs/instance-groups/creating-groups-of-unmanaged-instances#addinstances Co-authored-by: Abhinav Dahiya <abhinav.dahiya@redhat.com> Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com> # Conflicts: # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_fake.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_instancegroup.go # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_loadbalancer_internal.go
This adds the .spec required for building auth-provider-gcp as an RPM To keep naming consistent across credential provider specs, we use the name gcr-credential-provider It also includes build-rpms.sh, used to build the RPM in CI.
This updates the logic from ac00767 for using existing instance groups to allow the bootstrap node to be present in the instance group.. Prior to this commit logic to utilize existing instance groups checked to ensure the instance group contains only cluster nodes (which the bootstrap node is not), so if the bootstrap node is in the same ig as ne of the masters, the master would be added to a second ig, which breaks things. We can resolve the issue by relaxing the logic to ensure that all instances in the instance group have the node prefix. Vendors the changes in order to be utilized by the cloud provider. Fixes OCPBUGS-35256 # Conflicts: # vendor/k8s.io/cloud-provider-gcp/providers/gce/gce_loadbalancer_internal.go
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
3d55aca
to
38b747d
Compare
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.