Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1875036: remove Dockerfile.rhel7 #118

Merged

Conversation

elmiko
Copy link

@elmiko elmiko commented Sep 2, 2020

This change removes the now deprecated Dockerfile.rhel7 in favor of the
new Dockerfile.rhel.

This change removes the now deprecated Dockerfile.rhel7 in favor of the
new Dockerfile.rhel.
@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1875036, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1875036: remove Dockerfile.rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 2, 2020
@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

i think we will need to wait until the changes in ocp-build-data have propogated before the tests will pass.

@enxebre
Copy link
Member

enxebre commented Sep 3, 2020

Cross referencing openshift-eng/ocp-build-data#636
/lgtm

@openshift-ci-robot
Copy link

@enxebre: changing LGTM is restricted to collaborators

In response to this:

Cross referencing openshift-eng/ocp-build-data#636
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Sep 8, 2020

/retest
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@openshift-ci-robot
Copy link

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack e8839c8 link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre
Copy link
Member

mandre commented Sep 8, 2020

/lgtm
CI failure is unrelated.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, enxebre, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 694e8ca into openshift:master Sep 8, 2020
@openshift-ci-robot
Copy link

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1875036 has been moved to the MODIFIED state.

In response to this:

Bug 1875036: remove Dockerfile.rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants