Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile paths for machine-api image configurations #636

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Update dockerfile paths for machine-api image configurations #636

merged 1 commit into from
Sep 2, 2020

Conversation

elmiko
Copy link

@elmiko elmiko commented Sep 1, 2020 •
edited
Loading

This change is in support of bugzilla 1872080. It modifies the
configuration files for the machine-api components by adjusting their
dockerfile to match the newly created "Dockerfile.rhel" files.

This change also depends on several pull requests and should not be
merged until they are:
openshift/machine-api-operator#692
openshift/cluster-api-provider-gcp#118
openshift/cluster-api-provider-aws#349
openshift/cluster-api-provider-ovirt#67
openshift/cluster-api-provider-openstack#115
openshift/kubernetes-autoscaler#169
openshift/kubernetes-autoscaler#168
openshift/cluster-api-provider-azure#161
openshift/cluster-api-provider-baremetal#102
openshift/cluster-autoscaler-operator#161
openshift/cluster-machine-approver#83

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 1, 2020
@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1872080, which is invalid:

  • expected Bugzilla bug 1872080 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1872080: Update dockerfile paths for machine-api image configurations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Author

elmiko commented Sep 1, 2020

opening this as draft until the other PRs merge

@openshift-bot
Copy link

Build #1

None: Max retries exceeded with url: /openshift/kubernetes-autoscaler/blob/release-4.6/images/cluster-autoscaler/Dockerfile.rhel (Caused by None)

@elmiko
Copy link
Author

elmiko commented Sep 1, 2020

looking at the history here, perhaps this doesn't need the bug prefix.
/retitle Update dockerfile paths for machine-api image configurations

@openshift-ci-robot openshift-ci-robot changed the title Bug 1872080: Update dockerfile paths for machine-api image configurations Update dockerfile paths for machine-api image configurations Sep 1, 2020
@openshift-ci-robot
Copy link

@elmiko: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update dockerfile paths for machine-api image configurations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 1, 2020
This was referenced Sep 2, 2020
Merged
Merged
@elmiko elmiko force-pushed the bz-1872080-mapi-components branch from 6f36078 to 30ee176 Compare September 2, 2020 13:52
@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

updated to add cluster-autoscaler-operator and cluster-machine-approver

@openshift-bot
Copy link

Build #2

None: Max retries exceeded with url: /openshift/cluster-api-provider-azure/blob/release-4.6/Dockerfile.rhel (Caused by None)

This was referenced Sep 2, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

all the dependent changes have merged, i am removing the hold
/hold cancel

@elmiko elmiko marked this pull request as ready for review September 2, 2020 19:26
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2020
@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

/retest

@yselkowitz
Copy link

Checked that all PRs have already fast-forwarded to release-4.6
/lgtm
/assign @jupierce

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@jupierce jupierce merged commit 8112d3d into openshift-eng:openshift-4.6-rhel-8 Sep 2, 2020
This was referenced Sep 3, 2020
Merged
Merged
Merged
Merged
Merged
enxebre added a commit to enxebre/cluster-machine-approver that referenced this pull request Sep 3, 2020
@enxebre
Remove deprecated Dockerfile.rhel7 file
3f5f671 
Since we consolidate on having Dockerfile.rhel named files in all repos and the build data is pointing to it openshift-eng/ocp-build-data#636 this can be dropped now
@enxebre enxebre mentioned this pull request Sep 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yselkowitz yselkowitz

@jupierce jupierce

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elmiko @openshift-ci-robot @openshift-bot @yselkowitz @jupierce