-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data #692
Conversation
This change adds a new Dockerfile.rhel file to control builds that target rhel. It is inspired by the automatically generated patches which ensure that build files match what is in the [ocp-build-data repository](https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images) used for producing release artifacts. After this change merges, the configuration files in https://github.com/openshift/release/blob/master/ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-master.yaml and https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/ose-machine-api-operator.yml should be updated with the new dockerfile path.
@elmiko: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
the previous autogenerated commit for this has merged (#683). this change will help us better define the boundaries for the various dockerfiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What's up with this failure? (From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-api-operator/692/pull-ci-openshift-machine-api-operator-master-e2e-gcp/1300508328136282112)
|
i am adding the approval to this as these patches as there is a time-sensitive need for these changes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@crawford i'm not sure why those errors are raised, but the build log seems to indicate there is also some update issue (not sure if related)
|
@elmiko interesting, it might be flaky. Let's run it again to see. /retest |
sounds good @crawford, i'm going to remove the hold here as i don't think this change is causing the issue. |
/refresh |
Per #692 (comment) and due to the bot outage: /hold cancel |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
adding a reference to the dependent PR, openshift-eng/ocp-build-data#636 |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
This change adds a new Dockerfile.rhel file to control builds that
target rhel. It is inspired by the automatically generated patches which
ensure that build files match what is in the
ocp-build-data
repository
used for producing release artifacts.
After this change merges, the configuration files in
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-master.yaml
and
https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/ose-machine-api-operator.yml
should be updated with the new dockerfile path.