Bug 1872080: Create Dockerfile.rhel file #83
Conversation
openshift-ci-robot
requested review from
alexander-demicev and
michaelgugino
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This creates a Dockerfile.rhel file according to convention and symlink Dockerfile.rhel7 to the new one to satisfy tooling consumers until we switch them
|
thanks Alberto! |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
|
adding a reference to the dependent PR, openshift-eng/ocp-build-data#636 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
There's no need to do this. We should update the release repo to point to docker.rhel once all the repos are migrated, then we remove the rhel7 dockerfile. |
That needs to be done regardless. This just makes the current PR changes visible for any consumer tooling pointing to the deprecated file immediately both on CI against this PR and as they get merged afterwards. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle Bug 1872080: Create Dockerfile.rhel file |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@enxebre: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83
This creates a Dockerfile.rhel file according to convention and symlink Dockerfile.rhel7 to the new one to satisfy tooling consumers until we switch them