Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Cleanup ServiceAccount #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OpenStack: Cleanup ServiceAccount #338

wants to merge 1 commit into from

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Apr 11, 2024 •
edited
Loading

For an unknown reason OpenStack was different in CCCMO and had its OpenStack-specific kube-system ServiceAccount defined in manifests/. This commit attempts to clean up this situation by moving these manifests to pkg/cloud/openstack/assets

@openshift-ci openshift-ci bot requested review from mandre and vincepri April 11, 2024 14:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dulek
Copy link
Contributor Author

dulek commented Apr 11, 2024

/hold

Okay, this doesn't seem to be the way forward due to #193 and I have no idea why.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 22, 2024

/hold cancel

Okay, this is now aligned to how other cloud providers do it.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 22, 2024

@stephenfin, @gryf: You might want to take a look here.

@dulek
OpenStack: Cleanup ServiceAccount
d59800a 
For an unknown reason OpenStack was different in CCCMO and had its
OpenStack-specific `kube-system` ServiceAccount defined in manifests/.
This commit attempts to clean up this situation by moving these
manifests to pkg/cloud/openstack/assets.
@dulek
Copy link
Contributor Author

dulek commented Apr 23, 2024

/test lint

Looks like a timeout.

stephenfin
stephenfin reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@dulek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/level0-clusterinfra-azure-ipi-proxy-tests d59800a link false /test level0-clusterinfra-azure-ipi-proxy-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenfin stephenfin stephenfin left review comments

@mandre mandre Awaiting requested review from mandre

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@stephenfin stephenfin

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dulek @stephenfin