Bug 1701422: use port 443 for registry service #259

adambkaplan · 2019-04-22T18:31:03Z

Use the default HTTPS port for the internal registry service.
This lets us drop the port when referencing images on cluster.

adambkaplan · 2019-04-22T18:31:16Z

/assign @dmage

dmage · 2019-04-23T12:55:40Z

pkg/operator/controller.go

@@ -66,6 +66,10 @@ func NewController(kubeconfig *restclient.Config) (*Controller, error) {

 	p := parameters.Globals{}

+	p.Service.Name = imageregistryv1.ImageRegistryName
+	p.Service.Port = 443


Having this as a parameter may give wrong feeling that this a parameter that can be changed. But at the same time we have fmt.Sprintf("%s.%s.svc", svc.Name, svc.Namespace) that makes this value impossible to change without additional modifications. It worth mention that we rely on the fact that this port is the default port Docker.

I can drop this (in which case I can drop the TargetPort as well, since that should be the port on the container)

Use the default HTTPS port for the internal registry service. This lets us drop the port when referencing images on cluster.

adambkaplan · 2019-04-23T13:29:04Z

test/framework/imageregistry.go

+			return false, fmt.Errorf("expected internal registry hostname %s; got %s",
+				"image-registry.openshift-image-registry.svc",
+				cfg.Status.InternalRegistryHostname)
+		}


Fail fast if the internal registry host name doesn't match what we expect.

dmage · 2019-04-23T13:57:02Z

/lgtm

openshift-ci-robot · 2019-04-23T13:57:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan,dmage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-04-23T15:47:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-23T20:45:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T00:31:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T01:17:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T01:43:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T02:22:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T10:24:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-24T11:16:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pweil- · 2019-04-24T11:42:37Z

/retest

openshift-bot · 2019-04-24T14:21:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

adambkaplan · 2019-04-24T14:30:43Z

/hold

Not clear why we are consistently failing

dmage · 2019-04-25T11:52:59Z

/retest

dmage · 2019-04-25T12:25:15Z

/retest

adambkaplan · 2019-04-26T15:59:02Z

/hold cancel

adambkaplan · 2019-04-26T15:59:09Z

/retest

adambkaplan · 2019-04-26T17:40:17Z

got past the auth issue, now seeing a service name collision on imagestream tag import:

STEP: trying to tag a docker image below limit map[openshift.io/image-tags:{{0 0} {<nil>} 0 DecimalSI}]
Apr 26 16:44:41.848: INFO: Running 'oc import-image --config=/tmp/configfile546157238 --namespace=e2e-test-limitrange-admission-ls5dk stream:dockerimage --confirm --insecure --from image-registry.openshift-image-registry.svc:5000/e2e-test-limitrange-admission-ls5dk/src@sha256:90adb61c4cefbfc6de612caff4c5d964bba789cc3244ccc50cdd3603041ef9d0'
error: tag  failed: Internal error occurred: Get http://image-registry.openshift-image-registry.svc:5000/v2/: dial tcp 172.30.138.105:5000: connect: no route to host
imagestream.image.openshift.io/stream imported with errors

Name:			stream
Namespace:		e2e-test-limitrange-admission-ls5dk
Created:		Less than a second ago
Labels:			<none>
Annotations:		openshift.io/image.dockerRepositoryCheck=2019-04-26T16:44:47Z
Image Repository:	image-registry.openshift-image-registry.svc/e2e-test-limitrange-admission-ls5dk/stream
Image Lookup:		local=false
Unique Images:		0
Tags:			1

dockerimage
  tagged from image-registry.openshift-image-registry.svc:5000/e2e-test-limitrange-admission-ls5dk/src@sha256:90adb61c4cefbfc6de612caff4c5d964bba789cc3244ccc50cdd3603041ef9d0
    will use insecure HTTPS or HTTP connections

  ! error: Import failed (InternalError): Internal error occurred: Get http://image-registry.openshift-image-registry.svc:5000/v2/: dial tcp 172.30.138.105:5000: connect: no route to host
      Less than a second ago
STEP: waiting for an is importer to import a tag dockerimage into a stream stream

openshift-bot · 2019-04-26T20:30:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-26T22:29:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T00:24:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T02:34:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T03:39:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T03:52:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T04:44:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T05:30:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T05:56:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-27T07:01:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

adambkaplan · 2019-04-27T07:38:21Z

/hold

openshift-ci-robot · 2019-04-30T04:27:43Z

@adambkaplan: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`c5ea07c`	link	`/test e2e-aws`
ci/prow/e2e-aws-image-registry	`c5ea07c`	link	`/test e2e-aws-image-registry`
ci/prow/e2e-aws-upgrade	`c5ea07c`	link	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adambkaplan · 2019-05-03T13:02:42Z

Per thread in aos-devel, we don't plan on landing this until 4.2

openshift-ci-robot · 2019-05-11T02:47:48Z

@adambkaplan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2019-07-17T19:21:39Z

/close

Replaced by #322

openshift-ci-robot · 2019-07-17T19:21:41Z

@adambkaplan: Closed this PR.

In response to this:

/close

Replaced by #322

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from coreydaley and dmage April 22, 2019 18:31

openshift-ci-robot assigned dmage Apr 22, 2019

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2019

dmage reviewed Apr 23, 2019

View reviewed changes

adambkaplan force-pushed the drop-svc-port branch from a027a6a to c5ea07c Compare April 23, 2019 13:26

Bug 1701422: use port 443 for registry service

c5ea07c

Use the default HTTPS port for the internal registry service. This lets us drop the port when referencing images on cluster.

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2019

adambkaplan commented Apr 23, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019

adambkaplan mentioned this pull request Apr 24, 2019

Bug 1701422: registry auth without port number openshift/origin#22659

Merged

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2019

adambkaplan mentioned this pull request Apr 29, 2019

Bug 1702743: Wait for internal registry hostname to be published before running e2e tests openshift/origin#22705

Merged

lberk mentioned this pull request May 1, 2019

Update references to internal registry openshift-cloud-functions/demos#38

Open

wewang58 mentioned this pull request May 5, 2019

Enable tests since bug 1702743 was fixed openshift/origin#22779

Closed

dmage added this to the 4.2 milestone May 6, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2019

openshift-ci-robot closed this Jul 17, 2019

Bug 1701422: use port 443 for registry service #259

Bug 1701422: use port 443 for registry service #259

Conversation

adambkaplan commented Apr 22, 2019

adambkaplan commented Apr 22, 2019

dmage Apr 23, 2019

Choose a reason for hiding this comment

adambkaplan Apr 23, 2019

Choose a reason for hiding this comment

adambkaplan Apr 23, 2019

Choose a reason for hiding this comment

dmage commented Apr 23, 2019

openshift-ci-robot commented Apr 23, 2019

openshift-bot commented Apr 23, 2019

openshift-bot commented Apr 23, 2019

openshift-bot commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

pweil- commented Apr 24, 2019

openshift-bot commented Apr 24, 2019

adambkaplan commented Apr 24, 2019

dmage commented Apr 25, 2019

dmage commented Apr 25, 2019

adambkaplan commented Apr 26, 2019

adambkaplan commented Apr 26, 2019

adambkaplan commented Apr 26, 2019

openshift-bot commented Apr 26, 2019

openshift-bot commented Apr 26, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

openshift-bot commented Apr 27, 2019

adambkaplan commented Apr 27, 2019

openshift-ci-robot commented Apr 30, 2019

adambkaplan commented May 3, 2019

openshift-ci-robot commented May 11, 2019

adambkaplan commented Jul 17, 2019

openshift-ci-robot commented Jul 17, 2019