Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1701422: registry auth without port number #22659

Merged

Conversation

adambkaplan
Copy link
Contributor

If the registry service uses HTTP/S default ports, allow auth to drop
the port number.
This is a hack until DEVEXP-190 is implemented.

If the registry service uses HTTP/S default ports, allow auth to drop
the port number.
This is a hack until DEVEXP-190 is implemented.
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2019
@adambkaplan
Copy link
Contributor Author

@bparees
Copy link
Contributor

bparees commented Apr 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@dmage
Copy link
Contributor

dmage commented Apr 25, 2019

haproxy, storage, ...
/retest

@adambkaplan
Copy link
Contributor Author

/retest

@adambkaplan
Copy link
Contributor Author

/retest

update flake with ocm-o.

@openshift-merge-robot openshift-merge-robot merged commit c47c189 into openshift:master Apr 26, 2019
@adambkaplan adambkaplan deleted the fix-registry-auth branch May 2, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants