NE-1183: Rename unit tests for specific functions #880

gcs278 · 2023-01-27T20:17:52Z

For each unit test "TestFoo" that specifically tests a function name "Foo"
or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively.

pkg/dns/alibaba/dns_test.go (TestGetRR): Rename from this...
(Test_getRR): ...to this.
(TestParseZone): Rename from this...
(Test_parseZone): ...to this.
pkg/dns/alibaba/util/numbers_test.go (TestClamp): Rename from this...
(Test_Clamp): ...to this.
pkg/dns/aws/dns_test.go (TestZoneMatchesTags): Rename from this...
(Test_zoneMatchesTags): ...to this.
(TestZoneIDFromResource): Rename from this...
(Test_zoneIDFromResource): ...to this.
pkg/dns/azure/dns_test.go (TestEnsureDNS): Rename from this...
(Test_Ensure): ...to this.
(TestDeleteDNS): Rename from this...
(Test_Delete): ...to this.
pkg/dns/ibm/private/dnssvcs_provider_test.go (TestDelete): Rename from
this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.
pkg/dns/ibm/public/cis_provider_test.go (TestDelete): Rename from this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.
pkg/operator/controller/canary/controller_test.go
(TestCycleServicePort): Rename from this...
(Test_cycleServicePort): ...to this.
pkg/operator/controller/canary/daemonset_test.go
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.
pkg/operator/controller/canary/namespace_test.go
(TestCanaryNamespaceChanged): Rename from this...
(Test_canaryNamespaceChanged): ...to this.
pkg/operator/controller/canary/route_test.go (TestDesiredCanaryRoute):
Rename from this...
(Test_desiredCanaryRoute): ...to this.
(TestCanaryRouteChanged): Rename from this...
(Test_canaryRouteChanged): ...to this.
pkg/operator/controller/canary/service_test.go
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.
pkg/operator/controller/certificate-publisher/publish_certs_test.go
(TestDesiredRouterCertsGlobalSecret): Rename from this...
(Test_desiredRouterCertsGlobalSecret): ...to this.
pkg/operator/controller/certificate/default_cert_test.go
(TestDesiredRouterDefaultCertificateSecret): Rename from this...
(Test_desiredRouterDefaultCertificateSecret): ...to this.
pkg/operator/controller/dns/controller_test.go
(TestPublishRecordToZones): Rename from this...
(Test_publishRecordToZones): ...to this.
(TestMigrateDNSRecordStatus): Rename from this...
(Test_migrateRecordStatusConditions): ...to this.
(TestDnsZoneStatusSlicesEqual): Rename from this...
(Test_dnsZoneStatusSlicesEqual): ...to this.
(TestRecordIsAlreadyPublishedToZone): Rename from this...
(Test_recordIsAlreadyPublishedToZone): ...to this.
(TestCustomCABundle): Rename from this...
(Test_customCABundle): ...to this.
pkg/operator/controller/ingress/controller_test.go
(TestSetDefaultDomain): Rename from this...
(Test_setDefaultDomain): ...to this.
(TestTLSProfileSpecForSecurityProfile): Rename from this...
(Test_tlsProfileSpecForSecurityProfile): ...to this.
(TestTLSProfileSpecForIngressController): Rename from this...
(Test_tlsProfileSpecForIngressController): ...to this.
(TestValidateHTTPHeaderBufferValues): Rename from this...
(Test_validateHTTPHeaderBufferValues): ...to this.
(TestValidateClientTLS): Rename from this...
(Test_validateClientTLS): ...to this.
(TestIsProxyProtocolNeeded): Rename from this...
(Test_IsProxyProtocolNeeded): ...to this.
pkg/operator/controller/ingress/deployment_test.go
(TestDesiredRouterDeployment): Rename from this...
(Test_desiredRouterDeployment): ...to this.
(TestInferTLSProfileSpecFromDeployment): Rename from this...
(Test_inferTLSProfileSpecFromDeployment): ...to this.
(TestDeploymentConfigChanged): Rename from this...
(Test_deploymentConfigChanged): ...to this.
(TestDurationToHAProxyTimespec): Rename from this...
(Test_durationToHAProxyTimespec): ...to this.
(TestCapReloadIntervalValue): Rename from this...
(Test_capReloadIntervalValue): ...to this.
(TestGetMIMETypes): Rename from this...
(Test_GetMIMETypes): ...to this.
pkg/operator/controller/ingress/dns_test.go
(TestDesiredWildcardDNSRecord): Rename from this...
(Test_desiredWildcardDNSRecord): ...to this.
(TestManageDNSForDomain): Rename from this...
(Test_manageDNSForDomain): ...to this.
pkg/operator/controller/ingress/load_balancer_service_test.go
(TestDesiredLoadBalancerService): Rename from this...
(Test_desiredLoadBalancerService): ... to this.
(TestShouldUseLocalWithFallback): Rename from this...
(Test_shouldUseLocalWithFallback): ...to this.
(TestLoadBalancerServiceChanged): Rename from this...
(Test_loadBalancerServiceChanged): ...to this.
(TestLoadBalancerServiceAnnotationsChanged): Rename from this...
(Test_loadBalancerServiceAnnotationsChanged): ...to this.
(TestServiceIngressOwner): Rename from this...
(Test_isServiceOwnedByIngressController): ... to this.
pkg/operator/controller/ingress/metrics_test.go
(TestDeleteIngressControllerConditionsMetric): Rename from this...
(Test_DeleteIngressControllerConditionsMetric): ...to this.
(TestIngressControllerNLBMetric): Rename from this...
(Test_SetIngressControllerNLBMetric): ...to this.
pkg/operator/controller/ingress/monitoring_test.go
(TestServiceMonitorChanged): Rename from this...
(Test_serviceMonitorChanged): ...to this.
pkg/operator/controller/ingress/namespace_test.go
(TestRouterNamespaceChanged): Rename from this...
(Test_routerNamespaceChanged): ...to this.
pkg/operator/controller/ingress/nodeport_service_test.go
(TestDesiredNodePortService): Rename from this...
(Test_desiredNodePortService): ...to this.
(TestNodePortServiceChanged): Rename from this...
(Test_nodePortServiceChanged): ...to this.
pkg/operator/controller/ingress/poddisruptionbudget_test.go
(TestDesiredPodDisruptionBudget): Rename from this...
(Test_desiredRouterPodDisruptionBudget): ...to this.
(TestPodDisruptionBudgetChange): Rename from this...
(Test_podDisruptionBudgetChange): ...to this.
pkg/operator/controller/ingress/status_test.go
(TestComputePodsScheduledCondition): Rename from this...
(Test_computeDeploymentPodsScheduledCondition): ...to this.
(TestComputeIngressDegradedCondition): Rename from this...
(Test_computeIngressDegradedCondition): ...to this.
(TestComputeDeploymentRollingOutCondition): Rename from this...
(Test_computeDeploymentRollingOutCondition): ...to this.
(TestComputeLoadBalancerProgressingStatus): Rename from this...
(Test_computeLoadBalancerProgressingStatus): ...to this.
(TestComputeDeploymentAvailableCondition): Rename from this...
(Test_computeDeploymentAvailableCondition): ...to this.
(TestComputeDeploymentReplicasMinAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasMinAvailableCondition): ...to this.
(TestComputeDeploymentReplicasAllAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasAllAvailableCondition): ...to this.
(TestComputeLoadBalancerStatus): Rename from this...
(Test_computeLoadBalancerStatus): ...to this.
(TestComputeIngressProgressingCondition): Rename from this...
(Test_computeIngressProgressingCondition): ...to this.
(TestComputeIngressAvailableCondition): Rename from this...
(Test_computeIngressAvailableCondition): ...to this.
(TestIngressStatusesEqual): Rename from this...
(Test_ingressStatusesEqual): ...to this.
(TestComputeDNSStatus): Rename from this...
(Test_computeDNSStatus): ...to this.
(TestMergeConditions): Rename from this...
(Test_MergeConditions): ...to this.
(TestZoneInConfig): Rename from this...
(Test_checkZoneInConfig): ...to this.
(TestComputeIngressUpgradeableCondition): Rename from this...
(Test_computeIngressUpgradeableCondition): ...to this.
(TestComputeIngressEvaluationConditionsDetectedCondition): Rename from
this...
(Test_computeIngressEvaluationConditionsDetectedCondition): ...to this.
pkg/operator/controller/ingressclass/ingressclass_test.go
(TestDesiredIngressClass): Rename from this...
(Test_desiredIngressClass): ...to this.
(TestIngressClassChanged): Rename from this...
(Test_ingressClassChanged): ...to this.
pkg/operator/controller/status/controller_test.go
(TestComputeOperatorProgressingCondition): Rename from this...
(Test_computeOperatorProgressingCondition): ...to this.
(TestOperatorStatusesEqual): Rename from this...
(Test_operatorStatusesEqual): ...to this.
(TestComputeOperatorStatusVersions): Rename from this...
(Test_computeOperatorStatusVersions): ...to this.
(TestComputeOperatorUpgradeableCondition): Rename from this...
(Test_computeOperatorUpgradeableCondition): ...to this.
pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
(TestDesiredHttpErrorCodeConfigMap): Rename from this...
(Test_desiredHttpErrorCodeConfigMap): ...to this.
pkg/util/aws/shared_credentials_file_test.go
(TestSharedCredentialsFileFromSecret): Rename from this...
(Test_SharedCredentialsFileFromSecret): ...to this.
pkg/util/hash_test.go (TestHash): Rename from this...
(Test_Hash): ...to this.
pkg/util/network_test.go (TestURI): Rename from this...
(Test_URI): ...to this.
pkg/dns/gcp/provider_test.go: (TestParseZone): Rename from this...
(Test_ParseZone): ...to this.

openshift-ci-robot · 2023-01-27T20:17:56Z

@gcs278: This pull request references NE-1183 which is a valid jira issue.

In response to this:

For each unit test "TestFoo" that specifically tests a function name "Foo" or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively.

pkg/dns/alibaba/dns_test.go (TestGetRR): Rename from this... (Test_getRR): ...to this.
(TestParseZone): Rename from this...
(Test_parseZone): ...to this.

pkg/dns/alibaba/util/numbers_test.go (TestClamp): Rename from this... (Test_Clamp): ...to this.

pkg/dns/aws/dns_test.go (TestZoneMatchesTags): Rename from this... (Test_zoneMatchesTags): ...to this.
(TestZoneIDFromResource): Rename from this...
(Test_zoneIDFromResource): ...to this.

pkg/dns/azure/dns_test.go (TestEnsureDNS): Rename from this... (Test_Ensure): ...to this.
(TestDeleteDNS): Rename from this...
(Test_Delete): ...to this.

pkg/dns/ibm/private/dnssvcs_provider_test.go (TestDelete): Rename from this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.

pkg/dns/ibm/public/cis_provider_test.go (TestDelete): Rename from this... (Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.

pkg/operator/controller/canary/controller_test.go (TestCycleServicePort): Rename from this...
(Test_cycleServicePort): ...to this.

pkg/operator/controller/canary/daemonset_test.go (TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.

pkg/operator/controller/canary/namespace_test.go (TestCanaryNamespaceChanged): Rename from this...
(Test_canaryNamespaceChanged): ...to this.

pkg/operator/controller/canary/route_test.go (TestDesiredCanaryRoute): Rename from this...
(Test_desiredCanaryRoute): ...to this.
(TestCanaryRouteChanged): Rename from this...
(Test_canaryRouteChanged): ...to this.

pkg/operator/controller/canary/service_test.go (TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.

pkg/operator/controller/certificate-publisher/publish_certs_test.go (TestDesiredRouterCertsGlobalSecret): Rename from this... (Test_desiredRouterCertsGlobalSecret): ...to this.

pkg/operator/controller/certificate/default_cert_test.go (TestDesiredRouterDefaultCertificateSecret): Rename from this... (Test_desiredRouterDefaultCertificateSecret): ...to this.

pkg/operator/controller/dns/controller_test.go (TestPublishRecordToZones): Rename from this...
(Test_publishRecordToZones): ...to this.
(TestMigrateDNSRecordStatus): Rename from this...
(Test_migrateRecordStatusConditions): ...to this.
(TestDnsZoneStatusSlicesEqual): Rename from this... (Test_dnsZoneStatusSlicesEqual): ...to this.
(TestRecordIsAlreadyPublishedToZone): Rename from this... (Test_recordIsAlreadyPublishedToZone): ...to this. (TestCustomCABundle): Rename from this...
(Test_customCABundle): ...to this.

pkg/operator/controller/ingress/controller_test.go (TestSetDefaultDomain): Rename from this...
(Test_setDefaultDomain): ...to this.
(TestTLSProfileSpecForSecurityProfile): Rename from this... (Test_tlsProfileSpecForSecurityProfile): ...to this. (TestTLSProfileSpecForIngressController): Rename from this... (Test_tlsProfileSpecForIngressController): ...to this. (TestValidateHTTPHeaderBufferValues): Rename from this... (Test_validateHTTPHeaderBufferValues): ...to this. (TestValidateClientTLS): Rename from this...
(Test_validateClientTLS): ...to this.
(TestIsProxyProtocolNeeded): Rename from this...
(Test_IsProxyProtocolNeeded): ...to this.

pkg/operator/controller/ingress/deployment_test.go (TestDesiredRouterDeployment): Rename from this... (Test_desiredRouterDeployment): ...to this.
(TestInferTLSProfileSpecFromDeployment): Rename from this... (Test_inferTLSProfileSpecFromDeployment): ...to this. (TestDeploymentConfigChanged): Rename from this... (Test_deploymentConfigChanged): ...to this.
(TestDurationToHAProxyTimespec): Rename from this... (Test_durationToHAProxyTimespec): ...to this.
(TestCapReloadIntervalValue): Rename from this...
(Test_capReloadIntervalValue): ...to this.
(TestGetMIMETypes): Rename from this...
(Test_GetMIMETypes): ...to this.

pkg/operator/controller/ingress/dns_test.go (TestDesiredWildcardDNSRecord): Rename from this... (Test_desiredWildcardDNSRecord): ...to this.
(TestManageDNSForDomain): Rename from this...
(Test_manageDNSForDomain): ...to this.

pkg/operator/controller/ingress/load_balancer_service_test.go (TestDesiredLoadBalancerService): Rename from this... (Test_desiredLoadBalancerService): ... to this.
(TestShouldUseLocalWithFallback): Rename from this... (Test_shouldUseLocalWithFallback): ...to this.
(TestLoadBalancerServiceChanged): Rename from this... (Test_loadBalancerServiceChanged): ...to this.
(TestLoadBalancerServiceAnnotationsChanged): Rename from this... (Test_loadBalancerServiceAnnotationsChanged): ...to this. (TestServiceIngressOwner): Rename from this...
(Test_isServiceOwnedByIngressController): ... to this.

pkg/operator/controller/ingress/metrics_test.go (TestDeleteIngressControllerConditionsMetric): Rename from this... (Test_DeleteIngressControllerConditionsMetric): ...to this. (TestIngressControllerNLBMetric): Rename from this... (Test_SetIngressControllerNLBMetric): ...to this.

pkg/operator/controller/ingress/monitoring_test.go (TestServiceMonitorChanged): Rename from this...
(Test_serviceMonitorChanged): ...to this.

pkg/operator/controller/ingress/namespace_test.go (TestRouterNamespaceChanged): Rename from this...
(Test_routerNamespaceChanged): ...to this.

pkg/operator/controller/ingress/nodeport_service_test.go (TestDesiredNodePortService): Rename from this...
(Test_desiredNodePortService): ...to this.
(TestNodePortServiceChanged): Rename from this...
(Test_nodePortServiceChanged): ...to this.

pkg/operator/controller/ingress/poddisruptionbudget_test.go (TestDesiredPodDisruptionBudget): Rename from this... (Test_desiredRouterPodDisruptionBudget): ...to this.

pkg/operator/controller/ingress/status_test.go (TestComputePodsScheduledCondition): Rename from this... (Test_computeDeploymentPodsScheduledCondition): ...to this. (TestComputeIngressDegradedCondition): Rename from this... (Test_computeIngressDegradedCondition): ...to this. (TestComputeDeploymentRollingOutCondition): Rename from this... (Test_computeDeploymentRollingOutCondition): ...to this. (TestComputeLoadBalancerProgressingStatus): Rename from this... (Test_computeLoadBalancerProgressingStatus): ...to this. (TestComputeDeploymentAvailableCondition): Rename from this... (Test_computeDeploymentAvailableCondition): ...to this. (TestComputeDeploymentReplicasMinAvailableCondition): Rename from this... (Test_computeDeploymentReplicasMinAvailableCondition): ...to this. (TestComputeDeploymentReplicasAllAvailableCondition): Rename from this... (Test_computeDeploymentReplicasAllAvailableCondition): ...to this. (TestComputeLoadBalancerStatus): Rename from this... (Test_computeLoadBalancerStatus): ...to this.
(TestComputeIngressProgressingCondition): Rename from this... (Test_computeIngressProgressingCondition): ...to this. (TestComputeIngressAvailableCondition): Rename from this... (Test_computeIngressAvailableCondition): ...to this. (TestIngressStatusesEqual): Rename from this...
(Test_ingressStatusesEqual): ...to this.
(TestComputeDNSStatus): Rename from this...
(Test_computeDNSStatus): ...to this.
(TestMergeConditions): Rename from this...
(Test_MergeConditions): ...to this.
(TestZoneInConfig): Rename from this...
(Test_checkZoneInConfig): ...to this.
(TestComputeIngressUpgradeableCondition): Rename from this... (Test_computeIngressUpgradeableCondition): ...to this. (TestComputeIngressEvaluationConditionsDetectedCondition): Rename from this...
(Test_computeIngressEvaluationConditionsDetectedCondition): ...to this.

pkg/operator/controller/ingressclass/ingressclass_test.go (TestDesiredIngressClass): Rename from this...
(Test_desiredIngressClass): ...to this.
(TestIngressClassChanged): Rename from this...
(Test_ingressClassChanged): ...to this.

pkg/operator/controller/status/controller_test.go (TestComputeOperatorProgressingCondition): Rename from this... (Test_computeOperatorProgressingCondition): ...to this. (TestOperatorStatusesEqual): Rename from this...
(Test_operatorStatusesEqual): ...to this.
(TestComputeOperatorStatusVersions): Rename from this... (Test_computeOperatorStatusVersions): ...to this.
(TestComputeOperatorUpgradeableCondition): Rename from this... (Test_computeOperatorUpgradeableCondition): ...to this.

pkg/operator/controller/sync-http-error-code-configmap/controller_test.go (TestDesiredHttpErrorCodeConfigMap): Rename from this... (Test_desiredHttpErrorCodeConfigMap): ...to this.

pkg/util/aws/shared_credentials_file_test.go
(TestSharedCredentialsFileFromSecret): Rename from this...
(Test_SharedCredentialsFileFromSecret): ...to this.

pkg/util/hash_test.go (TestHash): Rename from this...
(Test_Hash): ...to this.

pkg/util/network_test.go (TestURI): Rename from this...
(Test_URI): ...to this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-01-30T19:38:36Z

/retest-required

gcs278 · 2023-01-31T15:19:49Z

/retest-required

gcs278 · 2023-02-22T17:20:24Z

@Miciah rebased

Miciah · 2023-03-07T19:48:53Z

/approve
/lgtm

This is just renaming unit tests; no docs, PX, or QE required.
/label docs-approved
/label px-approved
/label qe-approved

/retest
since #881 merged.

openshift-ci · 2023-03-07T19:49:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-03-07T21:54:41Z

/retest-required

Remaining retests: 0 against base HEAD a29464e and 2 for PR HEAD 870c158 in total

Miciah · 2023-03-09T03:16:55Z

TestClientTLS failed.
/retest-required

Miciah · 2023-03-13T14:55:11Z

TestAllowedSourceRanges, TestClientTLS, and TestRouterCompressionOperation failed.
/retest-required

gcs278 · 2023-03-14T19:08:58Z

TestManagedDNSToUnmanagedDNSIngressController, TestClientTLS failed
/retest-required

openshift-ci-robot · 2023-03-20T18:44:29Z

/retest-required

Remaining retests: 0 against base HEAD a29464e and 2 for PR HEAD 870c158 in total

gcs278 · 2023-03-22T14:45:34Z

TestRouteMetricsControllerOnlyRouteSelector failed
/retest-required

gcs278 · 2023-04-05T15:25:34Z

e2e-azure-operator-ipi-deprovision-deprovision failure
/retest-required

gcs278 · 2023-04-06T13:30:16Z

e2e-azure-operator: TestClientTLS failed
/retest-required

gcs278 · 2023-04-07T14:38:31Z

Must gather failure
/test e2e-azure-operator

gcs278 · 2023-04-14T10:23:12Z

TestIngressControllerRouteSelectorUpdateShouldClearRouteStatus Failure, due to a common retry conflict issue for updating a ingress controller.
/test e2e-azure-operator

openshift-ci-robot · 2023-06-19T08:36:03Z

/retest-required

Remaining retests: 0 against base HEAD b1a6bb5 and 2 for PR HEAD 870c158 in total

openshift-ci-robot · 2023-07-19T17:34:36Z

@gcs278: This pull request references NE-1183 which is a valid jira issue.

In response to this:

For each unit test "TestFoo" that specifically tests a function name "Foo"
or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively.

pkg/dns/alibaba/dns_test.go (TestGetRR): Rename from this...
(Test_getRR): ...to this.
(TestParseZone): Rename from this...
(Test_parseZone): ...to this.

pkg/dns/alibaba/util/numbers_test.go (TestClamp): Rename from this...
(Test_Clamp): ...to this.

pkg/dns/aws/dns_test.go (TestZoneMatchesTags): Rename from this...
(Test_zoneMatchesTags): ...to this.
(TestZoneIDFromResource): Rename from this...
(Test_zoneIDFromResource): ...to this.

pkg/dns/azure/dns_test.go (TestEnsureDNS): Rename from this...
(Test_Ensure): ...to this.
(TestDeleteDNS): Rename from this...
(Test_Delete): ...to this.

pkg/dns/ibm/private/dnssvcs_provider_test.go (TestDelete): Rename from
this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.

pkg/dns/ibm/public/cis_provider_test.go (TestDelete): Rename from this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.

pkg/operator/controller/canary/controller_test.go
(TestCycleServicePort): Rename from this...
(Test_cycleServicePort): ...to this.

pkg/operator/controller/canary/daemonset_test.go
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.

pkg/operator/controller/canary/namespace_test.go
(TestCanaryNamespaceChanged): Rename from this...
(Test_canaryNamespaceChanged): ...to this.

pkg/operator/controller/canary/route_test.go (TestDesiredCanaryRoute):
Rename from this...
(Test_desiredCanaryRoute): ...to this.
(TestCanaryRouteChanged): Rename from this...
(Test_canaryRouteChanged): ...to this.

pkg/operator/controller/canary/service_test.go
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.

pkg/operator/controller/certificate-publisher/publish_certs_test.go
(TestDesiredRouterCertsGlobalSecret): Rename from this...
(Test_desiredRouterCertsGlobalSecret): ...to this.

pkg/operator/controller/certificate/default_cert_test.go
(TestDesiredRouterDefaultCertificateSecret): Rename from this...
(Test_desiredRouterDefaultCertificateSecret): ...to this.

pkg/operator/controller/dns/controller_test.go
(TestPublishRecordToZones): Rename from this...
(Test_publishRecordToZones): ...to this.
(TestMigrateDNSRecordStatus): Rename from this...
(Test_migrateRecordStatusConditions): ...to this.
(TestDnsZoneStatusSlicesEqual): Rename from this...
(Test_dnsZoneStatusSlicesEqual): ...to this.
(TestRecordIsAlreadyPublishedToZone): Rename from this...
(Test_recordIsAlreadyPublishedToZone): ...to this.
(TestCustomCABundle): Rename from this...
(Test_customCABundle): ...to this.

pkg/operator/controller/ingress/controller_test.go
(TestSetDefaultDomain): Rename from this...
(Test_setDefaultDomain): ...to this.
(TestTLSProfileSpecForSecurityProfile): Rename from this...
(Test_tlsProfileSpecForSecurityProfile): ...to this.
(TestTLSProfileSpecForIngressController): Rename from this...
(Test_tlsProfileSpecForIngressController): ...to this.
(TestValidateHTTPHeaderBufferValues): Rename from this...
(Test_validateHTTPHeaderBufferValues): ...to this.
(TestValidateClientTLS): Rename from this...
(Test_validateClientTLS): ...to this.
(TestIsProxyProtocolNeeded): Rename from this...
(Test_IsProxyProtocolNeeded): ...to this.

pkg/operator/controller/ingress/deployment_test.go
(TestDesiredRouterDeployment): Rename from this...
(Test_desiredRouterDeployment): ...to this.
(TestInferTLSProfileSpecFromDeployment): Rename from this...
(Test_inferTLSProfileSpecFromDeployment): ...to this.
(TestDeploymentConfigChanged): Rename from this...
(Test_deploymentConfigChanged): ...to this.
(TestDurationToHAProxyTimespec): Rename from this...
(Test_durationToHAProxyTimespec): ...to this.
(TestCapReloadIntervalValue): Rename from this...
(Test_capReloadIntervalValue): ...to this.
(TestGetMIMETypes): Rename from this...
(Test_GetMIMETypes): ...to this.

pkg/operator/controller/ingress/dns_test.go
(TestDesiredWildcardDNSRecord): Rename from this...
(Test_desiredWildcardDNSRecord): ...to this.
(TestManageDNSForDomain): Rename from this...
(Test_manageDNSForDomain): ...to this.

pkg/operator/controller/ingress/load_balancer_service_test.go
(TestDesiredLoadBalancerService): Rename from this...
(Test_desiredLoadBalancerService): ... to this.
(TestShouldUseLocalWithFallback): Rename from this...
(Test_shouldUseLocalWithFallback): ...to this.
(TestLoadBalancerServiceChanged): Rename from this...
(Test_loadBalancerServiceChanged): ...to this.
(TestLoadBalancerServiceAnnotationsChanged): Rename from this...
(Test_loadBalancerServiceAnnotationsChanged): ...to this.
(TestServiceIngressOwner): Rename from this...
(Test_isServiceOwnedByIngressController): ... to this.

pkg/operator/controller/ingress/metrics_test.go
(TestDeleteIngressControllerConditionsMetric): Rename from this...
(Test_DeleteIngressControllerConditionsMetric): ...to this.
(TestIngressControllerNLBMetric): Rename from this...
(Test_SetIngressControllerNLBMetric): ...to this.

pkg/operator/controller/ingress/monitoring_test.go
(TestServiceMonitorChanged): Rename from this...
(Test_serviceMonitorChanged): ...to this.

pkg/operator/controller/ingress/namespace_test.go
(TestRouterNamespaceChanged): Rename from this...
(Test_routerNamespaceChanged): ...to this.

pkg/operator/controller/ingress/nodeport_service_test.go
(TestDesiredNodePortService): Rename from this...
(Test_desiredNodePortService): ...to this.
(TestNodePortServiceChanged): Rename from this...
(Test_nodePortServiceChanged): ...to this.

pkg/operator/controller/ingress/poddisruptionbudget_test.go
(TestDesiredPodDisruptionBudget): Rename from this...
(Test_desiredRouterPodDisruptionBudget): ...to this.
(TestPodDisruptionBudgetChange): Rename from this...
(Test_podDisruptionBudgetChange): ...to this.

pkg/operator/controller/ingress/status_test.go
(TestComputePodsScheduledCondition): Rename from this...
(Test_computeDeploymentPodsScheduledCondition): ...to this.
(TestComputeIngressDegradedCondition): Rename from this...
(Test_computeIngressDegradedCondition): ...to this.
(TestComputeDeploymentRollingOutCondition): Rename from this...
(Test_computeDeploymentRollingOutCondition): ...to this.
(TestComputeLoadBalancerProgressingStatus): Rename from this...
(Test_computeLoadBalancerProgressingStatus): ...to this.
(TestComputeDeploymentAvailableCondition): Rename from this...
(Test_computeDeploymentAvailableCondition): ...to this.
(TestComputeDeploymentReplicasMinAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasMinAvailableCondition): ...to this.
(TestComputeDeploymentReplicasAllAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasAllAvailableCondition): ...to this.
(TestComputeLoadBalancerStatus): Rename from this...
(Test_computeLoadBalancerStatus): ...to this.
(TestComputeIngressProgressingCondition): Rename from this...
(Test_computeIngressProgressingCondition): ...to this.
(TestComputeIngressAvailableCondition): Rename from this...
(Test_computeIngressAvailableCondition): ...to this.
(TestIngressStatusesEqual): Rename from this...
(Test_ingressStatusesEqual): ...to this.
(TestComputeDNSStatus): Rename from this...
(Test_computeDNSStatus): ...to this.
(TestMergeConditions): Rename from this...
(Test_MergeConditions): ...to this.
(TestZoneInConfig): Rename from this...
(Test_checkZoneInConfig): ...to this.
(TestComputeIngressUpgradeableCondition): Rename from this...
(Test_computeIngressUpgradeableCondition): ...to this.
(TestComputeIngressEvaluationConditionsDetectedCondition): Rename from
this...
(Test_computeIngressEvaluationConditionsDetectedCondition): ...to this.

pkg/operator/controller/ingressclass/ingressclass_test.go
(TestDesiredIngressClass): Rename from this...
(Test_desiredIngressClass): ...to this.
(TestIngressClassChanged): Rename from this...
(Test_ingressClassChanged): ...to this.

pkg/operator/controller/status/controller_test.go
(TestComputeOperatorProgressingCondition): Rename from this...
(Test_computeOperatorProgressingCondition): ...to this.
(TestOperatorStatusesEqual): Rename from this...
(Test_operatorStatusesEqual): ...to this.
(TestComputeOperatorStatusVersions): Rename from this...
(Test_computeOperatorStatusVersions): ...to this.
(TestComputeOperatorUpgradeableCondition): Rename from this...
(Test_computeOperatorUpgradeableCondition): ...to this.

pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
(TestDesiredHttpErrorCodeConfigMap): Rename from this...
(Test_desiredHttpErrorCodeConfigMap): ...to this.

pkg/util/aws/shared_credentials_file_test.go
(TestSharedCredentialsFileFromSecret): Rename from this...
(Test_SharedCredentialsFileFromSecret): ...to this.

pkg/util/hash_test.go (TestHash): Rename from this...
(Test_Hash): ...to this.

pkg/util/network_test.go (TestURI): Rename from this...
(Test_URI): ...to this.

pkg/dns/gcp/provider_test.go: (TestParseZone): Rename from this...
(Test_ParseZone): ...to this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-07-19T17:59:46Z

I noticed two errors in the commit message. First, #854 already renamed TestComputePodsScheduledCondition to Test_checkPodsScheduledForDeployment, so you can remove this from the commit message:

(TestComputePodsScheduledCondition): Rename from this...
(Test_computeDeploymentPodsScheduledCondition): ...to this.

Second, this is incorrect:

* pkg/operator/controller/canary/daemonset_test.go
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.

Change "Service" to "DaemonSet". Also, add TestCanaryDaemonsetChanged → Test_canaryDaemonsetChanged:

* pkg/operator/controller/canary/daemonset_test.go
(TestDesiredCanaryDaemonSet Rename from this...
(Test_desiredCanaryDaemonSet): ...to this.
(TestCanaryDaemonsetChanged Rename from this...
(Test_canaryDaemonsetChanged): ...to this.

(This one was probably my fault—sorry!)

For each unit test "TestFoo" that specifically tests a function name "Foo" or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively. * pkg/dns/alibaba/dns_test.go (TestGetRR): Rename from this... (Test_getRR): ...to this. (TestParseZone): Rename from this... (Test_parseZone): ...to this. * pkg/dns/alibaba/util/numbers_test.go (TestClamp): Rename from this... (Test_Clamp): ...to this. * pkg/dns/aws/dns_test.go (TestZoneMatchesTags): Rename from this... (Test_zoneMatchesTags): ...to this. (TestZoneIDFromResource): Rename from this... (Test_zoneIDFromResource): ...to this. * pkg/dns/azure/dns_test.go (TestEnsureDNS): Rename from this... (Test_Ensure): ...to this. (TestDeleteDNS): Rename from this... (Test_Delete): ...to this. * pkg/dns/ibm/private/dnssvcs_provider_test.go (TestDelete): Rename from this... (Test_Delete): ...to this. (TestCreateOrUpdate): Rename from this... (Test_createOrUpdateDNSRecord): ...to this. * pkg/dns/ibm/public/cis_provider_test.go (TestDelete): Rename from this... (Test_Delete): ...to this. (TestCreateOrUpdate): Rename from this... (Test_createOrUpdateDNSRecord): ...to this. * pkg/operator/controller/canary/controller_test.go (TestCycleServicePort): Rename from this... (Test_cycleServicePort): ...to this. * pkg/operator/controller/canary/daemonset_test.go (TestDesiredCanaryDaemonSet Rename from this... (Test_desiredCanaryDaemonSet): ...to this. (TestCanaryDaemonsetChanged Rename from this... (Test_canaryDaemonsetChanged): ...to this. * pkg/operator/controller/canary/namespace_test.go (TestCanaryNamespaceChanged): Rename from this... (Test_canaryNamespaceChanged): ...to this. * pkg/operator/controller/canary/route_test.go (TestDesiredCanaryRoute): Rename from this... (Test_desiredCanaryRoute): ...to this. (TestCanaryRouteChanged): Rename from this... (Test_canaryRouteChanged): ...to this. * pkg/operator/controller/canary/service_test.go (TestDesiredCanaryService): Rename from this... (Test_desiredCanaryService): ...to this. * pkg/operator/controller/certificate-publisher/publish_certs_test.go (TestDesiredRouterCertsGlobalSecret): Rename from this... (Test_desiredRouterCertsGlobalSecret): ...to this. * pkg/operator/controller/certificate/default_cert_test.go (TestDesiredRouterDefaultCertificateSecret): Rename from this... (Test_desiredRouterDefaultCertificateSecret): ...to this. * pkg/operator/controller/dns/controller_test.go (TestPublishRecordToZones): Rename from this... (Test_publishRecordToZones): ...to this. (TestMigrateDNSRecordStatus): Rename from this... (Test_migrateRecordStatusConditions): ...to this. (TestDnsZoneStatusSlicesEqual): Rename from this... (Test_dnsZoneStatusSlicesEqual): ...to this. (TestRecordIsAlreadyPublishedToZone): Rename from this... (Test_recordIsAlreadyPublishedToZone): ...to this. (TestCustomCABundle): Rename from this... (Test_customCABundle): ...to this. * pkg/operator/controller/ingress/controller_test.go (TestSetDefaultDomain): Rename from this... (Test_setDefaultDomain): ...to this. (TestTLSProfileSpecForSecurityProfile): Rename from this... (Test_tlsProfileSpecForSecurityProfile): ...to this. (TestTLSProfileSpecForIngressController): Rename from this... (Test_tlsProfileSpecForIngressController): ...to this. (TestValidateHTTPHeaderBufferValues): Rename from this... (Test_validateHTTPHeaderBufferValues): ...to this. (TestValidateClientTLS): Rename from this... (Test_validateClientTLS): ...to this. (TestIsProxyProtocolNeeded): Rename from this... (Test_IsProxyProtocolNeeded): ...to this. * pkg/operator/controller/ingress/deployment_test.go (TestDesiredRouterDeployment): Rename from this... (Test_desiredRouterDeployment): ...to this. (TestInferTLSProfileSpecFromDeployment): Rename from this... (Test_inferTLSProfileSpecFromDeployment): ...to this. (TestDeploymentConfigChanged): Rename from this... (Test_deploymentConfigChanged): ...to this. (TestDurationToHAProxyTimespec): Rename from this... (Test_durationToHAProxyTimespec): ...to this. (TestCapReloadIntervalValue): Rename from this... (Test_capReloadIntervalValue): ...to this. (TestGetMIMETypes): Rename from this... (Test_GetMIMETypes): ...to this. * pkg/operator/controller/ingress/dns_test.go (TestDesiredWildcardDNSRecord): Rename from this... (Test_desiredWildcardDNSRecord): ...to this. (TestManageDNSForDomain): Rename from this... (Test_manageDNSForDomain): ...to this. * pkg/operator/controller/ingress/load_balancer_service_test.go (TestDesiredLoadBalancerService): Rename from this... (Test_desiredLoadBalancerService): ... to this. (TestShouldUseLocalWithFallback): Rename from this... (Test_shouldUseLocalWithFallback): ...to this. (TestLoadBalancerServiceChanged): Rename from this... (Test_loadBalancerServiceChanged): ...to this. (TestLoadBalancerServiceAnnotationsChanged): Rename from this... (Test_loadBalancerServiceAnnotationsChanged): ...to this. (TestServiceIngressOwner): Rename from this... (Test_isServiceOwnedByIngressController): ... to this. * pkg/operator/controller/ingress/metrics_test.go (TestDeleteIngressControllerConditionsMetric): Rename from this... (Test_DeleteIngressControllerConditionsMetric): ...to this. (TestIngressControllerNLBMetric): Rename from this... (Test_SetIngressControllerNLBMetric): ...to this. * pkg/operator/controller/ingress/monitoring_test.go (TestServiceMonitorChanged): Rename from this... (Test_serviceMonitorChanged): ...to this. * pkg/operator/controller/ingress/namespace_test.go (TestRouterNamespaceChanged): Rename from this... (Test_routerNamespaceChanged): ...to this. * pkg/operator/controller/ingress/nodeport_service_test.go (TestDesiredNodePortService): Rename from this... (Test_desiredNodePortService): ...to this. (TestNodePortServiceChanged): Rename from this... (Test_nodePortServiceChanged): ...to this. * pkg/operator/controller/ingress/poddisruptionbudget_test.go (TestDesiredPodDisruptionBudget): Rename from this... (Test_desiredRouterPodDisruptionBudget): ...to this. (TestPodDisruptionBudgetChange): Rename from this... (Test_podDisruptionBudgetChange): ...to this. * pkg/operator/controller/ingress/status_test.go (TestComputeIngressDegradedCondition): Rename from this... (Test_computeIngressDegradedCondition): ...to this. (TestComputeDeploymentRollingOutCondition): Rename from this... (Test_computeDeploymentRollingOutCondition): ...to this. (TestComputeLoadBalancerProgressingStatus): Rename from this... (Test_computeLoadBalancerProgressingStatus): ...to this. (TestComputeDeploymentAvailableCondition): Rename from this... (Test_computeDeploymentAvailableCondition): ...to this. (TestComputeDeploymentReplicasMinAvailableCondition): Rename from this... (Test_computeDeploymentReplicasMinAvailableCondition): ...to this. (TestComputeDeploymentReplicasAllAvailableCondition): Rename from this... (Test_computeDeploymentReplicasAllAvailableCondition): ...to this. (TestComputeLoadBalancerStatus): Rename from this... (Test_computeLoadBalancerStatus): ...to this. (TestComputeIngressProgressingCondition): Rename from this... (Test_computeIngressProgressingCondition): ...to this. (TestComputeIngressAvailableCondition): Rename from this... (Test_computeIngressAvailableCondition): ...to this. (TestIngressStatusesEqual): Rename from this... (Test_ingressStatusesEqual): ...to this. (TestComputeDNSStatus): Rename from this... (Test_computeDNSStatus): ...to this. (TestMergeConditions): Rename from this... (Test_MergeConditions): ...to this. (TestZoneInConfig): Rename from this... (Test_checkZoneInConfig): ...to this. (TestComputeIngressUpgradeableCondition): Rename from this... (Test_computeIngressUpgradeableCondition): ...to this. (TestComputeIngressEvaluationConditionsDetectedCondition): Rename from this... (Test_computeIngressEvaluationConditionsDetectedCondition): ...to this. * pkg/operator/controller/ingressclass/ingressclass_test.go (TestDesiredIngressClass): Rename from this... (Test_desiredIngressClass): ...to this. (TestIngressClassChanged): Rename from this... (Test_ingressClassChanged): ...to this. * pkg/operator/controller/status/controller_test.go (TestComputeOperatorProgressingCondition): Rename from this... (Test_computeOperatorProgressingCondition): ...to this. (TestOperatorStatusesEqual): Rename from this... (Test_operatorStatusesEqual): ...to this. (TestComputeOperatorStatusVersions): Rename from this... (Test_computeOperatorStatusVersions): ...to this. (TestComputeOperatorUpgradeableCondition): Rename from this... (Test_computeOperatorUpgradeableCondition): ...to this. * pkg/operator/controller/sync-http-error-code-configmap/controller_test.go (TestDesiredHttpErrorCodeConfigMap): Rename from this... (Test_desiredHttpErrorCodeConfigMap): ...to this. * pkg/util/aws/shared_credentials_file_test.go (TestSharedCredentialsFileFromSecret): Rename from this... (Test_SharedCredentialsFileFromSecret): ...to this. * pkg/util/hash_test.go (TestHash): Rename from this... (Test_Hash): ...to this. * pkg/util/network_test.go (TestURI): Rename from this... (Test_URI): ...to this. * pkg/dns/gcp/provider_test.go: (TestParseZone): Rename from this... (Test_ParseZone): ...to this.

Miciah · 2023-07-19T19:24:59Z

Oops, missing close parenthesis here:

(TestCanaryDaemonsetChanged Rename from this...

But good enough. * grin *.
/lgtm

openshift-ci-robot · 2023-07-19T20:52:42Z

/retest-required

Remaining retests: 0 against base HEAD 80cfabf and 2 for PR HEAD 1c68273 in total

openshift-ci-robot · 2023-07-20T18:52:46Z

/retest-required

Remaining retests: 0 against base HEAD b4b5f42 and 1 for PR HEAD 1c68273 in total

Miciah · 2023-07-20T23:20:49Z

e2e-aws-ovn-serial failed because [sig-storage] PersistentVolumes-local Stress with local volumes [Serial] should be able to process many pods and reuse local volumes failed:

{  fail [test/e2e/storage/persistent_volumes-local.go:522]: persistentvolumes "local-pv2ttqt" not found
Error: exit with code 1
Ginkgo exit error 1: exit with code 1}

/test e2e-aws-ovn-serial

Miciah · 2023-07-21T00:49:20Z

e2e-aws-ovn-serial failed because AWS is full:

level=error msg=Error: creating EC2 Instance: InsufficientInstanceCapacity: We currently do not have sufficient m6a.xlarge capacity in the Availability Zone you requested (us-east-1d). Our system will be working on provisioning additional capacity. You can currently get m6a.xlarge capacity by not specifying an Availability Zone in your request or choosing us-east-1a, us-east-1b, us-east-1c, us-east-1f.

/test e2e-aws-ovn-serial

openshift-ci-robot · 2023-07-21T05:52:42Z

/retest-required

Remaining retests: 0 against base HEAD 21d27e5 and 0 for PR HEAD 1c68273 in total

openshift-ci-robot · 2023-07-21T06:52:36Z

/hold

Revision 1c68273 was retested 3 times: holding

Miciah · 2023-07-23T15:47:51Z

e2e-aws-ovn-serial failed because [bz-OLM][invariant] alert/KubePodNotReady should not be at or above info in ns/openshift-marketplace failed:

{  KubePodNotReady was at or above info for at least 9h57m44s on platformidentification.JobType{Release:"4.14", FromRelease:"", Platform:"aws", Architecture:"amd64", Network:"ovn", Topology:"ha"} (maxAllowed=0s): pending for 31m24s, firing for 9h57m44s:

Jul 21 04:11:21.486 - 4078s W alert/KubePodNotReady ns/openshift-marketplace pod/redhat-marketplace-pws4w ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="redhat-marketplace-pws4w", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-marketplace pod/certified-operators-dn4rs ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="certified-operators-dn4rs", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-marketplace pod/redhat-operators-mvfb5 ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="redhat-operators-mvfb5", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 5338s W alert/KubePodNotReady ns/openshift-marketplace pod/community-operators-hzcjh ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="community-operators-hzcjh", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:15:21.486 - 3898s W alert/KubePodNotReady ns/openshift-marketplace pod/certified-operators-9cdst ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="certified-operators-9cdst", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:15:21.486 - 5098s W alert/KubePodNotReady ns/openshift-marketplace pod/community-operators-l8gqw ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="community-operators-l8gqw", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:15:51.486 - 4168s W alert/KubePodNotReady ns/openshift-marketplace pod/redhat-marketplace-8ccxv ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="redhat-marketplace-8ccxv", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:15:51.486 - 5008s W alert/KubePodNotReady ns/openshift-marketplace pod/redhat-operators-kzqtc ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-marketplace", pod="redhat-operators-kzqtc", prometheus="openshift-monitoring/k8s", severity="warning"}}

and [bz-Unknown][invariant] alert/KubePodNotReady should not be at or above info in all the other namespaces failed:

{  KubePodNotReady was at or above info for at least 6h58m48s on platformidentification.JobType{Release:"4.14", FromRelease:"", Platform:"aws", Architecture:"amd64", Network:"ovn", Topology:"ha"} (maxAllowed=0s): pending for 4m26s, firing for 6h58m48s:

Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-ftp6h ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-ftp6h", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-h5l58 ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-h5l58", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-l5knj ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-l5knj", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-nrlwb ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-nrlwb", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4138s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-p5flb ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-p5flb", prometheus="openshift-monitoring/k8s", severity="warning"}
Jul 21 04:11:21.486 - 4438s W alert/KubePodNotReady ns/openshift-e2e-loki pod/loki-promtail-wwhfh ALERTS{alertname="KubePodNotReady", alertstate="firing", namespace="openshift-e2e-loki", pod="loki-promtail-wwhfh", prometheus="openshift-monitoring/k8s", severity="warning"}}

/test e2e-aws-ovn-serial

e2e-aws-ovn-upgrade failed because [sig-network] pods should successfully create sandboxes by other failed:

{  4 failures to create the sandbox

ns/openshift-etcd pod/etcd-ip-10-0-162-19.us-west-2.compute.internal node/ip-10-0-162-19.us-west-2.compute.internal - 3590.92 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name "k8s_etcd-ip-10-0-162-19.us-west-2.compute.internal_openshift-etcd_52f5fdf33cfa32e057a9bb276e376f5a_0": initializing source docker://registry.build01.ci.openshift.org/ci-op-qbvgwb37/stable@sha256:eede982cb21fa8c923df8179a7107b9ae8b0fde865d8dab000e167a063aefe62: Get "https://registry.build01.ci.openshift.org/openshift/token?scope=repository%3Aci-op-qbvgwb37%2Fstable%3Apull": read tcp 10.0.162.19:33252->52.206.202.27:443: read: connection reset by peer
ns/openshift-kube-apiserver pod/kube-apiserver-ip-10-0-162-19.us-west-2.compute.internal node/ip-10-0-162-19.us-west-2.compute.internal - 3450.99 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name "k8s_kube-apiserver-ip-10-0-162-19.us-west-2.compute.internal_openshift-kube-apiserver_c9a391afe53b4ddb5427bd1150776e7c_0": initializing source docker://registry.build01.ci.openshift.org/ci-op-qbvgwb37/stable@sha256:eede982cb21fa8c923df8179a7107b9ae8b0fde865d8dab000e167a063aefe62: Get "https://registry.build01.ci.openshift.org/openshift/token?scope=repository%3Aci-op-qbvgwb37%2Fstable%3Apull": read tcp 10.0.162.19:33264->52.206.202.27:443: read: connection reset by peer
ns/openshift-kube-controller-manager pod/kube-controller-manager-ip-10-0-162-19.us-west-2.compute.internal node/ip-10-0-162-19.us-west-2.compute.internal - 2695.06 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name "k8s_kube-controller-manager-ip-10-0-162-19.us-west-2.compute.internal_openshift-kube-controller-manager_17c9dd57431687feb1da5b94f8be248e_0": initializing source docker://registry.build01.ci.openshift.org/ci-op-qbvgwb37/stable@sha256:eede982cb21fa8c923df8179a7107b9ae8b0fde865d8dab000e167a063aefe62: Get "https://registry.build01.ci.openshift.org/openshift/token?scope=repository%3Aci-op-qbvgwb37%2Fstable%3Apull": read tcp 10.0.162.19:33248->52.206.202.27:443: read: connection reset by peer
ns/openshift-kube-scheduler pod/openshift-kube-scheduler-ip-10-0-162-19.us-west-2.compute.internal node/ip-10-0-162-19.us-west-2.compute.internal - 2847.06 seconds after deletion - reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = creating pod sandbox with name "k8s_openshift-kube-scheduler-ip-10-0-162-19.us-west-2.compute.internal_openshift-kube-scheduler_67c965e33524a208e909a8cd24e499b2_0": initializing source docker://registry.build01.ci.openshift.org/ci-op-qbvgwb37/stable@sha256:eede982cb21fa8c923df8179a7107b9ae8b0fde865d8dab000e167a063aefe62: Get "https://registry.build01.ci.openshift.org/openshift/token?scope=repository%3Aci-op-qbvgwb37%2Fstable%3Apull": read tcp 10.0.162.19:33254->52.206.202.27:443: read: connection reset by peer}

/test e2e-aws-ovn-upgrade

/hold cancel,
CI is just flaky.

Miciah · 2023-07-24T00:11:13Z

e2e-aws-ovn-serial failed because [sig-storage] PersistentVolumes-local Stress with local volumes [Serial] should be able to process many pods and reuse local volumes failed:

{  fail [test/e2e/storage/persistent_volumes-local.go:522]: persistentvolumes "local-pv6zw5t" not found
Error: exit with code 1
Ginkgo exit error 1: exit with code 1}

This test flake is being tracked with OCPBUGS-14930.
/test e2e-aws-ovn-serial

gcs278 · 2023-07-24T02:32:14Z

hold didn't come off when Miciah tried to remove it 🤔
/hold cancel

openshift-ci · 2023-07-24T02:45:48Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023

openshift-ci bot requested review from candita and Miciah January 27, 2023 20:18

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2023

gcs278 force-pushed the NE-1183 branch from 2f3a0d0 to 4614f29 Compare February 22, 2023 17:19

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023

Miciah force-pushed the NE-1183 branch 2 times, most recently from c387126 to 870c158 Compare March 1, 2023 06:07

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 7, 2023

openshift-ci bot assigned Miciah Mar 7, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023

gcs278 force-pushed the NE-1183 branch from 870c158 to c1719c2 Compare July 19, 2023 16:07

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2023

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023

gcs278 force-pushed the NE-1183 branch from c1719c2 to a67a195 Compare July 19, 2023 17:32

gcs278 force-pushed the NE-1183 branch from a67a195 to 1c68273 Compare July 19, 2023 18:18

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023

This was referenced Jul 20, 2023

OCPBUGS-16089: Set spec.subdomain on the canary route #965

Merged

OCPBUGS-15978: Check public DNS zone when reporting status #967

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023

openshift-merge-robot merged commit 31d9a02 into openshift:master Jul 24, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NE-1183: Rename unit tests for specific functions #880

NE-1183: Rename unit tests for specific functions #880

gcs278 commented Jan 27, 2023 •

edited

Loading

openshift-ci-robot commented Jan 27, 2023 •

edited by openshift-ci bot

Loading

gcs278 commented Jan 30, 2023

gcs278 commented Jan 31, 2023

gcs278 commented Feb 22, 2023

Miciah commented Mar 7, 2023

openshift-ci bot commented Mar 7, 2023

openshift-ci-robot commented Mar 7, 2023

Miciah commented Mar 9, 2023

Miciah commented Mar 13, 2023

gcs278 commented Mar 14, 2023

openshift-ci-robot commented Mar 20, 2023

gcs278 commented Mar 22, 2023

gcs278 commented Apr 5, 2023

gcs278 commented Apr 6, 2023

gcs278 commented Apr 7, 2023

gcs278 commented Apr 14, 2023

openshift-ci-robot commented Jun 19, 2023

openshift-ci-robot commented Jul 19, 2023 •

edited by openshift-ci bot

Loading

Miciah commented Jul 19, 2023

Miciah commented Jul 19, 2023

openshift-ci-robot commented Jul 19, 2023

openshift-ci-robot commented Jul 20, 2023

Miciah commented Jul 20, 2023

Miciah commented Jul 21, 2023

openshift-ci-robot commented Jul 21, 2023

openshift-ci-robot commented Jul 21, 2023

Miciah commented Jul 23, 2023

Miciah commented Jul 24, 2023 •

edited

Loading

gcs278 commented Jul 24, 2023

openshift-ci bot commented Jul 24, 2023

NE-1183: Rename unit tests for specific functions #880

NE-1183: Rename unit tests for specific functions #880

Conversation

gcs278 commented Jan 27, 2023 • edited Loading

openshift-ci-robot commented Jan 27, 2023 • edited by openshift-ci bot Loading

gcs278 commented Jan 30, 2023

gcs278 commented Jan 31, 2023

gcs278 commented Feb 22, 2023

Miciah commented Mar 7, 2023

openshift-ci bot commented Mar 7, 2023

openshift-ci-robot commented Mar 7, 2023

Miciah commented Mar 9, 2023

Miciah commented Mar 13, 2023

gcs278 commented Mar 14, 2023

openshift-ci-robot commented Mar 20, 2023

gcs278 commented Mar 22, 2023

gcs278 commented Apr 5, 2023

gcs278 commented Apr 6, 2023

gcs278 commented Apr 7, 2023

gcs278 commented Apr 14, 2023

openshift-ci-robot commented Jun 19, 2023

openshift-ci-robot commented Jul 19, 2023 • edited by openshift-ci bot Loading

Miciah commented Jul 19, 2023

Miciah commented Jul 19, 2023

openshift-ci-robot commented Jul 19, 2023

openshift-ci-robot commented Jul 20, 2023

Miciah commented Jul 20, 2023

Miciah commented Jul 21, 2023

openshift-ci-robot commented Jul 21, 2023

openshift-ci-robot commented Jul 21, 2023

Miciah commented Jul 23, 2023

Miciah commented Jul 24, 2023 • edited Loading

gcs278 commented Jul 24, 2023

openshift-ci bot commented Jul 24, 2023

gcs278 commented Jan 27, 2023 •

edited

Loading

openshift-ci-robot commented Jan 27, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jul 19, 2023 •

edited by openshift-ci bot

Loading

Miciah commented Jul 24, 2023 •

edited

Loading