-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1183: Rename unit tests for specific functions #880
Conversation
@gcs278: This pull request references NE-1183 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
1 similar comment
/retest-required |
@Miciah rebased |
c387126
to
870c158
Compare
/approve This is just renaming unit tests; no docs, PX, or QE required. /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
|
|
|
|
Must gather failure |
|
@gcs278: This pull request references NE-1183 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I noticed two errors in the commit message. First, #854 already renamed
Second, this is incorrect:
Change "Service" to "DaemonSet". Also, add
(This one was probably my fault—sorry!) |
For each unit test "TestFoo" that specifically tests a function name "Foo" or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively. * pkg/dns/alibaba/dns_test.go (TestGetRR): Rename from this... (Test_getRR): ...to this. (TestParseZone): Rename from this... (Test_parseZone): ...to this. * pkg/dns/alibaba/util/numbers_test.go (TestClamp): Rename from this... (Test_Clamp): ...to this. * pkg/dns/aws/dns_test.go (TestZoneMatchesTags): Rename from this... (Test_zoneMatchesTags): ...to this. (TestZoneIDFromResource): Rename from this... (Test_zoneIDFromResource): ...to this. * pkg/dns/azure/dns_test.go (TestEnsureDNS): Rename from this... (Test_Ensure): ...to this. (TestDeleteDNS): Rename from this... (Test_Delete): ...to this. * pkg/dns/ibm/private/dnssvcs_provider_test.go (TestDelete): Rename from this... (Test_Delete): ...to this. (TestCreateOrUpdate): Rename from this... (Test_createOrUpdateDNSRecord): ...to this. * pkg/dns/ibm/public/cis_provider_test.go (TestDelete): Rename from this... (Test_Delete): ...to this. (TestCreateOrUpdate): Rename from this... (Test_createOrUpdateDNSRecord): ...to this. * pkg/operator/controller/canary/controller_test.go (TestCycleServicePort): Rename from this... (Test_cycleServicePort): ...to this. * pkg/operator/controller/canary/daemonset_test.go (TestDesiredCanaryDaemonSet Rename from this... (Test_desiredCanaryDaemonSet): ...to this. (TestCanaryDaemonsetChanged Rename from this... (Test_canaryDaemonsetChanged): ...to this. * pkg/operator/controller/canary/namespace_test.go (TestCanaryNamespaceChanged): Rename from this... (Test_canaryNamespaceChanged): ...to this. * pkg/operator/controller/canary/route_test.go (TestDesiredCanaryRoute): Rename from this... (Test_desiredCanaryRoute): ...to this. (TestCanaryRouteChanged): Rename from this... (Test_canaryRouteChanged): ...to this. * pkg/operator/controller/canary/service_test.go (TestDesiredCanaryService): Rename from this... (Test_desiredCanaryService): ...to this. * pkg/operator/controller/certificate-publisher/publish_certs_test.go (TestDesiredRouterCertsGlobalSecret): Rename from this... (Test_desiredRouterCertsGlobalSecret): ...to this. * pkg/operator/controller/certificate/default_cert_test.go (TestDesiredRouterDefaultCertificateSecret): Rename from this... (Test_desiredRouterDefaultCertificateSecret): ...to this. * pkg/operator/controller/dns/controller_test.go (TestPublishRecordToZones): Rename from this... (Test_publishRecordToZones): ...to this. (TestMigrateDNSRecordStatus): Rename from this... (Test_migrateRecordStatusConditions): ...to this. (TestDnsZoneStatusSlicesEqual): Rename from this... (Test_dnsZoneStatusSlicesEqual): ...to this. (TestRecordIsAlreadyPublishedToZone): Rename from this... (Test_recordIsAlreadyPublishedToZone): ...to this. (TestCustomCABundle): Rename from this... (Test_customCABundle): ...to this. * pkg/operator/controller/ingress/controller_test.go (TestSetDefaultDomain): Rename from this... (Test_setDefaultDomain): ...to this. (TestTLSProfileSpecForSecurityProfile): Rename from this... (Test_tlsProfileSpecForSecurityProfile): ...to this. (TestTLSProfileSpecForIngressController): Rename from this... (Test_tlsProfileSpecForIngressController): ...to this. (TestValidateHTTPHeaderBufferValues): Rename from this... (Test_validateHTTPHeaderBufferValues): ...to this. (TestValidateClientTLS): Rename from this... (Test_validateClientTLS): ...to this. (TestIsProxyProtocolNeeded): Rename from this... (Test_IsProxyProtocolNeeded): ...to this. * pkg/operator/controller/ingress/deployment_test.go (TestDesiredRouterDeployment): Rename from this... (Test_desiredRouterDeployment): ...to this. (TestInferTLSProfileSpecFromDeployment): Rename from this... (Test_inferTLSProfileSpecFromDeployment): ...to this. (TestDeploymentConfigChanged): Rename from this... (Test_deploymentConfigChanged): ...to this. (TestDurationToHAProxyTimespec): Rename from this... (Test_durationToHAProxyTimespec): ...to this. (TestCapReloadIntervalValue): Rename from this... (Test_capReloadIntervalValue): ...to this. (TestGetMIMETypes): Rename from this... (Test_GetMIMETypes): ...to this. * pkg/operator/controller/ingress/dns_test.go (TestDesiredWildcardDNSRecord): Rename from this... (Test_desiredWildcardDNSRecord): ...to this. (TestManageDNSForDomain): Rename from this... (Test_manageDNSForDomain): ...to this. * pkg/operator/controller/ingress/load_balancer_service_test.go (TestDesiredLoadBalancerService): Rename from this... (Test_desiredLoadBalancerService): ... to this. (TestShouldUseLocalWithFallback): Rename from this... (Test_shouldUseLocalWithFallback): ...to this. (TestLoadBalancerServiceChanged): Rename from this... (Test_loadBalancerServiceChanged): ...to this. (TestLoadBalancerServiceAnnotationsChanged): Rename from this... (Test_loadBalancerServiceAnnotationsChanged): ...to this. (TestServiceIngressOwner): Rename from this... (Test_isServiceOwnedByIngressController): ... to this. * pkg/operator/controller/ingress/metrics_test.go (TestDeleteIngressControllerConditionsMetric): Rename from this... (Test_DeleteIngressControllerConditionsMetric): ...to this. (TestIngressControllerNLBMetric): Rename from this... (Test_SetIngressControllerNLBMetric): ...to this. * pkg/operator/controller/ingress/monitoring_test.go (TestServiceMonitorChanged): Rename from this... (Test_serviceMonitorChanged): ...to this. * pkg/operator/controller/ingress/namespace_test.go (TestRouterNamespaceChanged): Rename from this... (Test_routerNamespaceChanged): ...to this. * pkg/operator/controller/ingress/nodeport_service_test.go (TestDesiredNodePortService): Rename from this... (Test_desiredNodePortService): ...to this. (TestNodePortServiceChanged): Rename from this... (Test_nodePortServiceChanged): ...to this. * pkg/operator/controller/ingress/poddisruptionbudget_test.go (TestDesiredPodDisruptionBudget): Rename from this... (Test_desiredRouterPodDisruptionBudget): ...to this. (TestPodDisruptionBudgetChange): Rename from this... (Test_podDisruptionBudgetChange): ...to this. * pkg/operator/controller/ingress/status_test.go (TestComputeIngressDegradedCondition): Rename from this... (Test_computeIngressDegradedCondition): ...to this. (TestComputeDeploymentRollingOutCondition): Rename from this... (Test_computeDeploymentRollingOutCondition): ...to this. (TestComputeLoadBalancerProgressingStatus): Rename from this... (Test_computeLoadBalancerProgressingStatus): ...to this. (TestComputeDeploymentAvailableCondition): Rename from this... (Test_computeDeploymentAvailableCondition): ...to this. (TestComputeDeploymentReplicasMinAvailableCondition): Rename from this... (Test_computeDeploymentReplicasMinAvailableCondition): ...to this. (TestComputeDeploymentReplicasAllAvailableCondition): Rename from this... (Test_computeDeploymentReplicasAllAvailableCondition): ...to this. (TestComputeLoadBalancerStatus): Rename from this... (Test_computeLoadBalancerStatus): ...to this. (TestComputeIngressProgressingCondition): Rename from this... (Test_computeIngressProgressingCondition): ...to this. (TestComputeIngressAvailableCondition): Rename from this... (Test_computeIngressAvailableCondition): ...to this. (TestIngressStatusesEqual): Rename from this... (Test_ingressStatusesEqual): ...to this. (TestComputeDNSStatus): Rename from this... (Test_computeDNSStatus): ...to this. (TestMergeConditions): Rename from this... (Test_MergeConditions): ...to this. (TestZoneInConfig): Rename from this... (Test_checkZoneInConfig): ...to this. (TestComputeIngressUpgradeableCondition): Rename from this... (Test_computeIngressUpgradeableCondition): ...to this. (TestComputeIngressEvaluationConditionsDetectedCondition): Rename from this... (Test_computeIngressEvaluationConditionsDetectedCondition): ...to this. * pkg/operator/controller/ingressclass/ingressclass_test.go (TestDesiredIngressClass): Rename from this... (Test_desiredIngressClass): ...to this. (TestIngressClassChanged): Rename from this... (Test_ingressClassChanged): ...to this. * pkg/operator/controller/status/controller_test.go (TestComputeOperatorProgressingCondition): Rename from this... (Test_computeOperatorProgressingCondition): ...to this. (TestOperatorStatusesEqual): Rename from this... (Test_operatorStatusesEqual): ...to this. (TestComputeOperatorStatusVersions): Rename from this... (Test_computeOperatorStatusVersions): ...to this. (TestComputeOperatorUpgradeableCondition): Rename from this... (Test_computeOperatorUpgradeableCondition): ...to this. * pkg/operator/controller/sync-http-error-code-configmap/controller_test.go (TestDesiredHttpErrorCodeConfigMap): Rename from this... (Test_desiredHttpErrorCodeConfigMap): ...to this. * pkg/util/aws/shared_credentials_file_test.go (TestSharedCredentialsFileFromSecret): Rename from this... (Test_SharedCredentialsFileFromSecret): ...to this. * pkg/util/hash_test.go (TestHash): Rename from this... (Test_Hash): ...to this. * pkg/util/network_test.go (TestURI): Rename from this... (Test_URI): ...to this. * pkg/dns/gcp/provider_test.go: (TestParseZone): Rename from this... (Test_ParseZone): ...to this.
Oops, missing close parenthesis here:
But good enough. * grin *. |
e2e-aws-ovn-serial failed because
/test e2e-aws-ovn-serial |
e2e-aws-ovn-serial failed because AWS is full:
/test e2e-aws-ovn-serial |
/hold Revision 1c68273 was retested 3 times: holding |
e2e-aws-ovn-serial failed because
and
/test e2e-aws-ovn-serial e2e-aws-ovn-upgrade failed because
/test e2e-aws-ovn-upgrade /hold cancel, |
e2e-aws-ovn-serial failed because
This test flake is being tracked with OCPBUGS-14930. |
hold didn't come off when Miciah tried to remove it 🤔 |
@gcs278: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
For each unit test "TestFoo" that specifically tests a function name "Foo"
or "foo", rename "TestFoo" to "Test_Foo" or "Test_foo", respectively.
(Test_getRR): ...to this.
(TestParseZone): Rename from this...
(Test_parseZone): ...to this.
(Test_Clamp): ...to this.
(Test_zoneMatchesTags): ...to this.
(TestZoneIDFromResource): Rename from this...
(Test_zoneIDFromResource): ...to this.
(Test_Ensure): ...to this.
(TestDeleteDNS): Rename from this...
(Test_Delete): ...to this.
this...
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.
(Test_Delete): ...to this.
(TestCreateOrUpdate): Rename from this...
(Test_createOrUpdateDNSRecord): ...to this.
(TestCycleServicePort): Rename from this...
(Test_cycleServicePort): ...to this.
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.
(TestCanaryNamespaceChanged): Rename from this...
(Test_canaryNamespaceChanged): ...to this.
Rename from this...
(Test_desiredCanaryRoute): ...to this.
(TestCanaryRouteChanged): Rename from this...
(Test_canaryRouteChanged): ...to this.
(TestDesiredCanaryService): Rename from this...
(Test_desiredCanaryService): ...to this.
(TestDesiredRouterCertsGlobalSecret): Rename from this...
(Test_desiredRouterCertsGlobalSecret): ...to this.
(TestDesiredRouterDefaultCertificateSecret): Rename from this...
(Test_desiredRouterDefaultCertificateSecret): ...to this.
(TestPublishRecordToZones): Rename from this...
(Test_publishRecordToZones): ...to this.
(TestMigrateDNSRecordStatus): Rename from this...
(Test_migrateRecordStatusConditions): ...to this.
(TestDnsZoneStatusSlicesEqual): Rename from this...
(Test_dnsZoneStatusSlicesEqual): ...to this.
(TestRecordIsAlreadyPublishedToZone): Rename from this...
(Test_recordIsAlreadyPublishedToZone): ...to this.
(TestCustomCABundle): Rename from this...
(Test_customCABundle): ...to this.
(TestSetDefaultDomain): Rename from this...
(Test_setDefaultDomain): ...to this.
(TestTLSProfileSpecForSecurityProfile): Rename from this...
(Test_tlsProfileSpecForSecurityProfile): ...to this.
(TestTLSProfileSpecForIngressController): Rename from this...
(Test_tlsProfileSpecForIngressController): ...to this.
(TestValidateHTTPHeaderBufferValues): Rename from this...
(Test_validateHTTPHeaderBufferValues): ...to this.
(TestValidateClientTLS): Rename from this...
(Test_validateClientTLS): ...to this.
(TestIsProxyProtocolNeeded): Rename from this...
(Test_IsProxyProtocolNeeded): ...to this.
(TestDesiredRouterDeployment): Rename from this...
(Test_desiredRouterDeployment): ...to this.
(TestInferTLSProfileSpecFromDeployment): Rename from this...
(Test_inferTLSProfileSpecFromDeployment): ...to this.
(TestDeploymentConfigChanged): Rename from this...
(Test_deploymentConfigChanged): ...to this.
(TestDurationToHAProxyTimespec): Rename from this...
(Test_durationToHAProxyTimespec): ...to this.
(TestCapReloadIntervalValue): Rename from this...
(Test_capReloadIntervalValue): ...to this.
(TestGetMIMETypes): Rename from this...
(Test_GetMIMETypes): ...to this.
(TestDesiredWildcardDNSRecord): Rename from this...
(Test_desiredWildcardDNSRecord): ...to this.
(TestManageDNSForDomain): Rename from this...
(Test_manageDNSForDomain): ...to this.
(TestDesiredLoadBalancerService): Rename from this...
(Test_desiredLoadBalancerService): ... to this.
(TestShouldUseLocalWithFallback): Rename from this...
(Test_shouldUseLocalWithFallback): ...to this.
(TestLoadBalancerServiceChanged): Rename from this...
(Test_loadBalancerServiceChanged): ...to this.
(TestLoadBalancerServiceAnnotationsChanged): Rename from this...
(Test_loadBalancerServiceAnnotationsChanged): ...to this.
(TestServiceIngressOwner): Rename from this...
(Test_isServiceOwnedByIngressController): ... to this.
(TestDeleteIngressControllerConditionsMetric): Rename from this...
(Test_DeleteIngressControllerConditionsMetric): ...to this.
(TestIngressControllerNLBMetric): Rename from this...
(Test_SetIngressControllerNLBMetric): ...to this.
(TestServiceMonitorChanged): Rename from this...
(Test_serviceMonitorChanged): ...to this.
(TestRouterNamespaceChanged): Rename from this...
(Test_routerNamespaceChanged): ...to this.
(TestDesiredNodePortService): Rename from this...
(Test_desiredNodePortService): ...to this.
(TestNodePortServiceChanged): Rename from this...
(Test_nodePortServiceChanged): ...to this.
(TestDesiredPodDisruptionBudget): Rename from this...
(Test_desiredRouterPodDisruptionBudget): ...to this.
(TestPodDisruptionBudgetChange): Rename from this...
(Test_podDisruptionBudgetChange): ...to this.
(TestComputePodsScheduledCondition): Rename from this...
(Test_computeDeploymentPodsScheduledCondition): ...to this.
(TestComputeIngressDegradedCondition): Rename from this...
(Test_computeIngressDegradedCondition): ...to this.
(TestComputeDeploymentRollingOutCondition): Rename from this...
(Test_computeDeploymentRollingOutCondition): ...to this.
(TestComputeLoadBalancerProgressingStatus): Rename from this...
(Test_computeLoadBalancerProgressingStatus): ...to this.
(TestComputeDeploymentAvailableCondition): Rename from this...
(Test_computeDeploymentAvailableCondition): ...to this.
(TestComputeDeploymentReplicasMinAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasMinAvailableCondition): ...to this.
(TestComputeDeploymentReplicasAllAvailableCondition): Rename from this...
(Test_computeDeploymentReplicasAllAvailableCondition): ...to this.
(TestComputeLoadBalancerStatus): Rename from this...
(Test_computeLoadBalancerStatus): ...to this.
(TestComputeIngressProgressingCondition): Rename from this...
(Test_computeIngressProgressingCondition): ...to this.
(TestComputeIngressAvailableCondition): Rename from this...
(Test_computeIngressAvailableCondition): ...to this.
(TestIngressStatusesEqual): Rename from this...
(Test_ingressStatusesEqual): ...to this.
(TestComputeDNSStatus): Rename from this...
(Test_computeDNSStatus): ...to this.
(TestMergeConditions): Rename from this...
(Test_MergeConditions): ...to this.
(TestZoneInConfig): Rename from this...
(Test_checkZoneInConfig): ...to this.
(TestComputeIngressUpgradeableCondition): Rename from this...
(Test_computeIngressUpgradeableCondition): ...to this.
(TestComputeIngressEvaluationConditionsDetectedCondition): Rename from
this...
(Test_computeIngressEvaluationConditionsDetectedCondition): ...to this.
(TestDesiredIngressClass): Rename from this...
(Test_desiredIngressClass): ...to this.
(TestIngressClassChanged): Rename from this...
(Test_ingressClassChanged): ...to this.
(TestComputeOperatorProgressingCondition): Rename from this...
(Test_computeOperatorProgressingCondition): ...to this.
(TestOperatorStatusesEqual): Rename from this...
(Test_operatorStatusesEqual): ...to this.
(TestComputeOperatorStatusVersions): Rename from this...
(Test_computeOperatorStatusVersions): ...to this.
(TestComputeOperatorUpgradeableCondition): Rename from this...
(Test_computeOperatorUpgradeableCondition): ...to this.
(TestDesiredHttpErrorCodeConfigMap): Rename from this...
(Test_desiredHttpErrorCodeConfigMap): ...to this.
(TestSharedCredentialsFileFromSecret): Rename from this...
(Test_SharedCredentialsFileFromSecret): ...to this.
(Test_Hash): ...to this.
(Test_URI): ...to this.
(Test_ParseZone): ...to this.