Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1184: Test_desiredHttpErrorCodeConfigMap: Kill dead code and fix format #881

Merged
merged 2 commits into from
Mar 3, 2023
Merged

NE-1184: Test_desiredHttpErrorCodeConfigMap: Kill dead code and fix format #881

merged 2 commits into from
Mar 3, 2023

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Jan 27, 2023 •
edited by openshift-ci bot
Loading

Test_desiredHttpErrorCodeConfigMap: Kill dead code

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Delete some dead code.

NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for
    string interpolation with Go string formats.

@Miciah @gcs278
NE-1184: Test_desiredHttpErrorCodeConfigMap: Kill dead code
5781345 
* pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
(Test_desiredHttpErrorCodeConfigMap): Delete some dead code.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2023 •
edited by openshift-ci bot
Loading

@gcs278: This pull request references NE-1184 which is a valid jira issue.

In response to this:

Test_desiredHttpErrorCodeConfigMap: Kill dead code

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Delete some dead code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 30, 2023

/retest-required

@Miciah @gcs278
NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format
66defd0 
* pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
(Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for
string interpolation with Go string formats.
@gcs278 gcs278 changed the title NE-1184: Test_desiredHttpErrorCodeConfigMap: Kill dead code NE-1184: Test_desiredHttpErrorCodeConfigMap: Kill dead code and fix format Jan 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2023 •
edited by openshift-ci bot
Loading

@gcs278: This pull request references NE-1184 which is a valid jira issue.

In response to this:

Test_desiredHttpErrorCodeConfigMap: Kill dead code

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Delete some dead code.

NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for
    string interpolation with Go string formats.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2023 •
edited by openshift-ci bot
Loading

@gcs278: This pull request references NE-1184 which is a valid jira issue.

In response to this:

Test_desiredHttpErrorCodeConfigMap: Kill dead code

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Delete some dead code.

NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
    (Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for
    string interpolation with Go string formats.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278 gcs278 mentioned this pull request Jan 30, 2023
Closed
@gcs278
Copy link
Contributor Author

gcs278 commented Jan 31, 2023

/retest

@Miciah
Copy link
Contributor

Miciah commented Mar 1, 2023 •
edited
Loading

/approve
/lgtm

This is just a small fix in a unit test; no docs, PX, or QE required.
/label docs-approved
/label px-approved
/label qe-approved

/retest
since #860 merged.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Mar 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6aa482c and 2 for PR HEAD 66defd0 in total

@Miciah
Copy link
Contributor

Miciah commented Mar 1, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Mar 1, 2023

Must-gather failed.
/retest-required

@Miciah
Copy link
Contributor

Miciah commented Mar 2, 2023

TestClientTLS failed on the test case with no client certificate and ClientCertificatePolicy set to "Required". My best guess is that the test is racy and is hitting a terminating router pod. The test uses waitForDeploymentComplete to wait until all new pods are available, but perhaps waitForDeploymentComplete should also wait until all old pods are terminated.

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Mar 2, 2023

TestClientTLS failed again.
/retest-required

2 similar comments
@Miciah
Copy link
Contributor

Miciah commented Mar 2, 2023

TestClientTLS failed again.
/retest-required

@Miciah
Copy link
Contributor

Miciah commented Mar 3, 2023

TestClientTLS failed again.
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023 •
edited
Loading

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 66defd0 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Mar 3, 2023

TestRouterCompressionOperation failed.
/retest-required

@openshift-merge-robot openshift-merge-robot merged commit a29464e into openshift:master Mar 3, 2023
@Miciah Miciah mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gcs278 @openshift-ci-robot @Miciah @openshift-merge-robot