Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format #882

Closed
wants to merge 1 commit into from
Closed

NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format #882

wants to merge 1 commit into from

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Jan 27, 2023

Test_desiredHttpErrorCodeConfigMap: Fix format

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go (Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for string interpolation with Go string formats.

@Miciah @gcs278
NE-1185: Test_desiredHttpErrorCodeConfigMap: Fix format
f8b8b2f 
* pkg/operator/controller/sync-http-error-code-configmap/controller_test.go
(Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for
string interpolation with Go string formats.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2023 •
edited by openshift-ci bot

@gcs278: This pull request references NE-1185 which is a valid jira issue.

In response to this:

Test_desiredHttpErrorCodeConfigMap: Fix format

  • pkg/operator/controller/sync-http-error-code-configmap/controller_test.go (Test_desiredHttpErrorCodeConfigMap): Replace Ruby-style #{} syntax for string interpolation with Go string formats.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278 by writing /assign @gcs278 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023 •
edited

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn f8b8b2f link false /test e2e-azure-ovn
ci/prow/e2e-gcp-ovn f8b8b2f link false /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node f8b8b2f link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 30, 2023

/retest-required

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 30, 2023

Closing per combining with #881

@gcs278 gcs278 closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@lmzuccarelli lmzuccarelli Awaiting requested review from lmzuccarelli

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcs278 @openshift-ci-robot @Miciah