-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.12] OCPBUGS-15467: Add missing AWS permission for ListTagsForResources #954
[release-4.12] OCPBUGS-15467: Add missing AWS permission for ListTagsForResources #954
Conversation
The defined CredentialsRequest is missing a required permission for the AWS "Provider.lookupZoneIDWithoutResourceTagging" method.
@Miciah: This pull request references Jira Issue OCPBUGS-15467, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
Verified using cluster bot
|
This backport is low-risk as it only adds a required permission and has been pre-merge verified. e2e-aws-operator failed because e2e-gcp-ovn-serial failed because
Also,
Let's see whether the same issue happens again. |
/label cherry-pick-approved |
/retest-required |
/retest-required |
/test e2e-aws-operator |
/hold Revision 49791ea was retested 3 times: holding |
/retest-required |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
d5fe3f4
into
openshift:release-4.12
@Miciah: Jira Issue OCPBUGS-15467: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-15467 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.12.0-0.nightly-2023-08-08-111329 |
…every 48h Rolling back changes from 26ebda9 (Bulk frequency reduce of 4.12 periodics to limit costs of CI platform, 2023-07-07, openshift#40924) and similar. These jobs are very cheap, because they do not launch a cluster (they just compare release image content), and running them more frequently gives plenty of post-merge time before a release gets cut to discuss what to do about changes like [1] adding route53:ListTagsForResources as an ingress permission in 4.12. [1]: openshift/cluster-ingress-operator#954
…every 48h (#42215) Rolling back changes from 26ebda9 (Bulk frequency reduce of 4.12 periodics to limit costs of CI platform, 2023-07-07, #40924) and similar. These jobs are very cheap, because they do not launch a cluster (they just compare release image content), and running them more frequently gives plenty of post-merge time before a release gets cut to discuss what to do about changes like [1] adding route53:ListTagsForResources as an ingress permission in 4.12. [1]: openshift/cluster-ingress-operator#954
This is a manual cherry-pick of #868.
pkg/manifests/bindata.go
had a conflict and had to be regenerated for the backport.The defined CredentialsRequest is missing a required permission for the AWS "Provider.lookupZoneIDWithoutResourceTagging" method.