Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-15644: Update TestAWSELBConnectionIdleTimeout to not use wildcard DNS record #959

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[release-4.12] OCPBUGS-15644: Update TestAWSELBConnectionIdleTimeout to not use wildcard DNS record #959

merged 1 commit into from
Jul 21, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #955

/assign gcs278

@gcs278
OCPBUGS-13810: Update TestAWSELBConnectionIdleTimeout to not use wild…
51cd04c 
…card DNS record

TestAWSELBConnectionIdleTimeout has been very flakey due to the fact that the
CI test runner cluster is failing to resolve the newly created wildcard DNS Record
in a reasonable time. To work around this, we switch to using ELB's hostname,
which is consistently resolving and adding the "Host" header to the HTTP request

`test/e2e/operator_test.go`: Modify TestAWSELBConnectionIdleTimeout to use
ELB hostname and Host header with route hostname
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 2, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15515 has been cloned as Jira Issue OCPBUGS-15644. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-15644: Update TestAWSELBConnectionIdleTimeout to not use wildcard DNS record

In response to this:

This is an automated cherry-pick of #955

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-15515: Update TestAWSELBConnectionIdleTimeout to not use wildcard DNS record [release-4.12] OCPBUGS-15644: Update TestAWSELBConnectionIdleTimeout to not use wildcard DNS record Jul 2, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 2, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15644, which is invalid:

  • expected dependent Jira Issue OCPBUGS-15515 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #955

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Miciah and miheer July 2, 2023 09:50
@melvinjoseph86
Copy link

/retest-required

@gcs278
Copy link
Contributor

gcs278 commented Jul 3, 2023

unrelated failures
/retest

@gcs278
Copy link
Contributor

gcs278 commented Jul 3, 2023

/assign @Miciah
@Miciah ready for review when you are.

@melvinjoseph86
Copy link

/test e2e-gcp-ovn-serial

@melvinjoseph86
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2023
@openshift-ci-robot
Copy link
Contributor

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-15644, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-15515 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-15515 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@melvinjoseph86
Copy link

/retest-required

@gcs278
Copy link
Contributor

gcs278 commented Jul 11, 2023

disruptions failures
/test e2e-gcp-ovn-serial

@Miciah
Copy link
Contributor

Miciah commented Jul 11, 2023

This is a low-risk change that only modifies an E2E test.
/label backport-risk-assessed
/approve
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@Miciah Miciah mentioned this pull request Jul 11, 2023
Merged
@melvinjoseph86
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 11, 2023
@melvinjoseph86
Copy link

/test e2e-gcp-ovn-serial

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 37c11f6 and 2 for PR HEAD 51cd04c in total

@gcs278
Copy link
Contributor

gcs278 commented Jul 12, 2023

disruption issues
/test e2e-gcp-ovn-serial

@gcs278
Copy link
Contributor

gcs278 commented Jul 14, 2023

/retest

@melvinjoseph86
Copy link

/test e2e-gcp-ovn-serial

@Miciah Miciah mentioned this pull request Jul 20, 2023
Merged
@Miciah
Copy link
Contributor

Miciah commented Jul 21, 2023

e2e-gcp-ovn-serial failed because [sig-instrumentation][Late] Alerts shouldn't report any unexpected alerts in firing or pending state failed:

{  fail [github.com/onsi/ginkgo/v2@v2.1.5-0.20220909190140-b488ab12695a/internal/suite.go:612]: Jul 19 18:09:26.954: Unexpected alerts fired or pending after the test run:

alert TelemeterClientFailures fired for 1816 seconds with labels: {namespace="openshift-monitoring", severity="warning"}
Ginkgo exit error 1: exit with code 1}

And also because [sig-arch] events should not repeat pathologically failed:

{  3 events happened too frequently

event happened 23 times, something is wrong: node/ci-op-5y4tr9l1-7b4ae-5r9ck-worker-b-vjxfm - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-5y4tr9l1-7b4ae-5r9ck-worker-b-vjxfm, macAddress annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-b-vjxfm" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-b-vjxfm"]
event happened 22 times, something is wrong: node/ci-op-5y4tr9l1-7b4ae-5r9ck-worker-c-kmf6j - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-5y4tr9l1-7b4ae-5r9ck-worker-c-kmf6j, macAddress annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-c-kmf6j" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-c-kmf6j"]
event happened 22 times, something is wrong: node/ci-op-5y4tr9l1-7b4ae-5r9ck-worker-f-ddtnh - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-5y4tr9l1-7b4ae-5r9ck-worker-f-ddtnh, macAddress annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-f-ddtnh" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-5y4tr9l1-7b4ae-5r9ck-worker-f-ddtnh"]}

This is possibly the same issue as OCPBUGS-10841, which was fixed in 4.14.
/test e2e-gcp-ovn-serial

@Miciah Miciah mentioned this pull request Jul 21, 2023
Merged
@Miciah
Copy link
Contributor

Miciah commented Jul 21, 2023

e2e-gcp-ovn-serial failed again

{  1 events happened too frequently

event happened 21 times, something is wrong: node/ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs, macAddress annotation not found for node "ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs"]}

As this is a known issue, and as this PR is only modifying E2E tests, we can ignore this failure.
/override ci/prow/e2e-gcp-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-gcp-ovn-serial

In response to this:

e2e-gcp-ovn-serial failed again

{  1 events happened too frequently

event happened 21 times, something is wrong: node/ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs - reason/ErrorReconcilingNode roles/worker [k8s.ovn.org/node-chassis-id annotation not found for node ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs, macAddress annotation not found for node "ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs" , k8s.ovn.org/l3-gateway-config annotation not found for node "ci-op-kd787867-7b4ae-856z6-worker-b-dsrhs"]}

As this is a known issue, and as this PR is only modifying E2E tests, we can ignore this failure.
/override ci/prow/e2e-gcp-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7a507e4 into openshift:release-4.12 Jul 21, 2023
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15644: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15644 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #955

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Awaiting requested review from Miciah

@miheer miheer Awaiting requested review from miheer

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

Assignees

@Miciah Miciah

@gcs278 gcs278

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @melvinjoseph86 @gcs278 @Miciah @lihongan @openshift-merge-robot @ShudiLi