[WIP]: bump etcd to 3.3.17 #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
use set instead of slice as interval value fixes etcd-io#10326
[Cherry pick 3.3] grpcproxy: fix memory leak
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
When using the embed package to embed etcd, sometimes the storage prefix being used might be full. In this case, this code path triggers, causing an: `etcdserver: create wal error: no space left on device` error, which causes a fatal. A fatal differs from a panic in that it also calls os.Exit(1). In this situation, the calling program that embeds the etcd server will be abruptly killed, which prevents it from cleaning up safely, and giving a proper error message. Depending on what the calling program is, this can cause corruption and data loss. This patch switches the fatal to a panic. Ideally this would be a regular error which would get propagated upwards to the StartEtcd command, but in the meantime at least this can be caught with recover(). This fixes the most common fatal that I've experienced, but there are surely more that need looking into. If possible, the errors should be threaded down into the code path so that embedding etcd can be more robust. Fixes: etcd-io#10588 This is a cherry-picked version of upstream: 368f70a
etcdserver: Use panic instead of fatal on no space left error
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
This PR resolves an issue where the `/metrics` endpoints exposed by the proxy were not returning metrics of the etcd members servers but of the proxy itself. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
…-#10646-release-3.3 Automated cherry pick of etcd-io#10646
We need to use the stdlib-compatible one that is case-sensitive, etc Change-Id: Id0df573a70e09967ac7d8c0a63d99d6a49ce82f1
Change-Id: Iac4601443bcad71920fd96b97bfe21c16116577a
Change-Id: I1f3fc00f95efadd6da9b4c248156f8460ae0ff97
Change-Id: Ibfa24e28cacd58388f7606a945c8ac35e1c34580
…ugorji Using lessons learned from k8s changes: kubernetes/kubernetes#65034 Change-Id: Ia17a8f94ae6ed00c5af2595c2b48d3c9a0344427
Change-Id: I53b30e9317de6cd058833d743bc88c46686cea20
* Update Documentation folder Signed-off-by: lucperkins <lucperkins@gmail.com> * Re-add README file Signed-off-by: lucperkins <lucperkins@gmail.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
From etcd-io#10595. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
…ersion. Co-authored-by: Martin Weindel <martin.weindel@sap.com> Co-authored-by: Jingyi Hu <jingyih@google.com> Co-authored-by: Liming Liu <andyliuliming@outlook.com>
…f-#11194-origin-release-3.3 Automated cherry pick of etcd-io#11194 on release-3.3
…x IPv6 client endpoints
…-#11211-origin-release-3.3 Automated cherry pick of etcd-io#11211
…-#11184-origin-release-3.3 Automated cherry pick of etcd-io#11184
etcdserver: cherry-pick skip client san verification option for 3.3 version.
scripts: use https for git clone.
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Correcting a typo from 2f10964 (version: openshift-v4.0, 2018-11-29).
…uild. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
make build performs a sanity test on the binary image which causes problems for unsupport arch. Because we run full CI tests against the image this check is not nessisary and will allow images to be build regardless of arch. Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
|
@hexfusion: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close closing in favor of #20 |
|
@hexfusion: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 of 2
depends on #19